From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D31B43ACE; Fri, 9 Feb 2024 22:13:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F211A4067A; Fri, 9 Feb 2024 22:13:16 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2061.outbound.protection.outlook.com [40.107.94.61]) by mails.dpdk.org (Postfix) with ESMTP id 3C55B402AF for ; Fri, 9 Feb 2024 22:13:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VuLvEOueT1/o3zVKxJ+N6tbSCqBoNrzgOhkSfEkJpW8JMvQrLqCHV2HITNbgJ5FtpbaOZOZ9YsHjQU0uibBaV9PYkFV/khzbEHar06fhzFOaVucD+RvyiL692pz0jX4kXDF/lI6r7w4x32CmMG+J7dLcvC/KEZgadaultJM4yTxiz8P4PZpBxNBsoywVuFnFL5EX+VFIJh8j/C8zku5B0L2vnPqizxL2+lSDoyZ6/tFQhXzYheQ73149n5bpEVwnN23jyZZ3Sch0PWxxcnbi8qlXecrgkPRynKuy1ziXAYq2dXXkTqoV2tRAZNvhDwna72uJ8PrDbw9Tf3Jpxu40uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgFL0JlpIG6JjS3X4C8Ggb7SN/XN72fDB/x69HvA5Cw=; b=SwZfDJiNwdl5fwPCbYOveYEAVN/+UtJy3HNwaxA91VqM5YnMddyKZR1sUDXTcCjwBi41Jhq0pqmCanWdhR+jSof4ZspSHxZUhogXJwZJzcplSdYS+85bXLtfR8TRszh7NsTHVIs2LiX3HGKeqpB2pJxAAXEPN9F9hKQMTPFo+jEiRDuz1NmGoCulQ604SA+gviOb7Px5g9X/swwO0q5gNFWn8QVy7pJPJPCbzYN1mmYM9uZR7R2tqUBY9CelG/LS1g7PUk3FBLckCGHWgKeU9UrC/fJafg1y9HeXjNwuMbDyAWoqwlBvCZgRn82Ji/HU6JHqFn/Xdn6V1Q7i+TSTIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UgFL0JlpIG6JjS3X4C8Ggb7SN/XN72fDB/x69HvA5Cw=; b=eNxrg7ooSTiDKTHFIVG99FfP2xj0f4ZUQ/Tuq0QHiZitpRyNzI7z7HEyrq6+3msB0g9dk87T8x0/N6/vYyOSw572LvNW5aaasp1AN9tNImmH2icVHtirO1ptSJCHGPm5HnXd8GEQCquzAmsdrRllHCS0p389Ac+gWYGqEgo820A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW3PR12MB4585.namprd12.prod.outlook.com (2603:10b6:303:54::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.11; Fri, 9 Feb 2024 21:13:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7292.009; Fri, 9 Feb 2024 21:13:12 +0000 Message-ID: Date: Fri, 9 Feb 2024 21:13:08 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: recommend against using locks in event callbacks Content-Language: en-US To: Dariusz Sosnowski , David Marchand , "dev@dpdk.org" Cc: "ktraynor@redhat.com" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko References: <20240201084319.2687896-1-david.marchand@redhat.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0670.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW3PR12MB4585:EE_ X-MS-Office365-Filtering-Correlation-Id: 1cf2e0ac-80da-4535-eaf1-08dc29b3ec7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6zpriq4X4kC7xdMnvSNttkcUhlIx8AMrQ0pyEln5i3w9KNW2Yp1xMSWAOswHUwktX9xYNAVslxoeJaHnr1Zf5B6H9P7/KC2fHbKb9P3lMB0b3rZUVHNbrpuEwz8v4nVc+jo9VIfxDOTbxELbCTTe+mgYsh6YgcmRCBJV7s4QinhYK0o7KjcTmWuhtkJJPdJrAQFT1yKBA1k0vOnyyPDhgN/hgLtJTWWW51EMaHTMaBK2CsIh1+IhcZflwV+ckPgFwK/dScB9AR7r2Fx2vYFVMRKcAFoxZkOxcHIs8ttadtMnbLEc+CuYq5tal/KsMm54JWptIWnZonyuqxvppXi8rCf/E4hBLo4+Te0nhOol3hChrUecm0w3A6Gq0zZ8jVkYr7liBAmwNqPi4kSi8o0MzNtnX5gAhUiJSyKzSfk/gBoypXTBXQ9wiwG5XwphSXDqS32XxSsv0ESaO0+I1pRB1zPQ0vjnPLRdKxuYDmK1fvVrCHZExRFZ1A0HnxVyKLIhUKX7Icdeap4bTs4K5IM0FBocypwArKohJfzz6dQRmUTf6BT1+tYK5Bkbh6SnTnI0 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(346002)(396003)(366004)(376002)(230922051799003)(230273577357003)(1800799012)(186009)(64100799003)(451199024)(6506007)(6486002)(478600001)(41300700001)(31686004)(44832011)(4744005)(2906002)(5660300002)(316002)(54906003)(31696002)(6666004)(110136005)(36756003)(66476007)(66556008)(8936002)(4326008)(8676002)(66946007)(2616005)(83380400001)(86362001)(26005)(53546011)(38100700002)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmVFek4ydmR4V1B4L3o1cWYyRVU1UXRvS2NJUStHNzI2azV0enhQZm9yQ2c5?= =?utf-8?B?Q3N6QjIyS0FFa1JwVEM3VDJsanUveUVKMG9ZNGlhOWdlanh4eERLZ2NkMEpF?= =?utf-8?B?d2ZvU0NaT2w5TjloYmlRSEFObmpkZHVnYysydTd4dG9KMHFYUmo3WkpLWWF0?= =?utf-8?B?NVRKMFBNWW50VzhvVDJ1ckxhc3M4R0tBTjNUZXdWWmxVcHBQTWozaTErekFW?= =?utf-8?B?Wkl6NmtlTEUxNWorSkJYdzR3eEFMUFMwRWliNHp3eDZ5aDNOSUxOaE1hNmVp?= =?utf-8?B?M2VsTkxMd3M1RmlTeUQ5KzlxamYxakVtUVYwY21OZjYzOE15eHdtaUhKZXAx?= =?utf-8?B?Y1dHZkFubjBVd0xTSnNTRDdzUjRkWGUwQTNMYjhLajFFNFkwUHhDRGorMmFt?= =?utf-8?B?TG1xbitFKzJQSWtYZmg4VkZRdm84NDhrV2dMWFdXTHY4VXZFby9WaXJuMm5O?= =?utf-8?B?V00wQjdoU2tuODJodEdvcVE0ZHV5eHVMYis1dlZEMmx3N2FERGorVE5DRUYx?= =?utf-8?B?UjZXdlNQa2xIdGNIa1pEK1M2NkJrL0JRRmI0NWk2WnJLcnRBdTJGYU8xaVdB?= =?utf-8?B?Ny9GZ3FZYUY5SHY0RnozVzRiZFlDcmQrYXhiNitFWWhQVTFVZm9SdHlMZmd3?= =?utf-8?B?eU9LVTgxdUZ3SUhUTVlsb2hsSmpyazJJRUhDQkRXRndYT2VSYVo2L2N5QmRu?= =?utf-8?B?NFJkZldoNEl4RzZKT1N6Q3c0K1hwaGx6d1FrcDZockViM1NoQkVoVE5CaUt3?= =?utf-8?B?dmx2ZEVFZUwvMW1YNnViU0hITzkvQkhRaEd1bjBVam9sbEsvNGR3ajJRMjV0?= =?utf-8?B?VGVRWTlhdjJIYmJxQmh4bEd2QkJNR0lSVmFYT3dLcmxMZEoyZVVmbjBzUDY5?= =?utf-8?B?elllMVdFOWRWZ1VieFd4YXA2MXVzVHlnNDVoUVI3a0hJeFNxRW9vTU1NQk9i?= =?utf-8?B?U3FKTjZlY1lta0hNcWZLbFNZa1Rrby9Vc2IzWjJuU0ZXc3pJK0d6UFlJejhh?= =?utf-8?B?QkpzMklMdkFPTjFVZVQxcXUrTnR1TkxZc3dOVmgyemVSejlPQ3pjNE1vMW9z?= =?utf-8?B?cndDMHZIUXlBUnpmWmVjbldjdjNTZlJSOWxHdG5kUHhGUVZpOXVBSHRHblJn?= =?utf-8?B?VHNBMUFGbHZXUjY2dzhYNlNlQjY4YTljQkM0YzBQRmpjZW5xbWhMRDRsSmZE?= =?utf-8?B?TjNxTmhTai9WajFSY0ZlaXV1UUUvcTRpNUtjZkZFTy9wMGJwcW1MdGQ2cFAz?= =?utf-8?B?a3NDRklKWjl5SnVHSUl1bnFSMTVEVExucHZqSFRpb1NqVGdwaXZQYWttUmJQ?= =?utf-8?B?c1Y0Y2x5QzN4RnBrZjBsMytFZWRnbVhycW1POEpKdlNnNHRyd000OUxOby9J?= =?utf-8?B?MU91QzY4NktKTFF0M0hzZjI4ZTJFVlpISWNiQnVaQ3NMZnJYNWd4OUZrRTAv?= =?utf-8?B?Mm8zK1RaeEMvbGExV25xN1gyZlpRRFdZT1VsZSszc1I4TDloNjF1Wi9TeXp6?= =?utf-8?B?VjBGcytHNExsQjRpZGhydk1XcHM4TGpRRTlIZ3FkZmlYUDkvUnlsdEpmK2F0?= =?utf-8?B?RDZDNS85ZlVYR2MvU3YxdjhEZ1B1anJqU0tCQ1pYUGtMRjNVREtrNE50OXlo?= =?utf-8?B?OTZXK0JOOVM3SG1yUVQ0VjVVb0gwb1VCaEFEOFBKbmJtSDlka0dKZW1FdmY1?= =?utf-8?B?Y3hhMlhxbnp1blJRQVBud1hHZDlmM3FjOE1mc2ZtM3dLMWp1MTl5REJVU1BX?= =?utf-8?B?cDhxNHNYWXdnbHVSU1BzU2ZaaFBoMjNXSzY2Z3Rqbld0L1lYdktyYTJVS3Bk?= =?utf-8?B?YVNRTnh3MXJIVzdyRUhjbFZIMlBGM2hIbzcvWnNQU05iZjFFVjNONmtDUkdp?= =?utf-8?B?UGtWYThlL0lBcWJYK1ZWUEl3WHpwSlRKNVBJWlcyTmt2TXM4emlmSVJGTFA0?= =?utf-8?B?VytGd2FWWWRVd28zcmROOUUwMk1HVk1KRVZSWXpqUVdDdHdoQ2hWZjBiM2Zj?= =?utf-8?B?WUlRWkNWcGNyQ2NCNmR2VkhMY0NveG1jK1FzVE5IWlVKOHkrQmU2YWUveGJE?= =?utf-8?B?bXNVS1FDZUR6MXVwditya1ZXVTdLckNKMUxaRWsybzY0TXVMTVdpTWtya3Rj?= =?utf-8?Q?PfVDq4NogPFYBWo+yyM6TkM63?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cf2e0ac-80da-4535-eaf1-08dc29b3ec7e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 21:13:12.4838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V5bPKnp5tAav6gN0LjQNof7deMbSWW8bjiB/OWNlNL9BwR2YR58RQA3u2lF9dNet X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4585 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2024 4:07 PM, Dariusz Sosnowski wrote: >> -----Original Message----- >> From: David Marchand >> Sent: Thursday, February 1, 2024 09:43 >> To: dev@dpdk.org >> Cc: ktraynor@redhat.com; NBU-Contact-Thomas Monjalon (EXTERNAL) >> ; Ferruh Yigit ; Andrew >> Rybchenko >> Subject: [PATCH] ethdev: recommend against using locks in event callbacks >> >> As described in a recent bugzilla opened against the net/iavf driver, a driver >> may call a event callback from other calls of the ethdev API. >> >> Nothing guarantees in the ethdev API against such behavior. >> >> Add a notice against using locks in those callbacks. >> >> Bugzilla ID: 1337 >> >> Signed-off-by: David Marchand > Acked-by: Dariusz Sosnowski > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.