From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D639BA0524; Tue, 1 Jun 2021 13:07:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EFB140689; Tue, 1 Jun 2021 13:07:44 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id DFD4040041; Tue, 1 Jun 2021 13:07:42 +0200 (CEST) IronPort-SDR: yEv+X7sUgCGlrE1Uzp6LHPaUw8rL+r/pcalfMgnFDqepgAA+gQ7gk9bW1h39JJuq140nl3OZDf SASF80FHhu8g== X-IronPort-AV: E=McAfee;i="6200,9189,10001"; a="267399554" X-IronPort-AV: E=Sophos;i="5.83,239,1616482800"; d="scan'208";a="267399554" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 04:07:41 -0700 IronPort-SDR: WOQA5hKZOJdEsrJED5HP+U6TbbjobFdtpONIglodGAuai70H6ezmE09PAiYqojwxbH2yBoQPGR qj4IQy1OclMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,239,1616482800"; d="scan'208";a="411199019" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 01 Jun 2021 04:07:40 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 04:07:40 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 19:07:38 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.008; Tue, 1 Jun 2021 19:07:38 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/iavf: fix error handle for unsupported promisc configure Thread-Index: AQHXUhR5bfIJqeDS8EyefHrEOKv7F6r2DDCAgAj8I0A= Date: Tue, 1 Jun 2021 11:07:38 +0000 Message-ID: References: <20210526095305.1060069-1-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix error handle for unsupported promisc configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, May 27, 2021 9:54 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/iavf: fix error handle for unsupported promisc > configure >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, May 26, 2021 5:53 PM > > To: Xing, Beilei > > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > > Subject: [PATCH] net/iavf: fix error handle for unsupported promisc > > configure > > > > iavf_execute_vf_cmd returns standard error code but not IAVF_xxx, The > > patch fix the wrong error handling in iavf_config_promisc. > > > > Fixes: 1e4d55a7fe71 ("net/iavf: optimize promiscuous device > > operations") > > Cc: stable@dpdk.org > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/iavf/iavf_vchnl.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/iavf/iavf_vchnl.c > > b/drivers/net/iavf/iavf_vchnl.c index > > 5d57e8b541..02e828f9b7 100644 > > --- a/drivers/net/iavf/iavf_vchnl.c > > +++ b/drivers/net/iavf/iavf_vchnl.c > > @@ -1257,8 +1257,8 @@ iavf_config_promisc(struct iavf_adapter *adapter, > > PMD_DRV_LOG(ERR, > > "fail to execute command > > CONFIG_PROMISCUOUS_MODE"); > > > > - if (err =3D=3D IAVF_NOT_SUPPORTED) > > - return -ENOTSUP; > > + if (err =3D=3D -ENOTSUP) > > + return err; > > > > return -EAGAIN; > > } > > -- > > 2.26.2 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi >=20