From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DB3EA054D; Wed, 17 Feb 2021 17:30:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EB41160720; Wed, 17 Feb 2021 17:30:13 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 56E2E40690; Wed, 17 Feb 2021 17:30:11 +0100 (CET) IronPort-SDR: SK4vdbEjDXoZnNBYrz0UZgRH1cXL8VFCkcyjcoiFM9rweAHws6FkjGm0CMIVE2iO6JW/axpLub 0pcYbMvJXd9A== X-IronPort-AV: E=McAfee;i="6000,8403,9897"; a="244706409" X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="244706409" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 08:30:09 -0800 IronPort-SDR: 3q1d+izCsa8wbsLwMbQlS6g/sQO93WBwfrL6NCEWdWKhQKLmYSThKWRbLc4cToh1DqLsBJtKR2 jSrFDBvWw06A== X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="400020015" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.4.215]) ([10.252.4.215]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 08:30:07 -0800 To: Chas Williams , "Min Hu (Connor)" , Liang Zhang Cc: dev@dpdk.org, Vadim Podovinnikov , stable@dpdk.org, Declan Doherty References: <20191126115508.11138-1-podovinnikov@protei.ru> <20210217162656.1983277-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 17 Feb 2021 16:30:03 +0000 MIME-Version: 1.0 In-Reply-To: <20210217162656.1983277-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: fix LACP system address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/17/2021 4:26 PM, Ferruh Yigit wrote: > From: Vadim Podovinnikov > > In bond (LACP) we have several NICs (ports), when we have negotiation > with peer about what port we prefer, we send information about what > system we preferred in partner system name field. Peer also sends us > what partner system name it prefer. > > When we receive a message from it we must compare its preferred system > name with our system name, but not with our port mac address > > In my test I have several problems with that: > 1. If master port (mac address same as system address) shuts down (I > have two ports) I loose connection > 2. If secondary port (mac address not same as system address) receives > message before master port, my connection is not established. > > Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation") > Cc: stable@dpdk.org > > Signed-off-by: Vadim Podovinnikov > --- > Cc: zhangliang@bigo.sg > Cc: Declan Doherty > > v3: Re-sent with rebase > * Patch title updated, commit log updated with info shared in email > * Sign-off updated with full name > * Debug log slightly updated > * Syntax slightly updated This patch is waiting for review for a long time, if there is no objection I am planning to get it early in the release to give it a time to fix any possible issues.