From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B1EF04334B;
	Fri, 17 Nov 2023 02:06:01 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 20C5B40275;
	Fri, 17 Nov 2023 02:06:01 +0100 (CET)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id C5D4F40271
 for <dev@dpdk.org>; Fri, 17 Nov 2023 02:05:59 +0100 (CET)
Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.54])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SWdt3141hzsR92;
 Fri, 17 Nov 2023 09:02:35 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.31; Fri, 17 Nov 2023 09:05:57 +0800
Subject: Re: [PATCH] app/testpmd: fix set Tx offload command
To: Ferruh Yigit <ferruh.yigit@amd.com>, Aman Singh
 <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Dengdui
 Huang <huangdengdui@huawei.com>, Huisong Li <lihuisong@huawei.com>
CC: <dev@dpdk.org>, Song Jiale <songx.jiale@intel.com>, Zhimin Huang
 <zhiminx.huang@intel.com>
References: <20231116172155.951084-1-ferruh.yigit@amd.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <b7db45ed-89ae-dd55-deca-a198cb88dcca@huawei.com>
Date: Fri, 17 Nov 2023 09:05:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20231116172155.951084-1-ferruh.yigit@amd.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To
 dggpeml100024.china.huawei.com (7.185.36.115)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>

On 2023/11/17 1:21, Ferruh Yigit wrote:
> In command to set Tx offload:
> "port config <port_id> tx_offload <offload> on|off",
> 
> there is a defect in "on|off" comparison, so command does opposite of
> what is intended. Fixed comparison.
> 
> Fixes: 6280fe565b44 ("app/testpmd: allow offload config for all ports")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
> Cc: huangdengdui@huawei.com
> Cc: lihuisong@huawei.com
> Cc: Song Jiale <songx.jiale@intel.com>
> Cc: Zhimin Huang <zhiminx.huang@intel.com>
> ---
>  app/test-pmd/cmdline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index c040de7a7991..9369d3b4c526 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -11737,7 +11737,7 @@ cmd_config_per_port_tx_offload_parsed(void *parsed_result,
>  	struct cmd_config_per_port_tx_offload_result *res = parsed_result;
>  	bool on;
>  
> -	on = strcmp(res->on_off, "on");
> +	on = strcmp(res->on_off, "on") == 0;
>  	config_port_tx_offload(res->port_id, res->offload, on);
>  }
>  
>