From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7F4D4A0C41;
	Fri, 16 Apr 2021 10:34:24 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 68B701413C0;
	Fri, 16 Apr 2021 10:34:24 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by mails.dpdk.org (Postfix) with ESMTP id 4B63B1413B4
 for <dev@dpdk.org>; Fri, 16 Apr 2021 10:34:23 +0200 (CEST)
IronPort-SDR: i3FZcxJyG2MC7OcY1GwxwErOCmj0xIlmwTKPS6Q+KZPIllrHYLO3ByaVRlMpjhg/2YxWpVYJcB
 TU1Pw9lk7F9w==
X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="258966918"
X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="258966918"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 16 Apr 2021 01:34:22 -0700
IronPort-SDR: nD0pxpuo5sPf6yQo2Uffku1PrHfhxItNm0RZ3vcxozd9LUwtfVq62TtuHPwGxzwY57t/Q9X3yT
 kzTLPtWy3pNA==
X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="425514608"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.207.150])
 ([10.213.207.150])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 16 Apr 2021 01:34:20 -0700
To: "Min Hu (Connor)" <humin29@huawei.com>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "Power, Ciara" <ciara.power@intel.com>,
 "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1618051453-21264-1-git-send-email-humin29@huawei.com>
 <1618487412-26678-1-git-send-email-humin29@huawei.com>
 <1618487412-26678-3-git-send-email-humin29@huawei.com>
 <BYAPR11MB33669C758F661D8FDA525327FF4D9@BYAPR11MB3366.namprd11.prod.outlook.com>
 <62e706e0-a889-205e-436a-c5d9fd2f700d@huawei.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <b7e2e8f7-557b-6d02-1ddd-224ceeee52f1@intel.com>
Date: Fri, 16 Apr 2021 09:34:17 +0100
MIME-Version: 1.0
In-Reply-To: <62e706e0-a889-205e-436a-c5d9fd2f700d@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v3 2/2] test: fix missing check for thread
 creation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/16/2021 9:21 AM, Min Hu (Connor) wrote:
> 
> 
> 在 2021/4/16 1:05, Pattan, Reshma 写道:
>>
>>
>>> -----Original Message-----
>>> From: Min Hu (Connor) <humin29@huawei.com>
>>> +    if ((strcmp(env_value, "run_pdump_server_tests") == 0)) {
>>> +        rc = pthread_create(&thread, NULL, &send_pkts, NULL);
>>> +        if (rc != 0)
>>> +            rte_panic("Cannot start send pkts thread\n");
>>> +    }
>>
>>
>> I think you still have not addressed the David comment on previous version of 
>> the patch.
>> So , can you change this to  something like below
>>
>> Option1)
>> rc = pthread_create(&thread, NULL, &send_pkts, NULL);
>> If ( rc ! = 0 )
>> {
>>     rte_panic("Cannot start send pkts thread : %s\n", strerror(rc));
>> }
>>
>> Or
>>
>> Option2)
>> If ( pthread_create(&thread, NULL, &send_pkts, NULL) !=0 )
>>     rte_panic("Cannot start send pkts thread\n");
>>
>>
>> Also,
>>
>>>> test: fix missing check for thread creation
>> Change this subject line to  "test/pdump: fix missing check for thread creation"
>>
> Hi, Pattan, fixed in v4, except for "test/pdump", if v4 is OK, please
> modify it for me, @Ferruh, thanks.

Hi Connor, this patch is on David's domain, he will commit the patch, not me.