From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31E6FA0C46; Mon, 16 Aug 2021 16:04:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E08BA40143; Mon, 16 Aug 2021 16:04:42 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9D56E4003C for ; Mon, 16 Aug 2021 16:04:40 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="279609091" X-IronPort-AV: E=Sophos;i="5.84,326,1620716400"; d="scan'208";a="279609091" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 07:04:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,326,1620716400"; d="scan'208";a="572477155" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 16 Aug 2021 07:04:38 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 07:04:37 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 07:04:37 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 16 Aug 2021 07:04:37 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 16 Aug 2021 07:04:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ibimxT5C2xO5MONQG2LjGlnspgn8aGl7Np700PV0fZcZSVztEfbS2XzExHmlYWULvTvAqumEiaY38I9FmXd2I1OP2IrtklGQj0kWuj2+50C8X3MQuy6mUPA3tJKz7iL6uF2gVwJis4F6B+xA7KMnXtkqMTLFPj6bIk8zd28EnIdQzXNDPhXnS3UCc7kFe7Rw6/xL7aRlCJrZgcGGMMScKGM4B3EkCi0lkO7OM0R2JlOwHtOSQuXJYZ3XzzmOYgRrDXI6Rktkor3gtsC+z35VvHbRoz5Mf3Qvzn5oNuxel0++PtjD2Aihvpro51rokGoLHKCdDBZI+zxoanc2eI0vWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mJmxjFfnAV1lRo3mkVHe2r6YTC30LAtS2rgyCbI9h7U=; b=RCYlJGOseCHLro0Kh7h3HQ26yFt8hJouFNyhVZvi1OjjPdmCtdZsXX5FP0i1D/guj/F1z4CFjp5pyB4RVZXsb04V+Spt6eHssqUSkTeS75x1uArCJvyYhc2qTpIgFdpBXL+rpIG7WNfj7KKuzGkmxoYOLXUWiA57vHuxUpg9MvuMNLC2UDWfBb6k6NDjdKaPTwJ9AVSl02pvL489NdiDZgc1LG0c2cRXX7O1ZpUHKr74B2Od9mWRHSGUVazm1r7aHEGFnqtrXQtNJU1Db9o/am39BBSnr1SCo+GWUJAUnMJOVYYWVy5Pz8EQ/Bt7sQtHMywySmD++Z/bKrulPrzuAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mJmxjFfnAV1lRo3mkVHe2r6YTC30LAtS2rgyCbI9h7U=; b=QMm92HZ/vEfOlsT4x20lWU0ch5fejU4/DehpxnxEh/fSK+JEFypNr1w0Pe/iCyZU1aA6KZhu1jlKz84sp/LPdAsRB9qFJfDp8+TncQkFnV3yAujKC+wwW5mFspSqcuDyiP60Qq7kTtgtue+m/bPCqs5+DllhcllwEYb1O0L2348= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4871.namprd11.prod.outlook.com (2603:10b6:510:30::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.18; Mon, 16 Aug 2021 14:04:36 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.023; Mon, 16 Aug 2021 14:04:36 +0000 To: Heinrich Kuhn , Thomas Monjalon CC: , Andrew Rybchenko References: <20210518104115.1427712-1-ferruh.yigit@intel.com> <691e140d-ecd2-c963-0dc6-709b40be7f2b@oktetlabs.ru> <2313145.lpj6sdKJKW@thomas> <864ea6a9-68cb-cb91-4d73-7329ac2e95c1@netronome.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 16 Aug 2021 15:04:31 +0100 In-Reply-To: <864ea6a9-68cb-cb91-4d73-7329ac2e95c1@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6P193CA0011.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by DB6P193CA0011.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Mon, 16 Aug 2021 14:04:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9c5f0067-caa8-4f6c-0d5d-08d960bec7b7 X-MS-TrafficTypeDiagnostic: PH0PR11MB4871: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: usz30dbDDWnWtNCuMFXWSxBsUi8VcSJp+FMW6+OrcUbFgONMu7/vQ4ZphoQXKcmph0T5bTqC3lxVt6kRNqSPE4xgSyvKrMJFdK1D8ftqj1o0XVgPMDTcjfNGt6RPFEbENuNa73JPtMWEggyjN4/r93PpPVHEfZrjVgcWsAdYtS5WdvLIbjqTn0a8XblUbjJ97w8jJ5oxCW6szXmFttWjnWkIqvG8r671Cqakx2S813GwICFZRelVQdzvL6wTfDd+oOhYjVYnnhYRh5o60DFp265jZe51rsMJ6bSEFo6Tv5oLJXWraDeQj5U/hpOAPmhagwGMj19n/aY9zCpkPtrQsCS+9Wz4DEiep1edVcU7mlLTtXuxTrm54O4YphyRs1Qe0KKR5vT2EzrIUvzmCYYLDoVij/L2iHIsvhzOWXVGIE+Tx+KVJ0yRjeK3oU4wAi9nyU507lFW+DxKPmVHPuaPfXajtkgqmbEdZg8bIOw1sP8iFkyf5QuLUYCsS6nFvRTzNCQTYFtlzXJZWlOXijCIkr4awd/uRrh7QeFXr8kQqdxrTKvoQA/VcqJcTEFmHuTSEjPZDOR84gx5kfpw7tDHsX3Evks6CX1rOJ3XhyH6FDvw4ll6/Vl+kwRTa6465mt4hA6MG3IOUo2sRpzUbYrFEwyjZpM2TQGVK/6ngkgCm5EH12MynFDFtVG7nv52jO2LYB2WdAk2mhGWxt7mqsIugw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(2616005)(956004)(16576012)(316002)(44832011)(8936002)(110136005)(2906002)(8676002)(478600001)(4326008)(38100700002)(36756003)(6666004)(83380400001)(31696002)(66946007)(66476007)(66556008)(86362001)(31686004)(186003)(6486002)(5660300002)(53546011)(26005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZC9UQUk0OHJrSWZUQU44d0JMZWJjNmNyTVNnbXd5VCthaWJWZDF6Q0FMdTNk?= =?utf-8?B?b0tIVG5iY0xYeFhZS3VYZkRSQUZ0a2greUlZYm0xTmdUY09QRU9GYTRDZHBy?= =?utf-8?B?c2tsMHZ1Y3A4U1h6QU9GU2xNdGhPbHRsVEtJR1N3TWROYytsTjVabGJ3V24y?= =?utf-8?B?ZzNldDI2V0xNYnBmODRuK25ROW9kdXVFK2x3aUp3dkJMbWpqQUttdDE0ZHlN?= =?utf-8?B?TVo4NFQ1M21nanVVZFFKb0pEbW5Xc3NyczVicUVONHhacERuSG9lUUd2MHIx?= =?utf-8?B?QVo4VWJIUkdlWmYzV3dYK3VwRUM3Mk9ySHIrWHNjYlhmUWFwdzR3ZUx2K3ZY?= =?utf-8?B?WVdQcC95b2ZMRmc2cEYvbUFQdVFya0cwOEg3VlVIZVBEV3VyNDh5SldBVUlP?= =?utf-8?B?SXZvNERpNnkyU3FGbi9ZcjVjZ092WlRoTWhFeXd4UUQrTHcvcDY2NzlleWhk?= =?utf-8?B?WVdGYlNBQkxnb2ZPUnJhMjVreVp5TExMUnYydml1TTFnRFRWYTY1SkxpVzdo?= =?utf-8?B?MVFqOWZLUzRSbzlaN0N5QS81ZS9lRjVFTUxka24xeGwzdFRxOTdGeW5BRGsy?= =?utf-8?B?RTZKMGFlejVlTWNxL010Y292dHorKzBqTVQ2UGt4K1MvMmYyVHpsdjIySWVB?= =?utf-8?B?VXEzTGtQSGJJU3lzUHV4c1UwZ09lVFVUeUpiV251MzdpclBwOGZYMTFkM1Nt?= =?utf-8?B?MFAxN09vVE5aL2huNFlzYjJ6eHVkUXRkenNDZDF6UEozYTluYXJVSW54azJL?= =?utf-8?B?bG8rVjFBSmRGeW9mZWFkWmRVRjA2a2RaaG9qTkJSTXhIR3l5ZEpBallaSWhJ?= =?utf-8?B?aVJxRitFTDZFekhOd1ZmTlpKMEVMU2UyWmRJbmtQN2xDa0lid005Z0FHaXVO?= =?utf-8?B?eVloUExNNW5RdkVXWnFzYzR5ajRiV2Vnd2dXTUorUVNsWE1mNnBmRGlLMDIw?= =?utf-8?B?OFRIL1FwRU1CSWNWdjgrNmFwR09GNzFMK1ArSkw4dUpjWVNkOTNLbXhhbDM3?= =?utf-8?B?RUdZZ1dvQzZWejQ4QmZLSTlsUDBlM3BseWp3NDJVNW1sblRZUFFiQ1FSWWIx?= =?utf-8?B?Mk1hMGNiSy9laDRHU1B0dVlhZXQ4YTJVRGQ5VkF3TFZVN082eUdldUh0TUV3?= =?utf-8?B?TlpjSnp2QXVhbkFSWEdsTk9LZzhMRGI5bGJFT01iRXZzdW9VMFVpQkR1ZTl5?= =?utf-8?B?bk9IZ1o5YVEyRDVnbWxXRFdOaEFPRlNkNWY1aHUrYncwbm5HajllL0pwT0Rl?= =?utf-8?B?VDBVNUlWUUJWU01tTW04WmZOZno2djMzcU9MbFR2NlZwTFFVa0g4RWRTT0R5?= =?utf-8?B?TXRwM0V1NkRxVDUvajFmWXZGVkJTSmxZQkh3ek5vWkZHWWJDdzdoek5TcG9G?= =?utf-8?B?NkJreGUrN05ySTR1UmhLcWF3MXNOUnRZYWVhUzYzTDVjK0d3NXl0Qnd3czF4?= =?utf-8?B?SnMrUlpMVEZ2cTI3MlFlWFVLWDNrUzV4TUhZeDNNNkVOdEYreGpnNzk3ZWlr?= =?utf-8?B?dngyOGEyVFVKTlFXem1QOWIrYmQ1ZHp0bjhHVGVhVHFrSU13Qytua2tOa2hq?= =?utf-8?B?cDZ5ZnFWY1ZOZDJQdHZIZ2x5TlU4U3BYQkFTUVJwaVlSRTYzNURlS05xWkNM?= =?utf-8?B?VlJUUUZFaHVSZzFTbVpPa0RxTGppKy8rOC9UQzZGQmxhK2pBeDRaQWFKWVBi?= =?utf-8?B?Vml6TmxKK0cyK1ZUbnJGU1RTQllkWDhOTDlsRit3VGpVU0xWbnFmc3JDanZM?= =?utf-8?Q?L6IbanDGmUbs+0AmqdwtoGHK0rt00xVqgt+gyyL?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9c5f0067-caa8-4f6c-0d5d-08d960bec7b7 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2021 14:04:36.1884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: APFSk5gLO4T39qIg4St+Vo0XkE9C2VhxD5NUh+TmiM5nXXoOn09Oi6/QSebEo2WVk/plkNMReySjRrpuK4lfDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4871 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/29/2021 1:18 PM, Heinrich Kuhn wrote: > > > On 2021/07/23 16:14, Thomas Monjalon wrote: >> Please review. >> >> 28/06/2021 13:13, Andrew Rybchenko: >>> Hi Heinrich, >>> >>> could you take a look at the patch? >>> >>> Thanks, >>> Andrew. >>> >>> On 5/18/21 1:41 PM, Ferruh Yigit wrote: >>>> Logging should be converted to dynamic log. >>>> >>>> Signed-off-by: Ferruh Yigit >>>> --- >>>> drivers/net/nfp/nfp_net_logs.h | 7 ------- >>>> 1 file changed, 7 deletions(-) >>>> >>>> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h >>>> index 27dd87611b94..76cc94cb6565 100644 >>>> --- a/drivers/net/nfp/nfp_net_logs.h >>>> +++ b/drivers/net/nfp/nfp_net_logs.h >>>> @@ -30,14 +30,7 @@ extern int nfp_logtype_init; >>>> #define ASSERT(x) do { } while (0) >>>> #endif >>>> >>>> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP >>>> - >>>> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP >>>> -#define PMD_CPP_LOG(level, fmt, args...) \ >>>> - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) >>>> -#else >>>> #define PMD_CPP_LOG(level, fmt, args...) do { } while (0) >>>> -#endif >>>> >>>> extern int nfp_logtype_driver; >>>> #define PMD_DRV_LOG(level, fmt, args...) \ >> >> >> > Hi Andrew, > > Apologies for the delay, looks good thanks > > Reviewed-by: Heinrich Kuhn > Applied to dpdk-next-net/main, thanks.