From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B065F432BA; Mon, 6 Nov 2023 12:38:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C56A40633; Mon, 6 Nov 2023 12:38:16 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2050.outbound.protection.outlook.com [40.107.92.50]) by mails.dpdk.org (Postfix) with ESMTP id 7B9A9402AE; Mon, 6 Nov 2023 12:38:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OOidXReetnB9tIaavXbsxkL0MbXAwC91x2CumRgDQCdga+GH/2nRCzx5Dh1gT7i/ZN6meZL5S6wQHsf+aV2PMBiynaJOkaO7zL86MbGwB9nJY/5JZIIGLgoE612rXs/HzL0+QGIbTT0aWktTu0zdPibnVyDMnjPS+1rBNvRjG99TYV+jj6ZKCXGF/dNiO0u7l+v2xm9wCpPbWKYbvFGkDVLgtjQyb+95C9ri04b+aaW5mE35iG2HHa4qzup1JDf3Io76fFQmcBr69kmGByndtk7Txtf83WaLsN3fou6rJmyVIqOi+wHkys+4YztUNN/7fWs5SI6Qk/Syfsp+pJV+8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jqw6+tS1DFXNIvb663JodFz25aksfFyTlkwdk2F4eVQ=; b=FhUdZhkSEFY5XtlAy+oOe5C5ORUatnfdqGiRhWROJOhy43Ny3oVXTmb6mGb+83rkpSialp8NSlIUxHFVjxehwqo7fiiID5qvlMBefKvbhcHEbHw8VrJetlcFOBBt6AI0McmB91by8CiRLpsC/2SXNJVNAVAWuZimE0x2VfZf5L8FdovS7RwFWgxI/MeNF734G8Mnk4sIE/HWyBgQWGGnS9WNuqylIh96A4H6SU0TBg01rNa56XN+giCiDWNBMejsmg+4YLNbqYyP5hDwlcmNEJPR1zDCRenp2wUwioGnGWQcIqhf/zvBjIB5ZqIq0S0NdO5ZYX+LoisCivyBCZDQ4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jqw6+tS1DFXNIvb663JodFz25aksfFyTlkwdk2F4eVQ=; b=pYrYHh1YMelJM3IDaJSQPoLy5vDaLEZ5MN8fJyOWr9hQiYHcsvSheGh92yn8SIACJNN1iTLeP5zY8hBytTMXABPf7bCMQ4+sjvseSH9E1nBinocUluQboqrpZJ6ojlR5PXQKwpjqVFDDJfmO2ir1JLuz3PAshlZnWMMXX4RCkhQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA3PR12MB8810.namprd12.prod.outlook.com (2603:10b6:806:31f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Mon, 6 Nov 2023 11:38:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.028; Mon, 6 Nov 2023 11:38:12 +0000 Message-ID: Date: Mon, 6 Nov 2023 11:37:56 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/sfc: fix null dereference in syslog Content-Language: en-US To: Weiguo Li , viacheslav.galaktionov@arknetworks.am Cc: andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, stable@dpdk.org, Weiguo Li References: From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR5P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA3PR12MB8810:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f8a156b-eed5-4408-ab9c-08dbdebcdb43 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D0j4D7UneCtX4K81Zw0HROCtYXXiCefrH2mRpFIN7rJzR0Xed6GPeggYalSHoohVggEE2HeDlc9qtvP5t79PY/gOVo400WIBvymu3Tug/Ydk/5LPD5VOlio2DbvCDJngJfHY23CdEkHPoArIlvUy65nmyDB7eUlfAHj2wMHTkiqyU+vg9Nbj20+yTaxcL1urHp/AYWQ62oio6Flxn+WTySjszDsiNypgKfN/IQnA8kciAD8lLXBa0qJJNOPWEOGvlUNRLV2zGT3dO9+uv489TCvoBqSizgl0Ue+cycWJJDhiSrR7CFDmWJl4RXVaVFiPQ3IipT15txeb2NK73xcUpZJsYKrdAjAQ6ZLRkk+/OrGiPidP/e2B9zLGIKVP42ArguF58XL5l2wXhL6Mbuh039X1nLqR4LkX7QCDvnopJ88ZkTTnsi6pAN2DrFf5ZY7DZxst4g1XN7dH9+iSf4XIipzIX28S08S1YoRjeWfX7zzI+uS7lRMwpm7G3nLLxHDp7aziqcYb6f6xzylO+MrkipDKD0/RceUOljaW8AzkzO6SCpSAnRkd6LXK9r/ar3Dt0ptmDadZaRnNmEHlLfm9XTXZCF1+2KtSnSA3BWvPOnZZFtYI/K2qNqnI9P4bdjMcnCy97GYEDPaizJObjIyi4g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(136003)(346002)(376002)(39860400002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(44832011)(478600001)(6506007)(53546011)(6512007)(2616005)(6486002)(6666004)(2906002)(26005)(4744005)(66946007)(5660300002)(66556008)(41300700001)(316002)(66476007)(8676002)(4326008)(8936002)(38100700002)(36756003)(31696002)(86362001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkE5RlRqOGZXSXR4ckxCcFIvcHVldnBibUJYRTdrZXJSVTNvczZTVU5uWTZ0?= =?utf-8?B?T2p6aUZZditpS0ZyKytJRklLdnArOElQNXJ0akJ4NnNQc0hhQ0tTamRlNExh?= =?utf-8?B?YjJUVnF3bDhnNXpqZnZZV1ZLcTZyeVk3ZU1aWHlQL3d0czZYV29icnFmN01Z?= =?utf-8?B?bVBFMERWNWlab3NpcW5xS2ZTcXA1ekVKalcxcnE3aFZFQU8veVczRWR3M3Ra?= =?utf-8?B?MVN5NW5Qblo1Y1BnWlBDamFKa3BuZVVVdWM1TDlyUzVrWVhxYXFLWUtvdTNH?= =?utf-8?B?MlFWYWRRdnJXWlREMXV5QXJwOWI2YVlNdlpISC9IdXpCcGxRaE9uYzVKWjkr?= =?utf-8?B?RkVSRlBGeUtSdFJLbkVDM0hxK3ZJcmp1WlVhZWpTK3RyRWhBRnZXMVhUU09X?= =?utf-8?B?YzVTV24wcVIyUGxDWlpNV25nUkJXaDNlY3RVRnU1Z1ByM3NOenJWNVZiVG9I?= =?utf-8?B?Nit4M0JiaVQ4cVlLRnAwaVFXTkxmM1hEVU1VVVlISUFVWmNyWHc4M0xlaFRy?= =?utf-8?B?SFBwRHlsSENCSi8vYlNoL1dHbUhhS0tyYjdCSVFoSXZwa3RrcThUNFNiVjlL?= =?utf-8?B?bnQ3U3dtZExKWWI0K1ZlQUVONm96dlVURTBLZHdMbWF6L0xnOVR3VjNkcUFW?= =?utf-8?B?bEcvV1JGcHBWaWtwK1lIMmpwOW8zNDN0UGY3THlML1kyWGVtZGZLQVlkeDFi?= =?utf-8?B?RHJoeVJvV0lKRXNEdlJRN0Q1ZjBsSnI4QVhsRUdKVDFSK3I1aWQ5RnVsWE9m?= =?utf-8?B?S29qR1I5TmovSU52dTFzRGxjNys0WU53K3RUYWE5N0g0a3BQYkhLVnIyQlpW?= =?utf-8?B?c1hKaVhoRUlFdlY2eDFGNDk0UCs0RnpIRjUxTGc5MEJtU3NxRXlHSkdmaDVm?= =?utf-8?B?WlpXRzMyMXQ2RWtRbHBvSWhYVm03bkVraGQ4RGw2Ui90bytOVk1Cd1RlWkpB?= =?utf-8?B?bEd3eXVpT1V5WGYxSlFWU2VkRk5ad3Q4L2ZheFVYbCtDZmI4RVRPSGNPSFpv?= =?utf-8?B?cEJ2eFFxMU5FZnRCL2o4UXlPL2NRT3B2NUFlM1F0dWdMUGxvYkZzRzBiSlZl?= =?utf-8?B?WmdzR0xjQ0RJdDFocnAweFFVYnpGM0pGQW5ZaTc4aGw2RGFXM3VIZmxpRDl4?= =?utf-8?B?VmVXekNIbytSZ0VOZ2RDWTZhMDRSakVzYXVPWGZOWWF0Um85T2pvWW5hVDA4?= =?utf-8?B?NDNGVmV2UmQ3bFBxSHRVZW85WnNjVUxQaUFtQlVoc1p3WGdETDIyQWpDWkd5?= =?utf-8?B?cWVUYm5PcmI1Z3FaTW51cXIzdXN6Sy9IbTZrTk1KNmFvb1pvVzhsWncxbkZN?= =?utf-8?B?ZThiSTRtSW9RWXJHNTJkcUxxeFh3L0hScTYrd2k5TUR1emdUTkVCWnM5SHRT?= =?utf-8?B?MjVOOGlQVFV4MjRna29TekdmQzFDMEcvc0lVOHpYNzlhOGdWZHRzd2g2NCtp?= =?utf-8?B?Yi9mTmkwcURVa2tFSXhKTkJuakk1bTU1Y0lnRnhXc0tjVnFJTVozbU1ZemtT?= =?utf-8?B?S3ZkNmdXTW9NQlVZNm8vUGt6V3Y2aFB1UDlrQllBN1dxaThkaHNWSzdwV1Iw?= =?utf-8?B?eldZSnp6eTVkemJMb05yUVhCZ0toTGdPSW5FZndDUE1hcko1SjJ0U1BGTFFU?= =?utf-8?B?UG13OVhlTEp5dHdXeTczYm9PNGk3S0RTZUZORGZuRE4xRkhEbHVTSGkyS2p0?= =?utf-8?B?ZXA0MTZZcS9iWDhhb2lyK0hHZUJvemdpTFpPYkZmb3BIN25qb2lmL21TSXVN?= =?utf-8?B?ZUVsNi9TT0I5ckY3eDdDcUpOSVdaZVV6WVBQZHN2R2czS1k1c1J6dU5mUnlF?= =?utf-8?B?SHFlbERxWGp3UHpaUEFNeXlZUTdXaHJpNjBLanFTNjNncG5RV1dtS012WHZT?= =?utf-8?B?VFhlS2FMaUdCeDRuYXhIeHYzR1hacHNsMW56eEMwVjU2M25YZnFIRkJkOG9j?= =?utf-8?B?VEdxSDRjRG1uN2NDczgvSzJhd0thQmMxVmx6d1RVaG1kYy9jYVRvYzh4cDY5?= =?utf-8?B?UWpzcWYxTkkxVXNBd0xIYzN0NXZqRGV1ZUNka1k4QzYxbW4vZ3hHanlXVVVm?= =?utf-8?B?ZEluS1IyUDVmR2R4WU5rT09lSzJUNk5YSXZ0ZFJieGVnaVBFWHNYYXplcnNi?= =?utf-8?Q?mVlw=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f8a156b-eed5-4408-ab9c-08dbdebcdb43 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 11:38:12.0020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K2HSL7A8iGUKOuW/vFBfnUAF5Jm63PNp/SW5Wkoq6K4247xGnMGZUpTkTlZRRVSf X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8810 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/4/2023 7:37 AM, Weiguo Li wrote: > When ctx->sa is null, sfc_err(ctx->sa, ...) will triger a null > dereference in the macro of sfc_err. Use SFC_GENERIC_LOG(ERR, ...) > to avoid that. > > Fixes: 44db08d53be3 ("net/sfc: maintain controller to EFX interface mapping") > Cc: stable@dpdk.org > > Signed-off-by: Weiguo Li > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.