From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0543CA0350; Thu, 30 Apr 2020 19:38:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D25BC1DBD2; Thu, 30 Apr 2020 19:38:06 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 743B51DBCF for ; Thu, 30 Apr 2020 19:38:05 +0200 (CEST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03UHVmU2119593; Thu, 30 Apr 2020 13:38:04 -0400 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 30mhr9mjpn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Apr 2020 13:38:04 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 03UHUHk4019401; Thu, 30 Apr 2020 17:38:03 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma02dal.us.ibm.com with ESMTP id 30mcu7b0ja-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Apr 2020 17:38:03 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 03UHc1cw15270186 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Apr 2020 17:38:01 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A61E6A047; Thu, 30 Apr 2020 17:38:02 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D4B796A04F; Thu, 30 Apr 2020 17:38:01 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.83.155]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 30 Apr 2020 17:38:01 +0000 (GMT) To: "Burakov, Anatoly" , dev@dpdk.org References: <20200429232931.87233-1-drc@linux.vnet.ibm.com> <20200429232931.87233-2-drc@linux.vnet.ibm.com> <5c626659-7d00-c527-bb07-cdf29eaa5ce1@linux.vnet.ibm.com> <2e86c130-6c69-8525-b130-3d784a30b234@intel.com> From: David Christensen Message-ID: Date: Thu, 30 Apr 2020 10:38:01 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <2e86c130-6c69-8525-b130-3d784a30b234@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-30_11:2020-04-30, 2020-04-30 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 spamscore=0 mlxscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004300135 Subject: Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >>> Why is this needed? >> >> It's hardware specific to the PPC64 platform.  I don't know of a >> situation where the IOMMU would be present on other hardware.  Even >> running a VM in KVM/QEMU on a PPC64 platform results in a SPAPR V1 >> IOMMU which isn't supported in DPDK. >> >> Dave > > Yes, but generally #ifdef's are there for detecting compile-time > conditions. Is there anything specific to that code that would cause > trouble when compiled on other platforms? No, I can't say that's the case, it's been operating this way for a while. Dave