Re: [PATCH v6 12/17] net/r8169: implement Tx path

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 11/8/2024 12:11 PM, Howard Wang wrote:
> Add implementation for TX datapath.
> 
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
> ---
>  doc/guides/nics/features/r8169.ini |   6 +-
>  doc/guides/nics/r8169.rst          |   1 +
>  drivers/net/r8169/r8169_ethdev.c   |   6 +
>  drivers/net/r8169/r8169_ethdev.h   |  11 +
>  drivers/net/r8169/r8169_rxtx.c     | 682 ++++++++++++++++++++++++++++-
>  5 files changed, 686 insertions(+), 20 deletions(-)
> 
> diff --git a/doc/guides/nics/features/r8169.ini b/doc/guides/nics/features/r8169.ini
> index 1095b038d8..f36b912c53 100644
> --- a/doc/guides/nics/features/r8169.ini
> +++ b/doc/guides/nics/features/r8169.ini
> @@ -9,16 +9,14 @@ Link speed configuration = Y
>  Link status          = Y
>  Link status event    = Y
>  Scattered Rx         = Y
> +TSO                  = Y
>  Flow control         = Y
>  CRC offload          = Y
>  L3 checksum offload  = Y
>  L4 checksum offload  = Y
>  Packet type parsing  = Y
>  Rx descriptor status = Y
> -Basic stats          = Y
> -Extended stats       = Y
> -Stats per queue      = Y
> -FW version           = Y
> +Tx descriptor status = Y
>

Tx descriptor status requires 'tx_descriptor_status' dev ops which seems
not implemented in the driver.