DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andy Pei <andy.pei@intel.com>, dev@dpdk.org
Cc: rosen.xu@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/ipn3ke: implementation of statistics
Date: Tue, 18 Jun 2019 13:39:48 +0100	[thread overview]
Message-ID: <b82a4351-ca9a-db6d-d4ab-0e491976be7e@intel.com> (raw)
In-Reply-To: <693ef8bf-15c0-7fb2-9cea-4b730ed412d2@intel.com>

On 6/18/2019 12:59 PM, Ferruh Yigit wrote:
> On 6/11/2019 10:48 AM, Andy Pei wrote:
>> This patch implemente statistics read and reset
>> function for ipn3ke.
>>
>> Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor")
>> Cc: rosen.xu@intel.com
>>
>> Signed-off-by: Andy Pei <andy.pei@intel.com>
> 
> <...>
> 
>> +#define IPN3KE_RPST_TXQ_PRIO_XSTATS_CNT (sizeof(ipn3ke_rpst_txq_prio_strings) \
>> +		/ sizeof(ipn3ke_rpst_txq_prio_strings[0]))
>> +
>> +static uint32_t
>> +ipn3ke_rpst_xstats_calc_num(void)
>> +{
>> +	return IPN3KE_RPST_ETH_XSTATS_CNT
>> +		+ IPN3KE_RPST_HW_PORT_XSTATS_CNT
>> +		+ (IPN3KE_RPST_RXQ_PRIO_XSTATS_CNT
>> +			* IPN3KE_RPST_PRIO_XSTATS_CNT)
>> +		+ (IPN3KE_RPST_TXQ_PRIO_XSTATS_CNT
>> +			* IPN3KE_RPST_PRIO_XSTATS_CNT);
>> +}
>> +
>> +#if 0
> 
> Please don't add "#if 0" to the code, if required you can delete the code, same
> is valid for below one too.
> 

Also getting following build error in patch by patch build [1], please remind
that each individual patch should build successfully.


[1]
.../dpdk/drivers/net/ipn3ke/ipn3ke_ethdev.c: In function ‘ipn3ke_hw_init’:
.../dpdk/drivers/net/ipn3ke/ipn3ke_ethdev.c:248:4: error: implicit declaration
of function ‘ipn3ke_xmac_tx_clr_stcs’; did you mean
‘ipn3ke_xmac_tx_clr_25G_stcs’? [-Werror=implicit-function-declaration]
  248 |    ipn3ke_xmac_tx_clr_stcs(hw, i, 1);
      |    ^~~~~~~~~~~~~~~~~~~~~~~
      |    ipn3ke_xmac_tx_clr_25G_stcs

  reply	other threads:[~2019-06-18 12:39 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03  6:31 [dpdk-dev] [PATCH 1/2] net/ipn3ke: add new register address Andy Pei
2019-06-03  6:31 ` [dpdk-dev] [PATCH 2/2] net/ipn3ke: implementation of statistics Andy Pei
2019-06-11  9:48   ` [dpdk-dev] [PATCH v2 1/4] net/ipn3ke: add new register address Andy Pei
2019-06-11  9:48     ` [dpdk-dev] [PATCH v2 2/4] net/ipn3ke: delete MAC register address mask Andy Pei
2019-06-12  1:17       ` Xu, Rosen
2019-06-11  9:48     ` [dpdk-dev] [PATCH v2 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-06-12  1:17       ` Xu, Rosen
2019-06-19  8:49       ` [dpdk-dev] [PATCH v3 1/4] net/ipn3ke: add new register address Andy Pei
2019-06-19  8:49         ` [dpdk-dev] [PATCH v3 2/4] net/ipn3ke: delete MAC register address mask Andy Pei
2019-06-19  8:49         ` [dpdk-dev] [PATCH v3 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-06-19  8:49         ` [dpdk-dev] [PATCH v3 4/4] net/ipn3ke: implementation of statistics Andy Pei
2019-06-19  9:05           ` David Marchand
2019-06-25  7:09             ` Pei, Andy
2019-06-25  7:16               ` David Marchand
2019-06-25  8:53                 ` Pei, Andy
2019-06-25  8:58                   ` David Marchand
2019-06-27  6:02                     ` Pei, Andy
2019-06-25  7:50           ` [dpdk-dev] [PATCH v4 1/4] net/ipn3ke: add new register address Andy Pei
2019-06-25  7:50             ` [dpdk-dev] [PATCH v4 2/4] net/ipn3ke: delete MAC register address mask Andy Pei
2019-06-25  7:50             ` [dpdk-dev] [PATCH v4 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-06-25  7:50             ` [dpdk-dev] [PATCH v4] net/ipn3ke: implementation of statistics Andy Pei
2019-06-25  8:00           ` [dpdk-dev] [PATCH v4 1/4] net/ipn3ke: add new register address Andy Pei
2019-06-25  8:00             ` [dpdk-dev] [PATCH v4 2/4] net/ipn3ke: delete MAC register address mask Andy Pei
2019-06-25  8:00             ` [dpdk-dev] [PATCH v4 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-06-25  8:00             ` [dpdk-dev] [PATCH v4 4/4] net/ipn3ke: implementation of statistics Andy Pei
2019-06-27  5:49               ` Xu, Rosen
2019-06-28  8:54                 ` Pei, Andy
2019-07-01 10:36               ` [dpdk-dev] [PATCH v5 1/4] net/ipn3ke: add new register address Andy Pei
2019-07-01 10:36                 ` [dpdk-dev] [PATCH v5 2/4] net/ipn3ke: delete MAC register address mask Andy Pei
2019-07-02 10:00                   ` Xu, Rosen
2019-07-08  2:06                     ` Zhang, Qi Z
2019-07-01 10:36                 ` [dpdk-dev] [PATCH v5 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-07-02 10:00                   ` Xu, Rosen
2019-07-08  2:07                     ` Zhang, Qi Z
2019-07-01 10:36                 ` [dpdk-dev] [PATCH v5 4/4] net/ipn3ke: implementation of statistics Andy Pei
2019-07-02 10:01                   ` Xu, Rosen
2019-07-08  2:09                     ` Zhang, Qi Z
2019-07-02  9:59                 ` [dpdk-dev] [PATCH v5 1/4] net/ipn3ke: add new register address Xu, Rosen
2019-07-08  2:06                   ` Zhang, Qi Z
2019-07-08 16:00                 ` Ferruh Yigit
2019-07-09  1:33                   ` Pei, Andy
2019-06-11  9:48     ` [dpdk-dev] [PATCH v2 4/4] net/ipn3ke: implementation of statistics Andy Pei
2019-06-12  1:17       ` Xu, Rosen
2019-06-18 11:59       ` Ferruh Yigit
2019-06-18 12:39         ` Ferruh Yigit [this message]
2019-06-19  3:23           ` Pei, Andy
2019-06-12  1:17     ` [dpdk-dev] [PATCH v2 1/4] net/ipn3ke: add new register address Xu, Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b82a4351-ca9a-db6d-d4ab-0e491976be7e@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=andy.pei@intel.com \
    --cc=dev@dpdk.org \
    --cc=rosen.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).