From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
wenzhuo.lu@intel.com, konstantin.ananyev@intel.com,
beilei.xing@intel.com, qi.z.zhang@intel.com,
xiao.w.wang@intel.com, jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/6] net/ixgbe: use dynamic log type for tx/rx debug
Date: Tue, 27 Aug 2019 09:24:44 +0100 [thread overview]
Message-ID: <b84b2532-b146-217d-6e50-85c6a0bf349a@intel.com> (raw)
In-Reply-To: <20190716154013.6974-4-stephen@networkplumber.org>
On 7/16/2019 4:40 PM, Stephen Hemminger wrote:
> The generic RTE_LOGTYPE_PMD is a historical relic and should
> not be used. Every driver must dynamic log types.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
<...>
> @@ -161,16 +161,14 @@ ixgbe_add_tx_flow_control_drop_filter(struct rte_eth_dev *eth_dev)
> struct ixgbe_ethertype_filter ethertype_filter;
>
> if (!hw->mac.ops.set_ethertype_anti_spoofing) {
> - RTE_LOG(INFO, PMD, "ether type anti-spoofing is not"
> - " supported.\n");
> + PMD_DRV_LOG(INFO, "ether type anti-spoofing is not supported.\n");
> return;
> }
>
> i = ixgbe_ethertype_filter_lookup(filter_info,
> IXGBE_ETHERTYPE_FLOW_CTRL);
> if (i >= 0) {
> - RTE_LOG(ERR, PMD, "A ether type filter"
> - " entity for flow control already exists!\n");
> + PMD_DRV_LOG(ERR, "A ether type filter entity for flow control already exists!\n");
> return;
> }
>
This patch both adds dynamic log for Rx/Tx and converts log macro 'RTE_LOG' to
'PMD_DRV_LOG', can we separate these into two different patches?
next prev parent reply other threads:[~2019-08-27 8:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 15:40 [dpdk-dev] [PATCH 0/6] replace usage of LOGTYPE_PMD in Intel drivers Stephen Hemminger
2019-07-16 15:40 ` [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug Stephen Hemminger
2019-08-27 8:21 ` Ferruh Yigit
2019-09-30 15:28 ` Ye Xiaolong
2019-09-30 15:50 ` Stephen Hemminger
2019-09-30 15:56 ` Ferruh Yigit
2019-09-30 16:10 ` Ferruh Yigit
2019-07-16 15:40 ` [dpdk-dev] [PATCH 2/6] net/fm10k: " Stephen Hemminger
2019-07-16 15:40 ` [dpdk-dev] [PATCH 3/6] net/ixgbe: " Stephen Hemminger
2019-08-27 8:24 ` Ferruh Yigit [this message]
2019-07-16 15:40 ` [dpdk-dev] [PATCH 4/6] net/ice: " Stephen Hemminger
2019-07-16 15:40 ` [dpdk-dev] [PATCH 5/6] net/i40e: " Stephen Hemminger
2019-07-16 15:40 ` [dpdk-dev] [PATCH 6/6] net/iavf: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b84b2532-b146-217d-6e50-85c6a0bf349a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stephen@networkplumber.org \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).