From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
stable@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/nfp: fix set IPv6 flow action can't get right address
Date: Fri, 9 Jun 2023 16:31:22 +0100 [thread overview]
Message-ID: <b85a5701-5d0f-79e4-da0a-12756236a8f2@amd.com> (raw)
In-Reply-To: <1ff9a92d-692e-c9dd-698f-2dc04a0be72f@amd.com>
On 6/9/2023 2:43 PM, Ferruh Yigit wrote:
> On 6/9/2023 7:19 AM, Chaoyong He wrote:
>> The former logic of set IPv6 source/destination address flow action
>> can't get the right IPV6 address, a 32 bit big endian value is
>> expected while a 8 bit value is provided.
>> This caused the offloaded packets don't have the right IPv6 address
>> as expected.
>>
>> Fixes: 596ae2217214 ("net/nfp: support IPv6 source flow action")
>> Fixes: 51384f79b264 ("net/nfp: support IPv6 destination flow action")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
>> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
>>
>
> Applied to dpdk-next-net/main, thanks.
>
Thomas highlighted the compiler warning from CI [1], dropping patch from
next-net, updated patchwork status.
Can you please check the warning?
[1]
https://mails.dpdk.org/archives/test-report/2023-June/407776.html
```
../drivers/net/nfp/nfp_flow.c: In function 'nfp_flow_action_set_ipv6':
../drivers/net/nfp/nfp_flow.c:2168:3:
error:
dereferencing type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
set_ip->ipv6[i].exact = *(const rte_be32_t *)&set_ipv6->ipv6_addr[i * 4];
```
next prev parent reply other threads:[~2023-06-09 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 6:19 Chaoyong He
2023-06-09 13:43 ` Ferruh Yigit
2023-06-09 15:31 ` Ferruh Yigit [this message]
2023-06-12 2:24 ` [PATCH v2] " Chaoyong He
2023-06-12 9:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b85a5701-5d0f-79e4-da0a-12756236a8f2@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).