From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A657E42C6F; Fri, 9 Jun 2023 17:31:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9708B43012; Fri, 9 Jun 2023 17:31:32 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062.outbound.protection.outlook.com [40.107.92.62]) by mails.dpdk.org (Postfix) with ESMTP id 4B16A42FC4; Fri, 9 Jun 2023 17:31:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RvKBx3levGpQJKdTtuhSeLfWxwpgv/r5pLVZ0kGf6QvSO5TG2EKe1mVmvR/cjFg/0npCiz0c8OLaAVqq+7MQnyUe8rpzVx9q0J/YpjDANvayM7X09DRaxg0M4BJKiMpdWyEryfUZCRHBMP56gFQe50OcOgMVFlqAqxD86tZo3XKqbMFvcnTSdK4o++eD5ghdO2IyHe9IflmHG7Zcrv4PSrl6Ib8HWeGlzt/ysGy9ILdAmvaZ73YGoqZc+Z1nYRK2z7oybv04tQvO6K4mnFAT5Jl6AY/3cn1X1gycAdQAH9b6o2H6r/C29sBTf1+sfBr8oe+1k0ct459FgR8I892O8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A+/tbabgb7CmqySggJ7cqAW2C36O0OHTz8eAJCDwf8M=; b=iGgz+82AKp2ee3KNECj2lzH4WNCMshPSdRL2eEcUmXF+Wc/aJDzB0O0HQVfIRhH+5JhortvBq/jxJD8RahZmQUz5F027rXjBThCjMdR8aj0OQ7fWVMD8xTYCpMC0QdYg0YV4lHxCAV6U0dk0B4yMYezQZwSWj2ZICU1bUUwKXsvGapkLj4hgEi7s8BO+OlbNiULuN86KfpRxFxY80HE9fkjbSyfH5gj3WDuN6bVLJQXGwj/kjzOZYC5uSa3M6Aj/8+HLG/xEoHFf4sLSq07/ta6QvfnwvY4d30YehxLCRayEDyTGWOTm1lU8I05yHAYn5j6ENtqLf9eHlUME5lwFFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+/tbabgb7CmqySggJ7cqAW2C36O0OHTz8eAJCDwf8M=; b=zEN1N6TNdOOZQ+zsoC01dQtij15qIaNcWE9sHCLQxsb9xDmIjd/8qq6dKZ1QrEYN+8a4Cyh4J/CD/zIHYRBYb9MuWge+FWQSaLBNvrSpkovmwUinr5ZAZShmflTkHnuB9ZIdh8wp5OQ+Y+mTk5Rr6LQJPO9NhrF1Xp5fjTc+12g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB7873.namprd12.prod.outlook.com (2603:10b6:8:142::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Fri, 9 Jun 2023 15:31:29 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Fri, 9 Jun 2023 15:31:29 +0000 Message-ID: Date: Fri, 9 Jun 2023 16:31:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] net/nfp: fix set IPv6 flow action can't get right address Content-Language: en-US From: Ferruh Yigit To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, stable@dpdk.org, Thomas Monjalon References: <20230609061919.1307911-1-chaoyong.he@corigine.com> <1ff9a92d-692e-c9dd-698f-2dc04a0be72f@amd.com> In-Reply-To: <1ff9a92d-692e-c9dd-698f-2dc04a0be72f@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB7873:EE_ X-MS-Office365-Filtering-Correlation-Id: 590b8dc1-48b3-49dd-bc8b-08db68fe9821 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eCt5cBPVFApKYYZF+ZTh5T6I9JfHb/jgxmfQ0If9raVuZKTp6Q+xKh6NZoEJ3cUaDMj+epyVvWRzpsD9tUs/m1wQUmGqqjAYCmV37hKw4gL0FKIK5BZ6VCRFVTGN4k06sQjAhIIhbfe6+JXPcnHIdQiPjmZ+kqasZzy3gPVlZX1GhhvKaRghw5SxA3Rw/7HanHReBf5EDFlPlLuAk/DrX2IpDqAlxnPm7wWz7ZQp2QHSmZ8sREhqvqozvo9l+zTZeUj5JY4/FwyCHqz5ua4pAEw3pR3pej8CxTD0FL08AvRLecx4MRLWHML8CTUjDtXqKnOUn+tXhI0uzOq46b3sFN5x6R3YQl7luWmsG+F3JdNtD0xrS5xcFChRaClKWw3iGdtHzlJ4VUY5yx/DZ53FDPJaTPh9H7048qeSqzo7ygu2Lhn65VPNH6NZ8fEgnpWAWpx6iKAtphMjEfLq441+iIHmsEaU6csx5xK5OVxa/IVgHWP3r31IjEhCsaTJUCT8NQCXK/fiir5m/mP1m4O1wk6jkSuelgDbaoejM18aJpWnTQ1CK5lM7QJGNcgX5YLlGBvGKKgwV7RAN67UYCKcpMlCcX6KqiGf+fUUfLu0MYjIsJUpAoZsWplDjGG0+4OH3s+C1MyeodSIQ5pT0jIXXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199021)(66946007)(31686004)(2906002)(66556008)(66476007)(4326008)(186003)(38100700002)(36756003)(316002)(5660300002)(478600001)(86362001)(8676002)(6666004)(8936002)(966005)(31696002)(44832011)(41300700001)(6486002)(6512007)(53546011)(2616005)(83380400001)(6506007)(26005)(66574015)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bU1GRG51bzN0REdPUi9HRTVpRFpBSkx5dCtDbkNaQlFlM1F4b3RMQkkrcmNk?= =?utf-8?B?NDMzOWt3Q2N2Z3REcjNhaTJwdE5HWXJlM1JKZUtWV2owSVJFRmdaMzNEUkFV?= =?utf-8?B?WXdWemNrSUtMMkptN3V0T2dIN1IrY1BGcW0weXE1VThrQnBiZmphVGVpdnh0?= =?utf-8?B?WGdvckRmVi9jWTBERjR4TERCZVFERkpkQ3lEMlJEVitWN3YvQm1Tc2pLbjVC?= =?utf-8?B?bDRaS1IxTS9DSmNtUGpSL3UzaEp4dHVTM1NwSVFFbEhsQUpsNGs0bnJ5SmZF?= =?utf-8?B?VC9DODZkQlo2dGQ1b2NpSitPK2ZxMjk0OHYxZ0M4WnU0VXBOc1I1bDV1LzJE?= =?utf-8?B?Wjd1QVBjQm9IQklWdU54SG9YZjFob2s4aDZLQThSQkhVcFJGSllJQit4YVpw?= =?utf-8?B?My85SUo5VmkxakNscm1ZTitsRzhpbFJEbnczaFU2RzlTV0pOMllkYTc1WWMw?= =?utf-8?B?d1dNOWRUR3VXZmtpWENtM0w0TVFPdzQ3SGk3Uk1nY21ScWprQXBKSVFSRDNE?= =?utf-8?B?Q0J5MzlJWkdpUWpoZXl6c2pUTStjWVRKb0hlWDlDTWVlVGhmQnY4VTZUY3BZ?= =?utf-8?B?QlNSU3N3ZkNyeDFKdTZEaWRLSXM0K1dheGdGZXUrWEUrcUFMQzZtNVJ1R1J2?= =?utf-8?B?ZUpHcUFDMFFjRGJFZnZXNVJDQ2oraG9MS3pLRzhHVWJsSXhXeTVyVXIzWktN?= =?utf-8?B?eUtObjMvZURSWmp4ZWxwWjlZS2s4S1gyY2FoQjZIQnZIZ0dTSFBzUE5WREpF?= =?utf-8?B?QUdNcnhCcXp5NlphdHRDUnhJQVd1ZjJGSkF2WGx4aVJUczlGTW1wZTA3S2hr?= =?utf-8?B?N3FON0NLdWJzSjNHZ3cveTVKK2kvWjJncjhEdDU3cmg2ajFFa3VJbnFhWEZy?= =?utf-8?B?SjIvSjYwZThRelNaQzRrN2VOWFd4VHkxaE1mNG9sRnFnOG9TcFRFVDIvbTdS?= =?utf-8?B?MXUyUjBaR2x5RlZXcVFYekx1dU14RHRMbkNpMXJsNnRQbmtVQU81SkRaRytR?= =?utf-8?B?aStheWJ2SmZhcUJhZHRMMjYzMXB0SVFicGZYUHpIVWhQOUZhME0xclQzVGIw?= =?utf-8?B?SFNabmVhNGlIUkJoeDRvcmZJamViZWhBVUQvOCsvcHQxSk1wK0ZobGtMU3l0?= =?utf-8?B?cGl4ZXBHZ3ZWTWhzd1NVcHljbnNwWmZXUGNmY2lxbDdrZ1hHWHFvKzRUeklz?= =?utf-8?B?dGxyZkFTd3dteG5sdUY1S1dZL0VkT1pIZUpLM3FzTlhuUElnSVozN2twb3lP?= =?utf-8?B?b0hONEVkNkQ4aFRSczVMdVZvbHlOVHNUOVM1VjZSQ3U3VWdJNGZaTE56L0Rx?= =?utf-8?B?Q3d2dmtMQi84bzZVZC9wOXIwZDI5TGVYdWlMbzFteUtFVSsvalVQaXowZE5O?= =?utf-8?B?N0s1VzJDekFGdEhJS1l2VzhGQ1cwd2tBMmlWcGlLKzNqQ1BMWVQ5MEkyWEln?= =?utf-8?B?d0kzTUh3YTdaRjFGcG5yN0RQR1BFVHBBOThNelZPcm5yblhzRlU3SE1mVVRG?= =?utf-8?B?TE0vTmI1Y0hJWVMvY0xqdlRzSG1VUXBDQWdUalN0aVF5NmFFUTN3S1RsR0Vn?= =?utf-8?B?WFU0RGFERkMwRTNGODArUzRYUVFDYzA1aFBheUtpVHdyL3dmSFNFQnEvSXJD?= =?utf-8?B?VGJZU0xuc2hjbmd3Snd1R2dVVUY0V3BKeXp6OWNHZDYvNGFyWFFQd0I0NlVx?= =?utf-8?B?LzQ4Q3ZicmxSdmdNTjNQTjFYN01Gd2I3ODZ5c2dDUjE3bm9yNXZ6ZmZLbXhs?= =?utf-8?B?NTVyUjFLTVNSVFhpTkZXQi9zaEg4NDRZU2s5Slk2T1VyVUdpdVduQUtUNzF5?= =?utf-8?B?YU4yYW5BN1NHcnpTVVJVMDVBUFlvOXlHS3VQZEVOWk1MdTBnWUg1TFRrY1VK?= =?utf-8?B?ZGhQQTA5R0lHS1dvUlhpMm5KNFpZU25aaTk0TXR6aG1qVlJ5UVluRnJZRWxQ?= =?utf-8?B?Q0RUTSsvY2ZlWUlPazdMamtaVk5rWVhGbGNyenVsRUdKRzlBaGxqeUl1K2hD?= =?utf-8?B?SFI2L1hOWDFjSVdNcEJpRHF3Vm9MRFl6UWtBOUxhcEE1T1huNE55YUR0QkVk?= =?utf-8?B?TU92Z3ZJMUtWL1NOQm1WR1p5TnpWQ0pxTTBhMi82S0JwMGFUUEJTektjelFT?= =?utf-8?Q?RKfqSoaJhmAofS08vhAY2q25l?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 590b8dc1-48b3-49dd-bc8b-08db68fe9821 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 15:31:28.8504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 65EbS+ew/nCF7P4iTL7cxsYgMTgmHtgVoJjph4pV74YXUE2vFogBkmRWBy3e/gAa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7873 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/9/2023 2:43 PM, Ferruh Yigit wrote: > On 6/9/2023 7:19 AM, Chaoyong He wrote: >> The former logic of set IPv6 source/destination address flow action >> can't get the right IPV6 address, a 32 bit big endian value is >> expected while a 8 bit value is provided. >> This caused the offloaded packets don't have the right IPv6 address >> as expected. >> >> Fixes: 596ae2217214 ("net/nfp: support IPv6 source flow action") >> Fixes: 51384f79b264 ("net/nfp: support IPv6 destination flow action") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chaoyong He >> Reviewed-by: Niklas Söderlund >> > > Applied to dpdk-next-net/main, thanks. > Thomas highlighted the compiler warning from CI [1], dropping patch from next-net, updated patchwork status. Can you please check the warning? [1] https://mails.dpdk.org/archives/test-report/2023-June/407776.html ``` ../drivers/net/nfp/nfp_flow.c: In function 'nfp_flow_action_set_ipv6': ../drivers/net/nfp/nfp_flow.c:2168:3: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] set_ip->ipv6[i].exact = *(const rte_be32_t *)&set_ipv6->ipv6_addr[i * 4]; ```