From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1322F41BB9;
	Fri,  3 Feb 2023 08:20:44 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 913254067B;
	Fri,  3 Feb 2023 08:20:43 +0100 (CET)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by mails.dpdk.org (Postfix) with ESMTP id 7F0EF4014F
 for <dev@dpdk.org>; Fri,  3 Feb 2023 08:20:41 +0100 (CET)
Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.57])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4P7RlX1BjNz12LRQ;
 Fri,  3 Feb 2023 15:16:08 +0800 (CST)
Received: from [10.67.103.42] (10.67.103.42) by kwepemi500020.china.huawei.com
 (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 3 Feb
 2023 15:20:39 +0800
Message-ID: <b8692871-530a-47c5-f5dc-634744d5c4c0@huawei.com>
Date: Fri, 3 Feb 2023 15:20:38 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v3 1/2] ring: add ring list telemetry cmd
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 "konstantin.v.ananyev@yandex.ru" <konstantin.v.ananyev@yandex.ru>,
 "dev@dpdk.org" <dev@dpdk.org>
CC: "liudongdong3@huawei.com" <liudongdong3@huawei.com>, nd <nd@arm.com>,
 haijie <haijie1@huawei.com>
References: <20230117130333.8707-1-haijie1@huawei.com>
 <20230131022841.10775-1-haijie1@huawei.com>
 <20230131022841.10775-2-haijie1@huawei.com>
 <DBAPR08MB58147BC7C5F9BCA749E25E9398D09@DBAPR08MB5814.eurprd08.prod.outlook.com>
From: Jie Hai <haijie1@huawei.com>
In-Reply-To: <DBAPR08MB58147BC7C5F9BCA749E25E9398D09@DBAPR08MB5814.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.103.42]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 kwepemi500020.china.huawei.com (7.221.188.8)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2023/2/1 0:44, Honnappa Nagarahalli wrote:
> Few minor comments inline. Otherwise,
> 
> Reviewed-by: Honnappa Nagarahalli <Honnappa.nagarahalli@arm.com>
> 
Thanks for your review.
>> -----Original Message-----
>> From: Jie Hai <haijie1@huawei.com>
>> Sent: Monday, January 30, 2023 8:29 PM
>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>;
>> konstantin.v.ananyev@yandex.ru; dev@dpdk.org
>> Cc: liudongdong3@huawei.com; haijie1@huawei.com
>> Subject: [PATCH v3 1/2] ring: add ring list telemetry cmd
> How about "ring: add telemetry cmd to list rings"
> 
>>
>> This patch supports the list of rings with telemetry cmd.
> Add a telemetry command to list the rings used in the system.
> 
That sounds easier to understand. Accepted and will change it in v4.
>> An example using this command is shown below:
>>
>> --> /ring/list
>> {
>>    "/ring/list": [
>>      "HT_0000:7d:00.2",
>>      "MP_mb_pool_0"
>>    ]
>> }
>> +RTE_INIT(ring_init_telemetry)
>> +{
>> +	rte_telemetry_register_cmd("/ring/list", ring_handle_list,
>> +		"Returns list of available ring. Takes no parameters"); }
>                                                                           ^^^^ rings
Thank you very much for your comments. I will change it to "Returns list 
of available rings" in v4.
>> --
>> 2.33.0
> 
> .