From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 36A492C12 for ; Thu, 29 Mar 2018 17:03:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 08:03:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="215993861" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.255.24.20]) ([10.255.24.20]) by fmsmga005.fm.intel.com with ESMTP; 29 Mar 2018 08:03:04 -0700 To: "Van Haaren, Harry" , "Tan, Jianfeng" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "gaetan.rivet@6wind.com" , "Wu, Jingjing" , "thomas@monjalon.net" , "motih@mellanox.com" References: <1521610066-12966-3-git-send-email-jia.guo@intel.com> <1522063256-3997-1-git-send-email-jia.guo@intel.com> <1522063256-3997-4-git-send-email-jia.guo@intel.com> Cc: "jblunck@infradead.org" , "shreyansh.jain@nxp.com" , "dev@dpdk.org" , "Zhang, Helin" From: "Guo, Jia" Message-ID: Date: Thu, 29 Mar 2018 23:03:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH V16 3/4] eal/linux: uevent parse and process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 15:03:09 -0000 hi, harry thanks for your review. On 3/29/2018 9:32 PM, Van Haaren, Harry wrote: > Two additional input along with Jianfeng's existing comments; > >> -----Original Message----- >> From: Tan, Jianfeng >> Sent: Wednesday, March 28, 2018 5:16 PM >> To: Guo, Jia ; stephen@networkplumber.org; Richardson, >> Bruce ; Yigit, Ferruh ; >> Ananyev, Konstantin ; gaetan.rivet@6wind.com; >> Wu, Jingjing ; thomas@monjalon.net; >> motih@mellanox.com; Van Haaren, Harry >> Cc: jblunck@infradead.org; shreyansh.jain@nxp.com; dev@dpdk.org; Zhang, >> Helin >> Subject: Re: [PATCH V16 3/4] eal/linux: uevent parse and process >> >> BTW, adding new .c file needs to update meson.build now. >> >> On 3/26/2018 7:20 PM, Jeff Guo wrote: >>> In order to handle the uevent which have been detected from the kernel >>> side, add uevent parse and process function to translate the uevent into >>> device event, which user has subscribe to monitor. >>> >>> Signed-off-by: Jeff Guo >>> --- >>> 1.move all linux specific together >>> --- >>> lib/librte_eal/linuxapp/eal/eal_dev.c | 214 >> +++++++++++++++++++++++++++++++++- >>> 1 file changed, 211 insertions(+), 3 deletions(-) >>> >>> diff --git a/lib/librte_eal/linuxapp/eal/eal_dev.c >> b/lib/librte_eal/linuxapp/eal/eal_dev.c >> >>> +static bool monitor_not_started = true; > This variable should be named "monitor_started", as it is a static var it will be zero by default, > and the following code is easier to read: > > if ( !not_started ) becomes if (started) > make sense. > >>> int __rte_experimental >>> rte_dev_event_monitor_start(void) >>> { >>> - /* TODO: start uevent monitor for linux */ >>> + int ret; >>> + >>> + if (!monitor_not_started) >>> + return 0; >>> + >>> + intr_handle.fd = dev_uev_monitor_fd_new(); >>> + intr_handle.type = RTE_INTR_HANDLE_DEV_EVENT; > dev_uev_monitor_fd_new() can return -1 on error, we should check for that case here. > you are right.