From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E81345BD9; Sat, 26 Oct 2024 05:12:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A8CC4026C; Sat, 26 Oct 2024 05:12:21 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id C1E6B40265 for ; Sat, 26 Oct 2024 05:12:19 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Xb4QX3b4Gz10Nf4; Sat, 26 Oct 2024 11:10:12 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id E94F51800E4; Sat, 26 Oct 2024 11:12:17 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Sat, 26 Oct 2024 11:12:15 +0800 Message-ID: Date: Sat, 26 Oct 2024 11:12:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v9 2/6] power: refactor uncore power management library To: Sivaprasad Tummala CC: , , , , , , , , References: <20241022184133.700367-1-sivaprasad.tummala@amd.com> <20241023051139.1066426-1-sivaprasad.tummala@amd.com> <20241023051139.1066426-3-sivaprasad.tummala@amd.com> From: "lihuisong (C)" In-Reply-To: <20241023051139.1066426-3-sivaprasad.tummala@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600004.china.huawei.com (7.193.23.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Already reviewed before. Acked-by: Huisong Li 在 2024/10/23 13:11, Sivaprasad Tummala 写道: > This patch refactors the power management library, addressing uncore > power management. The primary changes involve the creation of dedicated > directories for each driver within 'drivers/power/uncore/*'. The > adjustment of meson.build files enables the selective activation > of individual drivers. > > This refactor significantly improves code organization, enhances > clarity and boosts maintainability. It lays the foundation for more > focused development on individual drivers and facilitates seamless > integration of future enhancements, particularly the AMD uncore driver. > > v9: > - documentation update > > v8: > - removed c++ guards for internal header files > - renamed rte_power_uncore_ops.h for naming convention > > v7: > - fixed build error with aarch32 gcc cross compilation > > v6: > - fixed compilation error with symbol export in API > > v5: > - fixed build errors for risc-v/ppc targets > > v4: > - fixed build error with RTE_ASSERT > > Signed-off-by: Sivaprasad Tummala > --- > doc/guides/prog_guide/power_man.rst | 10 +- > .../power/intel_uncore/intel_uncore.c | 18 +- > .../power/intel_uncore/intel_uncore.h | 9 +- > drivers/power/intel_uncore/meson.build | 6 + > drivers/power/meson.build | 3 +- > lib/power/meson.build | 2 +- > lib/power/power_uncore_ops.h | 244 +++++++++++++++++ > lib/power/rte_power_uncore.c | 256 +++++++++--------- > lib/power/rte_power_uncore.h | 61 ++--- > lib/power/version.map | 1 + > 10 files changed, 440 insertions(+), 170 deletions(-) > rename lib/power/power_intel_uncore.c => drivers/power/intel_uncore/intel_uncore.c (95%) > rename lib/power/power_intel_uncore.h => drivers/power/intel_uncore/intel_uncore.h (97%) > create mode 100644 drivers/power/intel_uncore/meson.build > create mode 100644 lib/power/power_uncore_ops.h