From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F13B9A04B7; Mon, 11 Nov 2019 11:44:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8FCDDE3; Mon, 11 Nov 2019 11:44:14 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 456FFCF3 for ; Mon, 11 Nov 2019 11:44:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 02:44:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,292,1569308400"; d="scan'208";a="354739644" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by orsmga004.jf.intel.com with ESMTP; 11 Nov 2019 02:44:08 -0800 To: Jerin Jacob , Pavan Nikhilesh Bhagavatula Cc: "Ananyev, Konstantin" , Andrew Rybchenko , Jerin Jacob Kollanukkaran , "thomas@monjalon.net" , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "Mcnamara, John" , "Kovacevic, Marko" , "dev@dpdk.org" References: <20191029153722.4547-1-pbhagavatula@marvell.com> <20191106191803.15098-1-pbhagavatula@marvell.com> <20191106191803.15098-9-pbhagavatula@marvell.com> <2601191342CEEE43887BDE71AB97725801A8C83195@IRSMSX104.ger.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Mon, 11 Nov 2019 10:44:06 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/11/2019 5:02 AM, Jerin Jacob wrote: > On Mon, Nov 11, 2019 at 10:26 AM Pavan Nikhilesh Bhagavatula > wrote: >> >>> On Fri, Nov 8, 2019 at 7:24 PM Ananyev, Konstantin >>> wrote: >>>> >>>> >>>> >>>>> -----Original Message----- >>>>> From: dev On Behalf Of Ferruh Yigit >>>>> Sent: Thursday, November 7, 2019 7:41 PM >>>>> To: Jerin Jacob >>>>> Cc: Pavan Nikhilesh ; Andrew >>> Rybchenko ; jerinj@marvell.com; >>>>> thomas@monjalon.net; Lu, Wenzhuo ; >>> Wu, Jingjing ; Iremonger, Bernard >>>>> ; Mcnamara, John >>> ; Kovacevic, Marko >>> ; >>>>> dev@dpdk.org >>>>> Subject: Re: [dpdk-dev] [PATCH v16 8/8] app/testpmd: add >>> command to set supported ptype mask >>>>> >>>>> On 11/7/2019 6:55 PM, Jerin Jacob wrote: >>>>>> >>>>>> >>>>>> On Fri, 8 Nov, 2019, 12:10 am Ferruh Yigit, >>>>> > wrote: >>>>>> >>>>>> On 11/6/2019 7:18 PM, pbhagavatula@marvell.com >>>>>> wrote: >>>>>> > From: Pavan Nikhilesh >>>>> > >>>>>> > >>>>>> > Add command to set supported ptype mask. >>>>>> > Usage: >>>>>> > set port ptype_mask > /* *************** >>>>>> > >>>>>> > /* list of instructions */ >>>>>> > @@ -19155,6 +19237,7 @@ cmdline_parse_ctx_t main_ctx[] = >>> { >>>>>> > (cmdline_parse_inst_t *)&cmd_show_vf_stats, >>>>>> > (cmdline_parse_inst_t *)&cmd_clear_vf_stats, >>>>>> > (cmdline_parse_inst_t >>> *)&cmd_show_port_supported_ptypes, >>>>>> > + (cmdline_parse_inst_t *)&cmd_set_port_ptypes, >>>>>> > (cmdline_parse_inst_t *)&cmd_ptype_mapping_get, >>>>>> > (cmdline_parse_inst_t *)&cmd_ptype_mapping_replace, >>>>>> > (cmdline_parse_inst_t *)&cmd_ptype_mapping_reset, >>>>>> > diff --git a/app/test-pmd/testpmd.c b/app/test- >>> pmd/testpmd.c >>>>>> > index 5ba974162..812aebf35 100644 >>>>>> > --- a/app/test-pmd/testpmd.c >>>>>> > +++ b/app/test-pmd/testpmd.c >>>>>> > @@ -2024,6 +2024,7 @@ start_port(portid_t pid) >>>>>> > queueid_t qi; >>>>>> > struct rte_port *port; >>>>>> > struct rte_ether_addr mac_addr; >>>>>> > + static uint8_t clr_ptypes = 1; >>>>>> > >>>>>> > if (port_id_is_invalid(pid, ENABLED_WARN)) >>>>>> > return 0; >>>>>> > @@ -2153,6 +2154,10 @@ start_port(portid_t pid) >>>>>> > } >>>>>> > } >>>>>> > configure_rxtx_dump_callbacks(verbose_level); >>>>>> > + if (clr_ptypes) { >>>>>> > + clr_ptypes = 0; >>>>>> > + rte_eth_dev_set_ptypes(pi, >>> RTE_PTYPE_UNKNOWN, NULL, 0); >>>>>> > + } >>>>>> >>>>>> I am not sure about this command, we have now capability to >>> set/disable ptypes >>>>>> on demand, why disabling them by default? >>>>>> >>>>>> >>>>>> As forward engines are not using the ptype offload. If a specific >>> forwa >>>>>> need the offload, it can be enabled. >>>> >>>> Well, at least now user can see ptype in pkt dump with 'set verbose > >>> 0' >>>> It's definitely looks loke a a behavior change. >>>> Wonder why it can't be done visa-versa? >>>> Keep current behavior as default one (all ptypes are un-masked) and >>>> have special command to disable/enable ptypes. >>>> as I understand such command was added by these series. correct? >>> >>> IMO, we are following the principle that by default all offloads are >>> disabled and enable it >>> based on the need to have optimal performance across the DPDK. This >>> change will be >>> on the same theme. >>> >>> Regarding the verbose > 0 cases, I think, we can call >>> rte_eth_dev_set_ptypes() to all PTYPES on >>> the setting verbose callback. >> >> Agree verbose > 0 case we can do set_ptypes with >> RTE_PTYPE_ALL_MASK. But what if the user wants to verify >> rte_eth_dev_set_ptypes() call itself in verbose mode?. >> Example: >> >> set port 0 ptype_mask RTE_PTYPE_L3_MASK >> set verbose 1 >> >> In this case user expects to see only L3 mask set. Wouldn’t it be confusing if >> we set RTE_PTYPE_ALL_MASK under the hood when verbose level is increased? > > I thought of adding RTE_PTYPE_ALL_MASK in the callback to maintain the > existing behavior > if there is any concern in that area. > > Either way is fine with me. (implicit RTE_PTYPE_ALL_MASK in a > callback or explicit mask set in command line) > I think explicit set in command line is better, setting in the callback can be confusing.