From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>
Subject: Re: [PATCH 2/2] net/hns3: optimized Tx performance
Date: Mon, 15 Nov 2021 17:32:18 +0000 [thread overview]
Message-ID: <b8df92a6-859c-a027-1eb6-00644ac8ad4a@intel.com> (raw)
In-Reply-To: <20211111133859.13705-3-humin29@huawei.com>
On 11/11/2021 1:38 PM, Min Hu (Connor) wrote:
> From: Chengwen Feng<fengchengwen@huawei.com>
>
> The PMD should check whether the descriptor is done by hardware before
> free the corresponding mbuf. Currently the common xmit algorithm will
> free mbuf every time when it's invoked. Because hardware may not have
> finished sending, this may lead to many invalid queries which are
> whether the descriptors are done.
>
Hi Connor, Chengwen,
Since there will be a new version, can you please reword above paragraph?
> This patch uses tx_free_thresh to control whether invoke free mbuf, and
> free tx_rs_thresh mbufs each time.
>
> This patch also modifies the implementation of PMD's tx_done_cleanup
> because the mbuf free algorithm changed.
>
> In the testpmd single core MAC forwarding scenario, the performance is
> improved by 10% at 64B on Kunpeng920 platform.
>
> Cc:stable@dpdk.org
>
> Signed-off-by: Chengwen Feng<fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor)<humin29@huawei.com>
next prev parent reply other threads:[~2021-11-15 17:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 13:38 [PATCH 0/2] performance optimized for hns3 PMD Min Hu (Connor)
2021-11-11 13:38 ` [PATCH 1/2] net/hns3: optimized Tx performance by mbuf fast free Min Hu (Connor)
2021-11-15 17:30 ` Ferruh Yigit
2021-11-16 1:24 ` Min Hu (Connor)
2021-11-11 13:38 ` [PATCH 2/2] net/hns3: optimized Tx performance Min Hu (Connor)
2021-11-15 17:32 ` Ferruh Yigit [this message]
2021-11-16 1:22 ` [PATCH v2 0/2] performance optimized for hns3 PMD Min Hu (Connor)
2021-11-16 1:22 ` [PATCH v2 1/2] net/hns3: optimized Tx performance by mbuf fast free Min Hu (Connor)
2021-11-16 1:22 ` [PATCH v2 2/2] net/hns3: optimized Tx performance Min Hu (Connor)
2021-11-16 14:36 ` [PATCH v2 0/2] performance optimized for hns3 PMD Ferruh Yigit
2021-11-16 15:04 ` Fengchengwen
2021-11-16 15:12 ` humin (Q)
2021-11-16 15:38 ` Ferruh Yigit
2021-11-16 15:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8df92a6-859c-a027-1eb6-00644ac8ad4a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).