From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id B96651B2D0
for <dev@dpdk.org>; Thu, 21 Dec 2017 19:02:16 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
21 Dec 2017 10:02:15 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,437,1508828400"; d="scan'208";a="13684847"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.153])
([10.241.224.153])
by FMSMGA003.fm.intel.com with ESMTP; 21 Dec 2017 10:02:15 -0800
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
References: <20171219063840.18981-1-stephen@networkplumber.org>
<20171219063840.18981-2-stephen@networkplumber.org>
<6170a4ed-87ff-c750-f3f3-a38e192e6698@intel.com>
<20171220105804.5ac92c42@xeon-e3>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <b8f7c945-5290-35f1-7006-b16072182552@intel.com>
Date: Thu, 21 Dec 2017 10:02:14 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171220105804.5ac92c42@xeon-e3>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 01/11] avp: implement dynamic logging
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Dec 2017 18:02:17 -0000
On 12/20/2017 10:58 AM, Stephen Hemminger wrote:
> On Tue, 19 Dec 2017 17:53:50 -0800
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> On 12/18/2017 10:38 PM, Stephen Hemminger wrote:
>>> All PMD should be using dynamic log levels.
>>>
>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
<...>
>>> @@ -2312,3 +2313,12 @@ avp_dev_stats_reset(struct rte_eth_dev *eth_dev)
>>>
>>> RTE_PMD_REGISTER_PCI(net_avp, rte_avp_pmd);
>>> RTE_PMD_REGISTER_PCI_TABLE(net_avp, pci_id_avp_map);
>>> +
>>> +RTE_INIT(avp_init_log);
>>> +static void
>>> +avp_init_log(void)
>>> +{
>>> + avp_logtype_driver = rte_log_register("pmd.avp.driver");
>>> + if (avp_logtype_driver >= 0)
>>> + rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE);
>>> +}
>>
>> This can be done later as well but what do you think creating a macro [1], so
>> that driver part can become just:
>>
>> PMD_INIT_LOG(avp, init, NOTICE);
>>
>>
>>
>> [1] something like:
>> #define INIT_LOG_VAR_NAME(pmd, type) logtype_ ## pmd ## _ ## type
>> #define INIT_LOG_FUNC_NAME(pmd, type) log_ ## pmd ## _ ## type
>>
>> #define PMD_INIT_LOG(pmd, type, level) \
>> int INIT_LOG_VAR_NAME(pmd, type); \
>> RTE_INIT(INIT_LOG_FUNC_NAME(pmd, type)); \
>> static void INIT_LOG_FUNC_NAME(pmd, type)(void) \
>> { \
>> INIT_LOG_VAR_NAME(pmd, type) = rte_log_register("pmd."
>> RTE_STR(pmd) "." RTE_STR(type)); \
>> if (INIT_LOG_VAR_NAME(pmd, type) > 0) \
>> rte_log_set_level(INIT_LOG_VAR_NAME(pmd, type),
>> RTE_LOG_##level); \
>> }
>
> That macro is a little complex. Also, for better or worse, the current
> logging is done on a per driver basis. If we want to do something fancier
> it should be in common EAL core.
Of course, my intention was putting it into rte_log.h so updates in each driver
will be minimal. But this can be done better to cover library updates as well.