From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3896542A09; Wed, 26 Apr 2023 18:54:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2267410FA; Wed, 26 Apr 2023 18:54:26 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2059.outbound.protection.outlook.com [40.107.100.59]) by mails.dpdk.org (Postfix) with ESMTP id 5FF9C4068E for ; Wed, 26 Apr 2023 18:54:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Onjq84+fI8FVTehfDSbTebVeOAtAKsTrYKohM7GB1TJxHOhbchdM7BQNoVuZjzKK9GvhFn7xUJ+HVNy5r5e04FucxygVJkbH0NHUAGOYNbYROnIRXdbISmblF8RCIxSBKAotQL7SDBc2HhFfykBXZIiCmbynT7KIsTlnYbzhEyGTtJxVFxSm4e76RIbixe4jiVV02fJDAsGeHDx8mBYwVGxBZn6chUjldqW0tVsdFqTD27EAscIs354QKMOCituxe0aVqdf7ZxgUbU4H36MClMUKccGLiumnUzheDwi6X5GeiQlSSt0lgUtsYZUXN14EmHRXejOgs6NtnLyqXF9dEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jxB4AfN4J4holQFkFDxXOEswxaq/0zOgAFGcQ2A2ZaQ=; b=i62ZSS01kxLlBM5T3Wk06EkWMPnjoBvF27jCdMBkIpjmSsLTN4PMaUQ7ROT3ynX8F7xjDXNpQzKaLsrayFfe7o/j7fHvxXHLuKgGLrgNT+M6lz7k5wTNXIwMDm8LdnK4/hGcoldNo40HwOOhRJM78FzLL8uVT3tAYRbPBvxJbz4sUAO90ukKwRU8NQkBl/tgI6RHdkbJJW37ZndGNub+4DYsxFT3HujNOkaPfCpArKCPThxiCZjoJJd249+UCkc2kLgChNJM+6WzLr6C97FL+flFMUhAEcRnT4VAc/XZ88tgPRC8jyG6sDKi6B8LunQt2VQlza6R49qWhjXxUiO0xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jxB4AfN4J4holQFkFDxXOEswxaq/0zOgAFGcQ2A2ZaQ=; b=j8AvPtkbWpFXZr7Vg7dP3FiLy9Dp3fHQhVqI22ByQ9UW4Z1cNFRhj/mggaiQ23Ub6eJRb7YnLpKSYr8hn+2QTGAFHKE6dEEnBlpEIdvWGGzOw1a7ftI+YC6AnYNbFJqmNmSdcR2n8EXdPvHJuNf3n60JgH6M+9iEqM/3BvT7ZwI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by CH3PR12MB7713.namprd12.prod.outlook.com (2603:10b6:610:14d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 16:54:23 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::6f2d:9990:c8b5:714a]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::6f2d:9990:c8b5:714a%6]) with mapi id 15.20.6340.021; Wed, 26 Apr 2023 16:54:23 +0000 Message-ID: Date: Wed, 26 Apr 2023 17:54:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Ronak Doshi Cc: dev@dpdk.org References: <20230412162636.30843-1-doshir@vmware.com> From: Ferruh Yigit Subject: Re: [PATCH next 0/7] vmxnet3: upgrade to version 7 In-Reply-To: <20230412162636.30843-1-doshir@vmware.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0025.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::18) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|CH3PR12MB7713:EE_ X-MS-Office365-Filtering-Correlation-Id: 9af2639c-06ae-4484-e380-08db4676e2f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KpavcTdRyQ5/bU28nY6hYxCnYCe9b4w3Yj7lQrsC/WPFdvL6+F1MK5EixpfxG2TCWqRrRU4Gr8VuY3fud973FZX+EBi/BHRguONWOnw17oup6EkD/yoB64BrNM7Dn87Dm6ABf/OeUCeCPH5pPa7ziIIzUAOi1lJ0wwSNh+b4v20vOAiLJN+64KiuDMd+qR+GWZVMNhwqv5gLDtEbTwkz5I9F+a+XOJ/CR3aTMwSuViozZXilGVnbzcJMb8JyGEdXrmK+raHR1IyfmArEMPmPWXW15rndXuA5SUCLB1JbRL9GEz6LkiwfCI2mjqrwAJ72JmtMU2G7Pwqf/OUYrUxWQIuBKPGYVbLwdKKBl/4m6A3tkKJfpJxqpiiHHzLiG2WuHW2w/D7AXmqTlYmxgZVqqzJ29J70pVhkappIDN/lbuhunIzNmZYlbOf3ny2hR1P+CMGjMRSBDddC6SuM+bU22w8vdIhfW1IbfhC5ePH3DU6OO35wcRkTegJmBUZ6jiZdh3WS+p7SiPpHPi+A7Tauhy4X4oBJlhsbS33sJ6qXhIzIecoBcrK3NDftKdLOrZhLsf/KijcsjPTW8JZEEihCLzLFvcIuO1sOq6H/Ciy9QObKTl7tPDzYzMp/wHz8SnvsNkHnfhqr0Skm6rCC/OlH4A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(366004)(396003)(136003)(346002)(451199021)(31686004)(26005)(6506007)(6512007)(38100700002)(6486002)(478600001)(66476007)(66556008)(6916009)(41300700001)(66946007)(31696002)(36756003)(86362001)(6666004)(4326008)(316002)(2616005)(83380400001)(186003)(53546011)(8676002)(2906002)(8936002)(5660300002)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1J6NWtoTGJrQjVPTjc3aVQ2OGdBWjBRcEVTVk1nU2hhUFcvcnE2ZWxsbWZu?= =?utf-8?B?LzJvdEZpUUdtRlE1cUNxMXU5aXFZRWNnbDJWQlVHRnpBTEd2QnYwbmFIeHd5?= =?utf-8?B?RTN3TVF5c1FFbDc3QlJnd0ticFVWaDVORnF4bHNtN1RYQTgwcTVLRE5TbDlB?= =?utf-8?B?VmYzOHkzdEl6YXdNd1Z5VTdZTkxWcndBVXJjb1dDWDBUbXVLalNZeGtzeTlQ?= =?utf-8?B?VUhxcjRPYjJBY21rNVZ6Sldab1BOeEE4dGtqUE91WjNUVk1OUmxRUGxrS1d3?= =?utf-8?B?WEpvdnA1Zkt3Ymx6R0p5TTFqdERjY3dEVXgxeEZubUNOS3A4bVlpRS9TdmhM?= =?utf-8?B?cnRiLzBZbm5LMU1Id0Z4Wm9Zc1Z6NEdJWWtpSXhpaGxtME5qTEdTTDY4NWxX?= =?utf-8?B?WEp2bkRTNlF5VVJvL0xscG9sYmw5aVRYZHYzS3BjcGVWYlBHUXRtWHJxTSsx?= =?utf-8?B?K0pZZFcvTEV1RVZQMko2bUFiTmlLc1gzdEZ6bENqVS82aG1vTDVoUUIxZmd1?= =?utf-8?B?Q01Ca01DYzhsOWpZdlZoUzJkYTU2SUszUGVtMVpOM1hVRHMzcXFtUEl3cnpz?= =?utf-8?B?UkdybHVEaHhKbE5CcFhiMlVHYWRlNUxnTzd1N29PeW5YSFQyZEpRcFpqOFhi?= =?utf-8?B?QmFvbnV3RDZxejN6VS90V2pzeEJGVHJLaUNTTmVKY3RwaHc2SVBtWTdrU0F6?= =?utf-8?B?bk8zRDNjTU1DNkhaZzV0MG51U0FTTkRxNUJQOFFqck5CSThadk9VSFdVWjBO?= =?utf-8?B?bGk0NjVtK05RVkpaWlgrQXJhM0YyR1llMzJLM3ozVUZRU3VMR1FpeGJ3ajNp?= =?utf-8?B?SGlHVnRRTmNtTDhlUlZham4rSWM3a0NkSDBHdUNaU21EaHBsRnBmQ0V1bEw0?= =?utf-8?B?UTZLckhpL1hWMW81R3JlRXlEekhqeVRxQjVQNExhWmRaOFVzcTI1QW9JbUxF?= =?utf-8?B?ZlR1WU45WHViMERwbmVJYzkxd0J4dENSaHhQYVpobVR6OFMxdk91VHlsa05J?= =?utf-8?B?UlFob1YvZENXMG1BUHhjNTlJWkdxeGNBYzhQUEtibFI5elJpWElRcEprSHpI?= =?utf-8?B?T2U2d3NuVUZjM2d1d0lDL0RLNEZBUjVYTC9BaXMyNzFuVzArdWh3WHp1ZUNt?= =?utf-8?B?VmorTFNCVnJTeGhuV28yUkQwU1M5NHZOT2NWcEVCbjk4cXA3NGMrUENnRTYw?= =?utf-8?B?UldNUHlkS04vWTFoQ1FWcVBiYU1vOHhmaTFUWVhiZm45QXJGWU1ldFB3SGQ5?= =?utf-8?B?TjF2QjVRUG5GNXBscEFmMU1JSEVJRzA0NmFjK2JSelVPVUNjZVZ0UitjL0Ur?= =?utf-8?B?bHhOYWFUU1ZWdXN6cWlVa0lFT1UzZE5FMXRzcERvRnNTeWZiV1hJKzhtaGdm?= =?utf-8?B?MzhiVHg3TXpRUXBNaHVIYi94L0QyMDNxMmpNSXF3ckJsK1pzZ3c4cHFJVkU3?= =?utf-8?B?S1RTWFl0K1dFWjdvRTJ1SWwrTUpYc1hHc2M1NlM0RDR3elNjTW9ROW93aUV2?= =?utf-8?B?b2t2dVYwQTNDOTg4RDhpTUJ2ckxOUVppUkt2Qk9zWERHNUFZQTRRSm5ZdVdU?= =?utf-8?B?ZlhCSGVpQmh3N2t5ZXh4a0tjd3J5WG5HcFJ0NUIxYXBZR3pXa1hudTNZQ0Yr?= =?utf-8?B?aHpVazNkTURIaDZXNm9EZS9qb0NjSGNNenNxeWRjNm5jQ2Z0djdRVWlVbVda?= =?utf-8?B?SHpmMjdPVFdIS28vb29HV2RMbGNjU2JkVDhyNXQzUXp4bGVFY3hhTnMyMnc4?= =?utf-8?B?YTZodGh4cTB5V3lnbE9abm84M2ZUVGFubmkzSmZGSWp6d0FTbStUckNFVXNk?= =?utf-8?B?Nlg4UEVCUFNwYXNmNmlFK1V1ZmZGRWpyaVkzQkMvUS9OdDZwWklPT2lEUlRr?= =?utf-8?B?OW8zeVYwaHdCZWNWUUVEcUc0Q2ZjK3FLN2JGdUtucE9WVFF5cnlSQ2VQQk9l?= =?utf-8?B?VUl3djZZT2d6Um5jeUNzMk1mam1JQU1SL1RBL0tNYjluNEhTOHh4RDJzZjlh?= =?utf-8?B?OWtsQUJ6aEp1UG9HbEhIVmMvN3Y3akVMU3NSWHRIL2Fxc24yTmNacXFqQWl1?= =?utf-8?B?alprU2RKMVY3TDFnZVUyNXp4OHd2OHladnNiMjVDakF4WHhZY2VPRkZxcFZQ?= =?utf-8?Q?b0omX4fPDAvcRsAm0IfzfVcTQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9af2639c-06ae-4484-e380-08db4676e2f4 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 16:54:23.4112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qw+mJ9peybOx2T3YDeDhdOKcH3hSqH+vtei7bqWlv1vSGF4TDR8t1L1HOWSfjWHd X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7713 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/12/2023 5:26 PM, Ronak Doshi wrote: > vmxnet3 emulation has recently added several new features including > support for uniform passthrough(UPT). To make UPT work vmxnet3 has > to be enhanced as per the new specification. This patch series > extends the vmxnet3 driver to leverage these new features. > > Compatibility is maintained using existing vmxnet3 versioning mechanism as > follows: > - new features added to vmxnet3 emulation are associated with new vmxnet3 > version viz. vmxnet3 version 7. > - emulation advertises all the versions it supports to the driver. > - during initialization, vmxnet3 driver picks the highest version number > supported by both the emulation and the driver and configures emulation > to run at that version. > > In particular, following changes are introduced: > > Patch 1: > This patch introduces utility macros for vmxnet3 version 7 comparison > and updates Copyright information. > > Patch 2: > This patch adds new capability registers to fine control enablement of > individual features based on emulation and passthrough. > > Patch 3: > This patch adds support for large passthrough BAR register. > > Patch 4: > This patch introduces new command to set ring buffer sizes to pass this > information to the hardware. > > Patch 5: > For better performance, hardware has a requirement to limit number of TSO > descriptors. This patch adds that support. > > Patch 6: > Avoid updating rxprod register when in UPT for performance reasons. > > Patch 7: > With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, > with this patch, the driver can configure emulation to run at vmxnet3 > version 7. > > Ronak Doshi (7): > vmxnet3: prepare for version 7 changes > vmxnet3: add support for capability registers > vmxnet3: add support for large passthrough BAR register > vmxnet3: add command to set ring buffer sizes > vmxnet3: limit number of TXDs used for TSO packet > vmxnet3: avoid updating rxprod register frequently > vmxnet3: update to version 7 > Can you please start the patch title with component: "net/vmxnet3: ..." > drivers/net/vmxnet3/base/vmxnet3_defs.h | 74 +++++++++++++++++++--- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 106 +++++++++++++++++++++++++++++++- > drivers/net/vmxnet3/vmxnet3_ethdev.h | 16 +++++ > drivers/net/vmxnet3/vmxnet3_ring.h | 2 +- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 48 +++++++++++---- > lib/ethdev/rte_ethdev.h | 2 + > 6 files changed, 226 insertions(+), 22 deletions(-) > Can you please update release notes to document the driver update? Also what do you think to update driver documentation to document uniform passthrough(UPT) support, how to use it etc? Or other features coming with V7?