From: Paul Szczepanek <paul.szczepanek@arm.com>
To: David Marchand <david.marchand@redhat.com>, probb@iol.unh.edu
Cc: nd@arm.com, dev@dpdk.org, Luca Vizzarro <Luca.Vizzarro@arm.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] dts: fix doxygen API link
Date: Thu, 24 Oct 2024 18:45:46 +0100 [thread overview]
Message-ID: <b9655aa5-7a74-4a44-af3a-9079b241fd9b@arm.com> (raw)
In-Reply-To: <CAJFAV8wEDRe4WwvdWZk7ZkmzK8TOv8eJ9RM2tTy_8KDxrYTXMQ@mail.gmail.com>
On 24/10/2024 10:12, David Marchand wrote:
>>
>> Looking again while applying, something is fishy in doc/api/meson.build:
>>
>> if not doxygen.found()
>> # process DTS API doc build even if DPDK API doc build can't be done
>> cdata = configuration_data()
>> subdir('dts')
>> subdir_done()
>> endif
>>
>> Should this cdata (unused afaics) object be removed too?
Yes, I'm removing this.
>
> It seems there are more issues with the doc generation.
>
> Looking at dpdk.org documentation (https://doc.dpdk.org/api/), there
> is a dead link to DTS at the bottom of the page:
> tests: [DTS]()
That's what the original patch addressed.
>
> The documentation for dts should be generated to dpdk_build_root
> /doc/api/html/dts
Yes, my V2 will fix this and place dts inside API so the website docs work.
> And I think the link should be a relative one, like
> cdata.set('DTS_API_MAIN_PAGE', join_paths('dts', 'index.html'))
>
> Please have a look.
>
Thanks. Will send out V2 as soon as it clears local checks.
prev parent reply other threads:[~2024-10-24 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 14:57 Paul Szczepanek
2024-10-23 15:00 ` Luca Vizzarro
2024-10-23 15:07 ` David Marchand
2024-10-23 15:10 ` Patrick Robb
2024-10-23 15:30 ` David Marchand
2024-10-24 9:12 ` David Marchand
2024-10-24 17:45 ` Paul Szczepanek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9655aa5-7a74-4a44-af3a-9079b241fd9b@arm.com \
--to=paul.szczepanek@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).