From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Louis Luo <llouis@vmware.com>,
Maxime Leroy <maxime.leroy@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>, Yong Wang <yongwang@vmware.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa
Date: Wed, 4 Sep 2019 09:17:01 +0100 [thread overview]
Message-ID: <b97ee495-7415-c69c-2aaa-c8eba70abdd6@intel.com> (raw)
In-Reply-To: <61F6F753-E4C9-47C3-B5DD-C4C0DFD2B897@vmware.com>
On 8/19/2019 10:56 PM, Louis Luo wrote:
> Hi Maxime,
>
> Thanks for the fix. Actually Yong and I had some discussion about removing TX IP CSUM offload flag last August and I did prepare a fix but later forgot to submit. Anyway your fix is fine.
>
> Thanks,
> Louis
>
> On 8/13/19, 6:30 AM, "Maxime Leroy" <maxime.leroy@6wind.com> wrote:
>
> The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets
> having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has
> DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa.
>
> This issue has been introduced with the new Rx offload
> API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV4_CKSUM has been
> added to the tx/rx offloads capa, but the vmxnet3 driver doesn't support
> it.
>
> To fix the issue, DEV_TX/RX_OFFLOAD_IPV4_CKSUM needs to be removed from
> tx/rx offload capa.
>
> Fixes: 95e4a96ccbf1 ("net/vmxnet3: convert to new Rx offload API")
> Cc: llouis@vmware.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
Acked-by: Yong Wang <yongwang@vmware.com>
Applied to dpdk-next-net/master, thanks.
(Carried the ack from another email)
prev parent reply other threads:[~2019-09-04 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 13:29 [dpdk-dev] " Maxime Leroy
2019-08-19 21:56 ` Louis Luo
2019-09-04 8:17 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b97ee495-7415-c69c-2aaa-c8eba70abdd6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=llouis@vmware.com \
--cc=maxime.leroy@6wind.com \
--cc=stable@dpdk.org \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).