From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by dpdk.org (Postfix) with ESMTP id A5CE211D4 for ; Tue, 29 Aug 2017 21:20:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=604; q=dns/txt; s=iport; t=1504034422; x=1505244022; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DmIF3uUD+uCMcvn3KmS24GLz7olzvzvLHyrKv7THBSQ=; b=J8pWZkKQwrEYkEcf9Wg8o+dHZ/qx4yzWHxnKArfcz0bm2NiKJz50qTxr F8C61faXsbL+R3OLquI8h1jfEadLIUWGNj/ToUM4kDR5XvOiZKin81S1f LLYTCzSz85u/bdhXJthC2dJ6wqIaq9vdH+kB9cadDcQB/oi/FNatSPhzR c=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CmAADwvaVZ/4YNJK1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1qBeQeODZAagXGWJ4IShUcChBY/GAECAQEBAQEBAWsohRgBAQE?= =?us-ascii?q?BAzo/DAQCAQgRBAEBAR4JBzIUCQgCBA4FCIopsTSLXwEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAR2DKoICgU6FC4ppAQSgaAKUQYIDGIVninKWQQEfOIENdxWHZHaKRYE?= =?us-ascii?q?PAQEB?= X-IronPort-AV: E=Sophos;i="5.41,445,1498521600"; d="scan'208";a="291933097" Received: from alln-core-12.cisco.com ([173.36.13.134]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Aug 2017 19:20:18 +0000 Received: from XCH-ALN-018.cisco.com (xch-aln-018.cisco.com [173.36.7.28]) by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id v7TJKIBm011693 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 29 Aug 2017 19:20:18 GMT Received: from xch-rcd-016.cisco.com (173.37.102.26) by XCH-ALN-018.cisco.com (173.36.7.28) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Tue, 29 Aug 2017 14:20:17 -0500 Received: from xch-rcd-016.cisco.com ([173.37.102.26]) by XCH-RCD-016.cisco.com ([173.37.102.26]) with mapi id 15.00.1263.000; Tue, 29 Aug 2017 14:20:17 -0500 From: "David Harton (dharton)" To: Stephen Hemminger CC: "konstantin.ananyev@intel.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets Thread-Index: AQHTIN6du+JEqlI0JUSpWSqzRvi0LaKb/1QA//+1YNA= Date: Tue, 29 Aug 2017 19:20:17 +0000 Message-ID: References: <20170829155056.12563-1-dharton@cisco.com> <20170829114254.7b563118@xeon-e3> In-Reply-To: <20170829114254.7b563118@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.82.214.83] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 19:20:23 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, August 29, 2017 2:43 PM > To: David Harton (dharton) > Cc: konstantin.ananyev@intel.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets >=20 > On Tue, 29 Aug 2017 11:50:56 -0400 > David Harton wrote: >=20 > > + if (n < (IXGBEVF_NB_XSTATS + IXGBE_NB_SW_STATS)) > > + return (IXGBEVF_NB_XSTATS + IXGBE_NB_SW_STATS); >=20 > Please don't use BSD style. > Return does not need parenthesis. Sure.