From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 95BFF1BB7C for ; Fri, 11 May 2018 01:48:51 +0200 (CEST) To: Stephen Hemminger Cc: dev@dpdk.org References: <152591991920.119328.14523975619615362920.stgit@localhost.localdomain> <152592056030.119328.10575471783991783458.stgit@localhost.localdomain> <20180510121841.42ed97fd@xeon-e3> From: Andy Green Message-ID: Date: Fri, 11 May 2018 07:48:17 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: <20180510121841.42ed97fd@xeon-e3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 36/40] rte_ethdev.h: explicit cast for return type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 23:48:51 -0000 On 05/11/2018 03:18 AM, Stephen Hemminger wrote: > On Thu, 10 May 2018 10:49:20 +0800 > Andy Green wrote: > >> /projects/lagopus/src/dpdk/build/include/rte_ethdev.h:3860:10: >> warning: conversion to 'int' from 'uint32_t' {aka 'unsigned int'} >> may change the sign of the result [-Wsign-conversion] >> return (*dev->dev_ops->rx_queue_count)(dev, queue_id); >> >> Signed-off-by: Andy Green >> --- >> lib/librte_ethdev/rte_ethdev.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h >> index 2487e1d2d..c84dc44b8 100644 >> --- a/lib/librte_ethdev/rte_ethdev.h >> +++ b/lib/librte_ethdev/rte_ethdev.h >> @@ -3857,7 +3857,7 @@ rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id) >> if (queue_id >= dev->data->nb_rx_queues) >> return -EINVAL; >> >> - return (*dev->dev_ops->rx_queue_count)(dev, queue_id); >> + return (int)(*dev->dev_ops->rx_queue_count)(dev, queue_id); >> } >> >> /** >> > > Why not change rx_queue_count to int to allow drivers to return an error? OK. I have done it and will push it later. I left the few related apis in ./lib/ like rte_vhost_rx_queue_count() alone, they still return a uint32_t. Naturally, I want to call that patch something like "eth_dev_ops: change rx_queue_count to return an int"... -Andy