From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36A6DA0C43; Thu, 23 Sep 2021 18:35:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD94A41257; Thu, 23 Sep 2021 18:35:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A21E64003D for ; Thu, 23 Sep 2021 18:35:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632414918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=teMQuPwefyRnfgoJ1NI2EqyIoYH6oQWcpCiHo92UEyU=; b=cFNHxc5e/N2E0mNdT++KBd87JvHVxb7RWIkOUgf5O2Cp3E6jbRUW1CDw5deFoR7p/Iy6Ss v2HtMCUxHz8pmUxOavqS4+gn5Bex1p4KA5apLhmc7/ULRjc8TZoHpUgWPbWX9/XC0Dj5P+ 2k0ksnCWVCmerwNkASOd6AvtdIbT/EE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-Gf7MQyqCO3mgqvrI27d8Wg-1; Thu, 23 Sep 2021 12:35:16 -0400 X-MC-Unique: Gf7MQyqCO3mgqvrI27d8Wg-1 Received: by mail-wr1-f71.google.com with SMTP id s14-20020adff80e000000b001601b124f50so5644698wrp.5 for ; Thu, 23 Sep 2021 09:35:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=teMQuPwefyRnfgoJ1NI2EqyIoYH6oQWcpCiHo92UEyU=; b=b6XeRzqevkEF9MvFSTVH2T+30LIZCeSMyW468Vpjx65PePjmqL5505sQCgxAfJkS3r ECAGbpWVglgR11RfFufkRnANr17+fZzyogJXbpDtUMVidLYQ2hT0hsCbKGDOSzM8F12i +Dm4IQtOQHkZzrfqEU4KdjLh0E8yYDXifelwcfB6MHycMMnjKAfQRUsvX80OYlGN6nsD Xpozt9w1hsLT1PVm8qXjvSGuZxA9mXG+oLzABvMOFCtkQzNBQ8VWr6H6UcAAqosO7JeE OzUZBLZOBfnlBpCtxMWMk5NAm909SiYdA37YoCKva5+uMmso7rBUYoJ8b7E9x/C6Otel VL5Q== X-Gm-Message-State: AOAM532LS5z2P1UPcflx+mbEF+SIRlMIfuWMISnf87L0IcbA3tf0ESet XWDWM3OVo0Ss/3fu5v9A/ksyfeZNAOoNOaelWCopJXu4Z00dJJjaXzieTA87pFliU5h2HJiPk6r a0hs= X-Received: by 2002:a5d:58ef:: with SMTP id f15mr6399088wrd.160.1632414915781; Thu, 23 Sep 2021 09:35:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZ65oV+GdqLB2guRAiyVeprRX017LjJ0ljAQULQlu55reiSPgfZpTj2vKH1jgJ/N88EOSfxw== X-Received: by 2002:a5d:58ef:: with SMTP id f15mr6399070wrd.160.1632414915618; Thu, 23 Sep 2021 09:35:15 -0700 (PDT) Received: from [192.168.0.36] ([78.18.26.217]) by smtp.gmail.com with ESMTPSA id q7sm6299399wrc.55.2021.09.23.09.35.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 09:35:15 -0700 (PDT) Message-ID: Date: Thu, 23 Sep 2021 17:35:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Thomas Monjalon , dev@dpdk.org Cc: Ferruh Yigit , Andrew Rybchenko References: <20210830104232.598703-1-thomas@monjalon.net> From: Kevin Traynor In-Reply-To: <20210830104232.598703-1-thomas@monjalon.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: group constant definitions in Doxygen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30/08/2021 11:42, Thomas Monjalon wrote: > A lot of flags are parts of a group but are documented alone. > The Doxygen syntax @{ and @} for grouping is used > to make flags appear together and have a common description. > > Some Rx/Tx offload flags and RSS definitions are not grouped > because they need to be all properly documented first. > > Signed-off-by: Thomas Monjalon > --- > lib/ethdev/rte_ethdev.h | 71 ++++++++++++++++++++++++++++------------- > 1 file changed, 48 insertions(+), 23 deletions(-) lgtm, this is a nice enhancement when reading the api guide. Acked-by: Kevin Traynor