[dpdk-dev] Missing SPDK and redundant license info

[dpdk-dev] Missing SPDK and redundant license info

[Stephen Hemminger]

These should be fixed before release!
Makefiles will be dropped.
The ethdev stuff is from Jan Blunck, let me see if I can find current email.


$ ./devtools/check-spdx-tag.sh -v
Files without SPDX License
--------------------------
doc/guides/custom.css
doc/guides/linux_gsg/nic_perf_intel_platform.rst
doc/guides/prog_guide/build-sdk-meson.rst
drivers/net/qede/base/ecore_hsi_func_common.h
examples/multi_process/Makefile
examples/multi_process/client_server_mp/Makefile


Files with redundant license text
---------------------------------
app/test/test_timer_racecond.c
lib/librte_ethdev/rte_ethdev_pci.h
lib/librte_ethdev/rte_ethdev_vdev.h

total: 6 errors, 3 warnings

[dpdk-dev] [PATCH] ethdev: remove redundant license text

[Ferruh Yigit]

Redundant BSD-3 license text removed, the licensing already documented
by "SPDX-License-Identifier: BSD-3-Clause" SPDX tag.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Jan Blunck <jblunck@infradead.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_ethdev/rte_ethdev_pci.h  | 26 --------------------------
 lib/librte_ethdev/rte_ethdev_vdev.h | 26 --------------------------
 2 files changed, 52 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h
index a999602fdd..ef828ea16a 100644
--- a/lib/librte_ethdev/rte_ethdev_pci.h
+++ b/lib/librte_ethdev/rte_ethdev_pci.h
@@ -1,32 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2017 Brocade Communications Systems, Inc.
  *   Author: Jan Blunck <jblunck@infradead.org>
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of the copyright holder nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef _RTE_ETHDEV_PCI_H_
diff --git a/lib/librte_ethdev/rte_ethdev_vdev.h b/lib/librte_ethdev/rte_ethdev_vdev.h
index b3ef12398e..bf468125aa 100644
--- a/lib/librte_ethdev/rte_ethdev_vdev.h
+++ b/lib/librte_ethdev/rte_ethdev_vdev.h
@@ -1,32 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2017 Brocade Communications Systems, Inc.
  *   Author: Jan Blunck <jblunck@infradead.org>
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of the copyright holder nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef _RTE_ETHDEV_VDEV_H_
-- 
2.26.2

Re: [dpdk-dev] [PATCH] ethdev: remove redundant license text

[Ferruh Yigit]

On 9/10/2020 12:08 PM, Ferruh Yigit wrote:
> Redundant BSD-3 license text removed, the licensing already documented
> by "SPDX-License-Identifier: BSD-3-Clause" SPDX tag.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Jan Blunck <jblunck@infradead.org>
> Cc: Stephen Hemminger <stephen@networkplumber.org>

Reported-by: Stephen Hemminger <stephen@networkplumber.org>

Re: [dpdk-dev] [PATCH] ethdev: remove redundant license text

[Andrew Rybchenko]

On 9/10/20 2:08 PM, Ferruh Yigit wrote:
> Redundant BSD-3 license text removed, the licensing already documented
> by "SPDX-License-Identifier: BSD-3-Clause" SPDX tag.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

[dpdk-dev] [PATCH] net/qede/base: add missing licence

[Ferruh Yigit]

Adding BSD-3 SPDX license tag.

Fixes: 519438f7c17f ("net/qede/base: re-arrange few structures for DDC")
Cc: stable@dpdk.org

Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Jerin Jacob <jerinj@marvell.com>
---
 drivers/net/qede/base/ecore_hsi_func_common.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/qede/base/ecore_hsi_func_common.h b/drivers/net/qede/base/ecore_hsi_func_common.h
index 2cd175163b..4351b7b14f 100644
--- a/drivers/net/qede/base/ecore_hsi_func_common.h
+++ b/drivers/net/qede/base/ecore_hsi_func_common.h
@@ -1,3 +1,9 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2016 - 2020 Cavium Inc.
+ * All rights reserved.
+ * www.cavium.com
+ */
+
 #ifndef _HSI_FUNC_COMMON_H
 #define _HSI_FUNC_COMMON_H
 
-- 
2.26.2

Re: [dpdk-dev] [PATCH] ethdev: remove redundant license text

[Ferruh Yigit]

On 9/10/2020 12:12 PM, Andrew Rybchenko wrote:
> On 9/10/20 2:08 PM, Ferruh Yigit wrote:
>> Redundant BSD-3 license text removed, the licensing already documented
>> by "SPDX-License-Identifier: BSD-3-Clause" SPDX tag.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 

Cc: stable@dpdk.org

Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [EXT] [PATCH] net/qede/base: add missing licence

[Igor Russkikh]

Thanks Ferruh,

> Adding BSD-3 SPDX license tag.
> 
> Fixes: 519438f7c17f ("net/qede/base: re-arrange few structures for DDC")
> Cc: stable@dpdk.org
> 
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Jerin Jacob <jerinj@marvell.com>

Acked-by: Igor Russkikh <irusskikh@marvell.com>

Re: [dpdk-dev] [EXT] [PATCH] net/qede/base: add missing licence

[Jerin Jacob]

On Fri, Sep 11, 2020 at 12:53 PM Igor Russkikh <irusskikh@marvell.com> wrote:
>
>
> Thanks Ferruh,
>
> > Adding BSD-3 SPDX license tag.
> >
> > Fixes: 519438f7c17f ("net/qede/base: re-arrange few structures for DDC")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > Cc: Jerin Jacob <jerinj@marvell.com>
>
> Acked-by: Igor Russkikh <irusskikh@marvell.com>

Applied to dpdk-next-net-mrvl/master. Thanks