From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DD98A056A; Thu, 11 Mar 2021 19:05:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC323406A3; Thu, 11 Mar 2021 19:05:23 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 1F4B04014D for ; Thu, 11 Mar 2021 19:05:21 +0100 (CET) IronPort-SDR: kkLY97F7K9UpETDlV+7C55SJesXwZBcY3gYfoPxQK/SyOOzk9Lbs9GsYUulf7zB+Dk9eXqPYV+ V5/cQ0wZyQOA== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="167986246" X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="167986246" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 10:05:20 -0800 IronPort-SDR: lyS3Yi9K8wjU1eRTYwHP0R7hHePnLxErpqeJ1rv3sT2z7B0vW3bHUHKIhOZ5CMpQztU6Ya2W++ 0nth66pMPcQw== X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="448361604" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.22.78]) ([10.252.22.78]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 10:05:18 -0800 To: "Min Hu (Connor)" , dev@dpdk.org References: <1615356985-24722-1-git-send-email-humin29@huawei.com> <1615356985-24722-3-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 11 Mar 2021 18:05:15 +0000 MIME-Version: 1.0 In-Reply-To: <1615356985-24722-3-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/9] net/hns3: support Tx push quick doorbell to improve perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > Kunpeng 930 support Tx push mode which could improve performance, It > works like below: > 1. Add pcie bar45 which support driver direct write the Tx descriptor > or tail reg to it. > 2. Support three operations: a) direct write one Tx descriptor, b) > direct write two Tx descriptors, c) direct write tail reg. > 3. The original tail reg located at bar23, the above bar45 tail reg > could provide better bandwidth from the hardware perspective. > > The hns3 driver only support direct write tail reg (also have the name > of quick doorbell), the detail: > 1. Considering compatibility, firmware will report Tx push capa if the > hardware support it. > 2. Add control macro RTE_LIBRTE_HNS3_ENABLE_TX_PUSH which was not > defined default. > 3. If user define macro RTE_LIBRTE_HNS3_ENABLE_TX_PUSH and hardware > support, then driver will direct write bar45 tail reg to inform the > hardware. Can you convert the copile time 'RTE_LIBRTE_HNS3_ENABLE_TX_PUSH' flag to runtime device argument? There is already 'tx_push_enable' variable check on datapath, so converting to devarg shouldn't add any additional checks and shouldn't have performance impact. > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) <...>