From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF0D9A0598; Fri, 10 Apr 2020 22:47:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28C531D561; Fri, 10 Apr 2020 22:47:51 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 177CE1D53C for ; Fri, 10 Apr 2020 22:47:49 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200410204748euoutp02575387b1907b0afd814fb31a1b00f761~EkFY_H5783077130771euoutp02v for ; Fri, 10 Apr 2020 20:47:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200410204748euoutp02575387b1907b0afd814fb31a1b00f761~EkFY_H5783077130771euoutp02v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1586551668; bh=Lrh5zvjrVUBUfNArqydR9BESncbivHWezXtswFIY3eg=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=m09/zb3hkl0QXkSXnRV2Ep4SGAKYAcMLpcQRW7yGlJQnfDYN+K6HPyN/qH281FZSP ri9O992H/OgzxW0FsDMn9vjJzgD7f6TjhR8It1tT0zUzBS3z3hD04DsVRCJD1/PzjM mpO8UzaiZTVg2Fcav7O+CDw8pm5AWFTk3pfOZWBM= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200410204747eucas1p272a726e7d4aa3488aa8beea9e17ea48a~EkFX8dijk1671616716eucas1p2R; Fri, 10 Apr 2020 20:47:47 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id F5.72.60698.37BD09E5; Fri, 10 Apr 2020 21:47:47 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200410204746eucas1p208e15267ade34f23a3bbebb15e821c08~EkFW1q1zv1052710527eucas1p2P; Fri, 10 Apr 2020 20:47:46 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200410204746eusmtrp1387d8703829b643ca1a097111f728e8e~EkFW1Eeew0440604406eusmtrp1Q; Fri, 10 Apr 2020 20:47:46 +0000 (GMT) X-AuditID: cbfec7f5-a29ff7000001ed1a-3a-5e90db7342e2 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 8B.16.08375.27BD09E5; Fri, 10 Apr 2020 21:47:46 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200410204745eusmtip16bbbba47fd95009baeeba678bd61b997~EkFWL208W1260512605eusmtip1Z; Fri, 10 Apr 2020 20:47:45 +0000 (GMT) To: Thomas Monjalon , Bruce Richardson Cc: dev@dpdk.org, Aaron Conole , Ruifeng Wang , David Marchand , Gavin Hu From: Lukasz Wojciechowski Message-ID: Date: Fri, 10 Apr 2020 22:47:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1933780.kXSN5OTJKJ@thomas> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDKsWRmVeSWpSXmKPExsWy7djP87rFtyfEGezarWHx680Ddosbq+wt tq/oYrN492k7k8XJF68YLa723WC2+PTgBIsDu8eaeWsYPX4tWMrqsXjPSyaPYzensXu833eV LYA1issmJTUnsyy1SN8ugStj+/QWpoJnPBUNL9YyNTBO4+pi5OSQEDCRePzlInMXIxeHkMAK RonLT1pYIZwvjBJbTnZCZT4zSnzbvoy9i5EDrOXWBBaI+HJGiX8XrzNCOG8ZJX6+PM4OMldY wFniwvb/zCC2iECUxM49R5lAipgFljJKXLjXwQaSYBOwlTgy8ysriM0r4CZx4/kXsGYWAVWJ n32TwOKiArES5x7dgKoRlDg58wkLiM0poCFx7NI7sAXMAvISzVtnQ9niEreezAdbJiGwjV3i zrSNjBCfukhcPdzBCmELS7w6voUdwpaROD25hwWqgVHi6u+fjBDOfkaJ670roKqsJQ7/+80G CgBmAU2J9bv0IcKOEttuP2GFhAufxI23ghBH8ElM2jadGSLMK9HRJgRRrSfxtGcqI8zaP2uf sExgVJqF5LVZSN6ZheSdWQh7FzCyrGIUTy0tzk1PLTbOSy3XK07MLS7NS9dLzs/dxAhMQ6f/ Hf+6g3Hfn6RDjAIcjEo8vBmxE+KEWBPLiitzDzFKcDArifB6N/XGCfGmJFZWpRblxxeV5qQW H2KU5mBREuc1XvQyVkggPbEkNTs1tSC1CCbLxMEp1cDYec931oasMwJvKl6u9L6/yL4398RP u/k6Utp1h26YL/izv1nV9fKtGadlr+Su45u7ySC3/vGNT4u/t6vmtO3Oje84ZHzv5Om5lXKl ThUPP8yetMuwVboh+fd72++buK/eFG51LfMUDlK6cjBuzcElRnrtV2RnfNvA799jd27/lIq/ Z066zmg4oMRSnJFoqMVcVJwIANXFyCk/AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t/xu7pFtyfEGZz9LmXx680Ddosbq+wt tq/oYrN492k7k8XJF68YLa723WC2+PTgBIsDu8eaeWsYPX4tWMrqsXjPSyaPYzensXu833eV LYA1Ss+mKL+0JFUhI7+4xFYp2tDCSM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS9j +/QWpoJnPBUNL9YyNTBO4+pi5OCQEDCRuDWBpYuRi0NIYCmjxIOr+1kh4jISHy4JdDFyApnC En+udbGB2EICrxkl3h1JA7GFBZwlLmz/zwxiiwhESXzdPIkRZA4zyJwvTdeZIYY2Mkls/tjB BFLFJmArcWTmV1YQm1fATeLG8y/sIDaLgKrEz75JYHFRgViJ/ubdjBA1ghInZz5hAbE5BTQk jl16B7aNWcBMYt7mh1C2vETz1tlQtrjErSfzmSYwCs1C0j4LScssJC2zkLQsYGRZxSiSWlqc m55bbKhXnJhbXJqXrpecn7uJERhz24793LyD8dLG4EOMAhyMSjy8GbET4oRYE8uKK3MPMUpw MCuJ8Ho39cYJ8aYkVlalFuXHF5XmpBYfYjQFem4is5Rocj4wHeSVxBuaGppbWBqaG5sbm1ko ifN2CByMERJITyxJzU5NLUgtgulj4uCUamDkXxewop6TfcXkny2u7cV970Q5HZQmdW9Xvy8t cvDAU7XnwR7iKnPFZJQ4qpl/caw8Llu3s+xu85/4TW2sW66dm2ee+TH/hKZ8+73rrWnf/5Zq tNo8Xvb9SCl76LOKE9bOuct41p5QiT18oTdkS6/H328751U0Mr43Yy5kuXt38Uxdl7NVoglK LMUZiYZazEXFiQBHdR/uzwIAAA== X-CMS-MailID: 20200410204746eucas1p208e15267ade34f23a3bbebb15e821c08 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200410144137eucas1p2a55af8d4f5020dd425ae5a57b7abd8fc X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200410144137eucas1p2a55af8d4f5020dd425ae5a57b7abd8fc References: <20200409180332.592074-1-thomas@monjalon.net> <1813726.1xdlsreqCQ@thomas> <20200410132547.GB42@bricha3-MOBL.ger.corp.intel.com> <1933780.kXSN5OTJKJ@thomas> Subject: Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 10.04.2020 o 16:41, Thomas Monjalon pisze: > 10/04/2020 15:25, Bruce Richardson: >> On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: >>> 10/04/2020 12:42, Bruce Richardson: >>>> On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: >>>>> --- a/app/test/meson.build >>>>> +++ b/app/test/meson.build >>>>> has_hugepage = true >>>>> if is_linux >>>> Since you check for linux in the script, you can drop these two lines, >>> The issue is for Windows. >>> I am not sure how we will skip shell scripts >>> when adding Windows support for this application. >>> So there are two options now: >>> a) remove Linux check before calling the script and ignore Windows support for now >>> b) keep Linux check without knowing whether it will be useful for Windows support >>> >>> We vote a? >>> >> c) Write all such scripts in python, to allow them to run everywhere. :-) >> >> Given that windows is the problem, having the is_linux check in the >> meson.build file makes most sense - in which case I don't think we need the >> check for linux in the script. > Yes, let's make it simple for now. > a) is ok as the current meson.build won't work in Windows environment at all. c) would be best, but I guess it's a little bit to much for this patch and the whole build system could be adjusted to windows in separate thread. And I agree with Bruce, that the check for Linux in script is not needed. > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com