From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CC9042B7D; Tue, 23 May 2023 12:34:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1ACE840EF0; Tue, 23 May 2023 12:34:24 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2048.outbound.protection.outlook.com [40.107.93.48]) by mails.dpdk.org (Postfix) with ESMTP id CF4E040689 for ; Tue, 23 May 2023 12:34:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FQqN6M9c9eY+bpCimXv9YkwlQ4tw1PPwGXvvWRxVW0eCB3W3XtbISN40nHrdGhnI/2jrFaxEolWJsiVqeKe+UbFZ7LJ+YVJG6Zl//irKTF2ZxQ6ICbwfUc2SmrtmoNVHBfyh/5Ry8Oy3AssUjTH4B8lHhzMheawdSZ0op8hcrwSlbiUOdQYPxxy5RnvPtzs1nQMUio89WCqw+gDH4zqkq3Dxwhbc1ohQE07Ntgit0NGzhqCrDf3O0qVf/SK2G+oSB+OBQztfVnsf98bMJELQL0VONf9Y0ceFlTDNn2lwz1XDvf1+X3nBeWAnRVxX40y6Srfck+12dYNw8GqS2Tt2Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WJdHc1aMoN0+hWobCdGcNPhII5nHGhqtBwPWaPFh/Y4=; b=RoqnT7/JIrqvQ37aZ5Y4YniLgSY9PiDt6H1JQYiQLiWv5SPvRx15nFvl2OzRBRuBGQPFIR2IKEzvgJmB3Gj2Tc/ce7HXN7ockkuAMJNCMoakCh+apEOuQJ9q3jmLneeusScKU/mJZgu5lcOtZCO0BBTL+XvcbrYD6HcvqhDKu/rOe0CuzcatzBAs+GJlWfDcT2sqD/WMVkcK19u236GHTPRT2JRZ0bJmhl26kT5+tXiodoTcvW/ks7cAI0ZwJvEyBOP+t5JXsVyTApaqRwODJYe5aCgekurmeIpdL37hQB0fVTRXGDYonVZ+gFetUs0V4Ari5/DmiJMWkzD/pk8I5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJdHc1aMoN0+hWobCdGcNPhII5nHGhqtBwPWaPFh/Y4=; b=GZqhfWYRj75UCKJrTWXMvZk6PynqH42UYL4ihQohN6qehaTNVMxCgxfRs1MZiGol1WPoxNh5YkJGn+VNg5TBoMauwNZmGJFLRi8wxN720QkIZTzsnzhdSRfLINgvY4fk9J/4oaJuOgBK3sNEbVTTAeFQrqlzgGge5M5VLzh+LzI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4497.namprd12.prod.outlook.com (2603:10b6:5:2a5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 10:34:21 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.028; Tue, 23 May 2023 10:34:21 +0000 Message-ID: Date: Tue, 23 May 2023 11:34:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Ori Kam , Alexander Kozyrev , "dev@dpdk.org" Cc: Matan Azrad , "NBU-Contact-Thomas Monjalon (EXTERNAL)" References: <20230518194943.2338558-1-akozyrev@nvidia.com> <20230518214852.2364233-1-akozyrev@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH v3] ethdev: add flow rule actions update API In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0430.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::34) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4497:EE_ X-MS-Office365-Filtering-Correlation-Id: 9715f758-01c7-49ef-65ea-08db5b7944e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Adx5QbKAZQ+e5Xr0wC9x7ap6/YIRU7nq4YGrpzw+qAV4UlcPWLqelQWYXMDwhrFdphSFKNx8dNvclkXsFitnGXj69dbFyPPJHEewKvf9hj6cXkDBhqNTWXbgI0XmnnuItM4tJjMF9hXbh7r0BSr1A/vsNzOsVmKJFkJvCc2zwC/llE/p17SShBiUPhZOOAfRcQ5AescHt9wJBOdaTD1LBJcGO66AyblalMVPgpaKV+/1rlgnLjKMARZuFYbvij4txxYbtO/5B0dvgpcLyZhzL3uP/N+fDj0LUeHgYJcinYGtDrqQRjHyFcnzdr+4ZsZTZ/bdFCN5UTIc8XTCqzuYu0d9pO+JLWTKN2n9Eqn2lbLkW2ZaQc8plpScWYsG98vOKPUL/y1VTOMTGW+Y871NRsWXS4QfqKjA5ynpJwa8Y7H6SGSp02j8sSMVd+p3jSlijPR4HI/IE3NtHPtjgINyJy7/ByOKG2TQmSSuWsXXrWERNmX8RM0oyWtF/aVSV2NNT+6XeupglS3jFmWGtWpFDBS5gbySmhN04M3Zq8nz5JghBPTDq+O4B9ugjkdaPlU1uhCTqzkPCb+DjNzLLKuYzjbevhdc2G/7PHBwh1UzQMyS9NIe8pGXwiz37ieASlvKNMzRPHfDnhX/HIVs0ezArQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(451199021)(8676002)(8936002)(44832011)(5660300002)(83380400001)(186003)(53546011)(6512007)(6506007)(2616005)(86362001)(31696002)(26005)(6486002)(38100700002)(66946007)(41300700001)(66556008)(6666004)(478600001)(4326008)(36756003)(66476007)(110136005)(316002)(54906003)(2906002)(31686004)(15650500001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmJKb0UvNWVMRG9Xa3dzaVhpczdTR0pML21vSXh0dzhRUmw3TktCTk5pVzNx?= =?utf-8?B?ZlhEeUlnVTF3aEFLUjRyVENLKzZIZzJocEdjcHFxNTZvRUVzY0lsRDZWTHFa?= =?utf-8?B?VEZZWGVhLzREM2JaK2hlSmk4TmJEb29WdVhSaVBpeGVhSHJSN3lBS3dVVHkx?= =?utf-8?B?Qnd5UjZsWFo4Y1VqZVRLVkNGM09aRkliOG9ROG9HWTlCMnJDOWpNRlI2REhL?= =?utf-8?B?TUljZkZPOE5YUElEVTJzV2xOek15Wnp3ZjhWaTNHWTRhS0NhcVhWUkJRN3hL?= =?utf-8?B?OW0zdjhHRWNxZHdkbkVGN0FvWDk1RlBoYmtkNGRROXkzcTNQSUFydnB2cDhV?= =?utf-8?B?U3ZwL1J4YzNyYXIvRTlBb0dReTB2SXVEdG5oS1U4ZklBZkJEQVZpampkcmE4?= =?utf-8?B?QjhOdHh2UUltdVlZRXlBc3RKcitycGVidFkzdTN3eEZkdXY0eGFFMlZZMVFQ?= =?utf-8?B?SWxNZmRhZEZjMm1iUVZHWUJqa1BkS2pZMHI3b3NXVTlneXVQUHphb3BUM2ds?= =?utf-8?B?czFHZS9Na0I3b0M0R1ltcDE0NFJWR0dselFVMUlSTmZ5blBYM1JoQVloWDRa?= =?utf-8?B?ZjNNYndqcXpXVGQzckphMUx6L3NzQS9FaEtXUUY5WDZZL0NQQit1eGxVWlJB?= =?utf-8?B?b2R1ejlhYU9VbkVOMFRDWTAwVWlpcnRoWndjeTFtc1pha0NCVDZMVjZlSEZS?= =?utf-8?B?a0tRekMwblFvOXJjT055RktqbENVejJOOS9mUXNtSHkrTkVEd3hSeG5WVUdW?= =?utf-8?B?ZGMvOUpzZENOZDYrb3JBRWczODhjWVZqQmJHRHV1VTdEdlliek0wU2taRW5p?= =?utf-8?B?bzQxZThhSHRTVEhzOC9OSzM0VkZyU2dBWHdRa1hFOGYzY25CeFJLWTVJTXBG?= =?utf-8?B?aVhBR1JiVUpqUTd4NWp3RDY0N2FQbTczQ0RZbHJ2THlTNkk1RHl6ZnpiTXZa?= =?utf-8?B?c1R1OGhyalhMTU1zc05hK0ZJbnBFWGtVK0NWKzN2czVsMGE5WUFFMVlMWnZl?= =?utf-8?B?cDNvbGJmNzYrOEUvWWthdnVLYkVwTHEvOHZJTndabDgzV1Z0OW9hL1lZL3pj?= =?utf-8?B?dDdlalZpR3NHNkRIaWFjWFliZW40YUErY3RJZ0Fsc1lYaEV2ZW1OK3E4YTN5?= =?utf-8?B?MDJRMDZxNlJsdkZ3SzRDYlhzdUVET2twcWo2eEFUWXlCd20wVHU4NHRwRDlV?= =?utf-8?B?aVZpNFlIbktyTDlxbmNmUFlTc1dNdzRmVklhRHB1SGNxUloza3BkNFdDQU1L?= =?utf-8?B?QkdkbGlEYjRweFFjSG9EM1RGSnpaSlY0YjM2eithWi9uMjk4RjNibFZSWG9W?= =?utf-8?B?UnBLOUorSy9wT292UHpEdVJkZmI5WXpRMERFMTA2b1FuLyt0R2xNUmRWcEpx?= =?utf-8?B?L1VkaUdYM0VIbHdpS2Q0UUlkYTlMRFZlVkFhRy84LzVZMS9FSU96TXRkQkVk?= =?utf-8?B?NkRvMS9TeXZaUS81OEUvb09aMlZLODlIRzIwVWg4U0hvclBKNlp3c3h5Z0ZZ?= =?utf-8?B?RWJmRVZtS1ZoSnFZd0p0L1IvNEJqb0RPdi9pR0VkZ3FNck5VU3RkWXpoMDRi?= =?utf-8?B?NHVxMWJKcG5YSmoyT24wSUhmMTlvRWV3WERuZWRnZm5kTko1NnU1NGpoQXZk?= =?utf-8?B?eGFaRVBjUVllZTdqWWVxbzdYTW5tT0JFUkRscWpVSGpOSUduekRlWVR3R1l4?= =?utf-8?B?K3MvWFYwZmNYWm1KeUhzMENTU1VNTlJFUXB1MGErWUI1QWxGdWZSa3FvTWd5?= =?utf-8?B?WGxFR0ZJdG5tY01HRXRIOUhqajFEVTdYb005Y2NMekJNRUlOK2QxNGZWOVda?= =?utf-8?B?Y2dGalozMW9vaHcxVjRnMzV4VGhBQWt2dHdIMjd4dGdiWnYxdVlBL1BKeG9N?= =?utf-8?B?UjRlVW8rM1lHK3d0VEFGckpGZitja2xiVVJzNEtLVGI4M0FmMVczMUovTjhC?= =?utf-8?B?aThrN0NJMkRTKzZnS2E2NGpnNk5idnpWV0RFNnNTVVhIY1dPcHpQcEw3dlRH?= =?utf-8?B?c05FenM2cEc3N3Z5TWh4QjN5NG1EdDUvcGJGeDFIcGJEOVpQWk8yWWVHKzRR?= =?utf-8?B?d1g5R3NOQ05kdGJpT3d6RGVOb2IwYVVYcXRBMUcrOXNPbGZVR2s1QWI5MEkr?= =?utf-8?Q?7Fq8S/Yigx00hxdC+DVrYwZDG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9715f758-01c7-49ef-65ea-08db5b7944e6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 10:34:21.0421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gSzI6gmIMnr17cTo8LGb2FGExDuZ1rb0HPUAmZGpACZ+YaO8Boq+xL7hYwbApwKK X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4497 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/23/2023 7:59 AM, Ori Kam wrote: > Hi > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Monday, May 22, 2023 1:28 PM >> >> On 5/18/2023 10:48 PM, Alexander Kozyrev wrote: >>> Introduce the new rte_flow_update() API allowing users >>> to update the action list in the already existing rule. >> >> If the API is only to update actions, does make sense to rename it to >> explicitly state this, like: >> `rte_flow_action_update()` >> >> Same for async version of the API. >> > > I'm O.K with the suggested name. > Maybe just change action to actions? > Both OK for me, existing APIs have mixed usage of 'action' vs 'actions', is there a clear distinction when to use one or other? > Best, > Ori > >>> Flow rules can be updated now without the need to destroy >>> the rule first and create a new one instead. >>> A single API call ensures that no packets are lost by >>> guaranteeing atomicity and flow state correctness. >>> The rte_flow_async_update() is added as well. >>> The matcher is not updated, only the action list is. >>> >>> Signed-off-by: Alexander Kozyrev >> >> <...>