From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <maxime.coquelin@redhat.com> Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4729A1B24F for <dev@dpdk.org>; Mon, 6 Nov 2017 09:12:56 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 719A8820F7; Mon, 6 Nov 2017 08:12:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 719A8820F7 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=maxime.coquelin@redhat.com Received: from [10.36.112.52] (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69D3463F82; Mon, 6 Nov 2017 08:12:52 +0000 (UTC) To: "Yao, Lei A" <lei.a.yao@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "yliu@fridaylinux.org" <yliu@fridaylinux.org> Cc: "mst@redhat.com" <mst@redhat.com> References: <20171103155235.29869-1-maxime.coquelin@redhat.com> <1d70c3b9-67c5-22d8-9312-33e43db0ac70@redhat.com> <2DBBFF226F7CF64BAFCA79B681719D953A2CFC88@shsmsx102.ccr.corp.intel.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> Message-ID: <ba10c3c0-2db1-a398-8940-f384c6af9058@redhat.com> Date: Mon, 6 Nov 2017 09:12:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A2CFC88@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 06 Nov 2017 08:12:55 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: postpone ring addresses translations at kick time only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 06 Nov 2017 08:12:56 -0000 On 11/06/2017 04:26 AM, Yao, Lei A wrote: > Hi, Maxime > >> -----Original Message----- >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >> Sent: Friday, November 3, 2017 11:57 PM >> To: dev@dpdk.org; yliu@fridaylinux.org; Yao, Lei A <lei.a.yao@intel.com> >> Cc: mst@redhat.com >> Subject: Re: [PATCH] vhost: postpone ring addresses translations at kick time >> only >> >> Hi Lei, >> >> On 11/03/2017 04:52 PM, Maxime Coquelin wrote: >>> If multiple queue pairs are created but all are not used, the >>> device is never started, as unused queues aren't enabled and >>> their ring addresses aren't translated. The device is changed >>> to running state when all rings addresses are translated. >>> >>> This patch fixes this by postponning rings addresses translation >>> at kick time unconditionnaly, VHOST_USER_F_PROTOCOL_FEATURES >>> being negotiated or not. >>> >>> Reported-by: Lei Yao<lei.a.yao@intel.com> >>> Signed-off-by: Maxime Coquelin<maxime.coquelin@redhat.com> >>> --- >>> lib/librte_vhost/vhost_user.c | 33 ++++++++------------------------- >>> 1 file changed, 8 insertions(+), 25 deletions(-) >> >> Could you confirm the patch fixes the issue on your side? >> >> I tested below cases with and without IOMMU: >> - Host DPDK queues = 1 / QEMU queues = 1 / Guest DPDK queues = 1 >> - Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 1 >> - Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 2 >> >> Thanks, >> Maxime > > > Thanks for your patch. I test my test cases with your patch based on v17.11-rc2, > It can fix my issue here. Thanks for the testing! Maxime > BRs > Lei >