DPDK patches and discussions
 help / color / mirror / Atom feed
From: Laurent Hardy <laurent.hardy@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability
Date: Wed, 8 Jan 2020 16:16:27 +0100	[thread overview]
Message-ID: <ba216d2c-69b5-9d33-8cab-a69c2ba48298@6wind.com> (raw)
In-Reply-To: <1709381.atdPhlSkOF@xps>


On 1/8/20 3:07 PM, Thomas Monjalon wrote:
> 08/01/2020 14:58, Laurent Hardy:
>> About the 'is_supported()' versions of APIs, in the current patch I
>> factorize
>> the check on dev ops on and off availability in a same function named
>> "led_ctrl_capable" but I can rename it if required.
>>
>> Just in this specific case I don't dissociate on and off capability, as
>> being
>> able to set the led off without a way to set it on again sounds a bit
>> unusual :)
>>
>>> The other alternatives are in rte_eth_dev_info and dev_flags.
> Basically we just need to decide whether we prefer a new function
> or a new flag.
>
> Until now, capabilities were given in flags.
> Why a function here?
>
For this case, (led control API) all material is already available at 
rte_ethdev layer.

So you could rely on led_off/on ops availability without the need to 
add/maintain in

all pmds some flags to expose such capabilities.

What do you suggest to set a capability flag for the device at 
rte_ethdev level?



  reply	other threads:[~2020-01-08 15:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 14:56 Laurent Hardy
2020-01-08  8:56 ` David Marchand
2020-01-08  9:09   ` Ferruh Yigit
2020-01-08  9:42     ` Olivier Matz
2020-01-08 12:12       ` Ferruh Yigit
2020-01-08 12:27         ` Olivier Matz
2020-01-08 14:08           ` Ferruh Yigit
2020-01-08 14:45             ` Laurent Hardy
2020-01-08  9:55     ` David Marchand
2020-01-08 10:31       ` Laurent Hardy
2020-01-08 12:59         ` Ferruh Yigit
2020-01-08 13:06           ` Thomas Monjalon
2020-01-08 13:20             ` Ferruh Yigit
2020-01-08 13:25               ` Thomas Monjalon
2020-01-08 13:34                 ` Thomas Monjalon
2020-01-08 13:53                   ` Ferruh Yigit
2020-01-08 13:52                 ` Ferruh Yigit
2020-01-08 14:01                   ` Ferruh Yigit
2020-01-08 14:15                   ` Andrew Rybchenko
2020-01-08 14:27                     ` Thomas Monjalon
2020-01-08 14:37                       ` Andrew Rybchenko
2020-01-08 13:58             ` Laurent Hardy
2020-01-08 14:07               ` Thomas Monjalon
2020-01-08 15:16                 ` Laurent Hardy [this message]
2020-05-08 12:03                 ` Ferruh Yigit
2020-05-08 12:11               ` Ferruh Yigit
2020-01-08 12:30       ` Ferruh Yigit
2020-01-08 13:00         ` David Marchand
2020-01-08 13:11           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba216d2c-69b5-9d33-8cab-a69c2ba48298@6wind.com \
    --to=laurent.hardy@6wind.com \
    --cc=arybchenko@solarflare.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).