From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7E26158CB; Mon, 27 Aug 2018 14:38:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2018 05:38:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,295,1531810800"; d="scan'208";a="68165168" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga007.jf.intel.com with ESMTP; 27 Aug 2018 05:38:00 -0700 To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org Cc: stable@dpdk.org References: <1535120736-785-1-git-send-email-alejandro.lucero@netronome.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Openpgp: preference=signencrypt Message-ID: <ba5919c7-bd56-9ffb-f644-c91c92c99385@intel.com> Date: Mon, 27 Aug 2018 13:37:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535120736-785-1-git-send-email-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/2] support MAC changes when no live changes allowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 27 Aug 2018 12:38:04 -0000 On 8/24/2018 3:25 PM, Alejandro Lucero wrote: > This is a patched to fix a functionality coming with the first public > release: changing/setting MAC address. > > The original patch assumes all NICs can safely change or set the MAC > in any case. However, this is not always true. NFP depends on the firmware > capabilities and this is not always supported. There are other NICs with > this same limitation, although, as far as I know, not in DPDK. Linux kernel > has a IFF_LIVE_ADDR_CHANGE flag and two NICs are checking this flag for > allowing or not live MAC changes. > > The flag proposed in this patch is just the opposite: advertise if live > change not supported and assuming it is supported other way. > > Although most NICs support rte_eth_dev_default_mac_addr_set and this > function returns and error when live change is not supported, note that > this function is invoked during port start but the value returned is not > checked. It is likely this is good enough for most of the cases, but > bonding is relying on this start then mac set/change, and a PMD ports is > not properly configured for being used as an slave port in some bonding > modes. > > v2: > - add RTE_ETH_DEV_NOLIVE_MAC_ADDR comment in rte_eth_dev_default_mac_addr_set doc > - add rte_eth_dev_start change in release API changes > > v3: > - merge doc API changes with first patch > - comment behaviour change in rte_eth_dev_start > - remove comment on rte_eth_dev_default_mac_addr_set Series applied to dpdk-next-net/master, thanks.