From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50A19A00BE; Tue, 3 May 2022 21:05:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 440A740E78; Tue, 3 May 2022 21:05:51 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2056.outbound.protection.outlook.com [40.107.237.56]) by mails.dpdk.org (Postfix) with ESMTP id 610CE40691 for ; Tue, 3 May 2022 21:05:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aar8Ms0+WR30sNmW9FuzKAx4BwAVzhsFNIGbO/0Xdg2X421g6hONuYtRE56yWY+20LbtMhEtLAz0tS9AwUMcYDjfypF3B85Pgm6DYRdLoLTXKS/xzdArfQMdKR9jLnb634CIkChsX2XnuN80M0ozSr/3Rgv9fGXzaJ86a0oq4bc2I+hJHPkKucX8lbT/+OB4YOlIqdFL5jVQsoGybx+/691Lc9LL6vrpD1lhZ1tSF3RzpPLMsRcnRAyz6LnpgC4nC33yrqlOl44lbqTeXmvXXE+bcKLpLzEqlzeN/Jbf61bntVHX39xNHo+zLSWqueUfV9h138TyS/qKI1FMCgTGSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqrxJjGryZm+WrgcpCtuh35AyTT6acxzhh4POi6bCYk=; b=AIr9Mc2XuKNB7bGnWT+lI5f5ZbPeswtouiMQr4CD6AqKEwo81z4x7rcbFnWlpx6ij7TZqSopTOU4KmrRyCFWMfl4I8fA83FoHBy2xAGsGVVQTgrW9Hvhi/X15kTLNdpK1jMjqn6JNepKt+nYSwSmUwED/pgvi0U4T1PxBUOvjXnRdZPwmew1hEHC8ketdK7LvTd2PmvhLBoT68dyI2O8OV3wf54DN2uFSYWZDbHl00QL5XG3k3UFpgQl0Q5+Hl04pSwMDilZCuxPNgxl7kEvriXnRb1l0qUZor53hz5JzWGU5wSXdvOFWQC9gNY3/Er2Fdz+c4zKiuAq5+zaEXhSnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jqrxJjGryZm+WrgcpCtuh35AyTT6acxzhh4POi6bCYk=; b=ft8RBXbqvEHPqBibkngz2VRxATX//2QCq3xZbEFFzZ3z+8Gm//tGTORAm39L0/iOFT7PSx2cL4mHs5i5SrweUwm1lKxPLvjFoZTg5lT1hUDU2CvL3O4Sjri0V5TpUYym23hgq7MgD0UlcON8OZGoczZN9WTJCoszLxaO8YQSdH0= Received: from BN9PR03CA0337.namprd03.prod.outlook.com (2603:10b6:408:f6::12) by DM6PR02MB5577.namprd02.prod.outlook.com (2603:10b6:5:33::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Tue, 3 May 2022 19:05:46 +0000 Received: from BN1NAM02FT031.eop-nam02.prod.protection.outlook.com (2603:10b6:408:f6:cafe::9) by BN9PR03CA0337.outlook.office365.com (2603:10b6:408:f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Tue, 3 May 2022 19:05:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT031.mail.protection.outlook.com (10.13.2.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 19:05:44 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 3 May 2022 20:05:44 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 3 May 2022 20:05:44 +0100 Envelope-to: humin29@huawei.com, dev@dpdk.org, thomas@monjalon.net Received: from [10.71.119.91] (port=53376) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nlxqB-0005cc-Tm; Tue, 03 May 2022 20:05:43 +0100 Message-ID: Date: Tue, 3 May 2022 20:05:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 3/7] net/hns3: fix pseudo-sharing between threads Content-Language: en-US To: "Min Hu (Connor)" , CC: References: <20220406092240.52900-1-humin29@huawei.com> <20220406092240.52900-4-humin29@huawei.com> From: Ferruh Yigit In-Reply-To: <20220406092240.52900-4-humin29@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d263ace3-e759-4c5d-a1dd-08da2d37ed09 X-MS-TrafficTypeDiagnostic: DM6PR02MB5577:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fx+UDG9rmTvAw/1GL9zFx+BN8CAdJRkXcr502ywiwvOgpAEf+2x4VsYRSouUYH5cPfJHzY4P4embEFNLE1YFd7KUWGMdJm+IC0VmImG6x7pzPoWMdCh9XzJKrWUmLDNlKW3RN8INs39lxBDn5dkzbUR95WBoaUcbMhl6PMlDlq4byf9+l/WqInbeAGfM0DDsv23lDCIR58Xd5/7/aKdLFNEwDT2hTnY5yi49/NwLg81afzSyfV0dcF4VSryYAUXNLlDofqcu9+xPhLEGDrVYpF2IcbAG8aepLBZy4PXSdne6xvi3vpH+lFbGIK6L/lPFrz2wisycHg5rNBrmUQVxvEtUCq81/R890+8jcqdnExnf9ZZycZveRKjCqJ8v0IqxkbN7qBu/lxAzGkuFupMGyUyY1jadNr6DR9HU+GMTLHe7VAIT6umSbR9MJ/Uv00yjk/+0JRAhQg9tNSmnA8ljaIIRiGZs1ZiUFcHYk5asRUoOh96EztG1iVdxmwTY0Z8WgT9X5WC3C/oc/btdQ5ARFsQhMbr+7RhOGTEk5uwKkEJn9NWDia8HXWlzCmnRPtG0sCEu7JcjsO6mxjXTyx3+T3rJNPL8cI9tdV4GEbt4NQ6MZeXuaxK1z55BkCYvcZlPj4icLLVha//TRkGWD6r2U4kZ9BEwZKOK7pPOg76HlqZjNxaWpzoIZxekquen5Z2lqwQNt+4CFGm9HjdxIDyHAOZFkeaRoUpy+VDI6V1xFrM= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(53546011)(186003)(82310400005)(31686004)(36756003)(110136005)(44832011)(316002)(336012)(26005)(426003)(47076005)(31696002)(2616005)(8936002)(508600001)(40460700003)(4326008)(8676002)(70206006)(70586007)(9786002)(7636003)(2906002)(5660300002)(356005)(83380400001)(4744005)(36860700001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 19:05:44.7910 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d263ace3-e759-4c5d-a1dd-08da2d37ed09 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT031.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5577 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/6/2022 10:22 AM, Min Hu (Connor) wrote: > From: Huisong Li > > Some fields in the end of 'struct hns3_rx_queue' and 'struct hns3_tx_queue' > are not accessed in the I/O path. But these fields may be accessed in other > threads, which may lead to the problem of pseudo-sharing of IO threads. ... problem of cache pseudo-sharing ... > This patch add a cacheline alignment to avoid it. > > Fixes: 9261fd3caf1f ("net/hns3: improve IO path data cache usage") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) <...>