DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>,
	Chas Williams <chas3@att.com>, Liang Zhang <zhangliang@bigo.sg>
Cc: dev@dpdk.org, Vadim Podovinnikov <podovinnikov@protei.ru>,
	stable@dpdk.org, Declan Doherty <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: fix LACP system address check
Date: Fri, 5 Mar 2021 09:21:28 +0000	[thread overview]
Message-ID: <baaa429b-ba6e-5ed9-dfbd-094cf6e941ce@intel.com> (raw)
In-Reply-To: <f72cad51-af29-e0d3-766c-6e7849824a94@huawei.com>

On 3/5/2021 1:43 AM, Min Hu (Connor) wrote:

> 在 2021/2/18 0:26, Ferruh Yigit 写道:
>> From: Vadim Podovinnikov <podovinnikov@protei.ru>
>>
>> In bond (LACP) we have several NICs (ports), when we have negotiation
>> with peer about what port we prefer, we send information about what
>> system we preferred in partner system name field. Peer also sends us
>> what partner system name it prefer.
>>
>> When we receive a message from it we must compare its preferred system
>> name with our system name, but not with our port mac address
>>
>> In my test I have several problems with that:
>> 1. If master port (mac address same as system address) shuts down (I
>>     have two ports) I loose connection
>> 2. If secondary port (mac address not same as system address) receives
>>     message before master port, my connection is not established.
>>
>> Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
 >
 > Acked-by: Min Hu (Connor) <humin29@huawei.com>
 >

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2021-03-05  9:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191125180323.E0B174C90@dpdk.org>
2019-11-26 11:55 ` [dpdk-dev] [PATCH v2] fix lacp check system address Vadim
2019-11-26 13:27   ` Ferruh Yigit
2019-11-26 15:09     ` podovinnikov
2020-04-10 10:15       ` Ferruh Yigit
2020-04-10 10:21         ` Ferruh Yigit
2020-04-10 10:24           ` Ferruh Yigit
2020-06-04  7:52             ` podovinnikov
2020-06-04 11:44               ` Ferruh Yigit
2021-02-17 16:26   ` [dpdk-dev] [PATCH v3] net/bonding: fix LACP system address check Ferruh Yigit
2021-02-17 16:30     ` Ferruh Yigit
2021-03-02 12:10       ` Ferruh Yigit
2021-03-05  1:43     ` Min Hu (Connor)
2021-03-05  9:21       ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=baaa429b-ba6e-5ed9-dfbd-094cf6e941ce@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=chas3@att.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=podovinnikov@protei.ru \
    --cc=stable@dpdk.org \
    --cc=zhangliang@bigo.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).