From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2A78A0562; Fri, 5 Mar 2021 10:21:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7114E40691; Fri, 5 Mar 2021 10:21:36 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 61FD940147; Fri, 5 Mar 2021 10:21:35 +0100 (CET) IronPort-SDR: 8BhjwJScBLP2vX/jdQAlirp74RpjBFap/5YniySg/7CbayCKydSMUDzTY+2qFDq2hLlef0r/41 /Qy/wnWB7bIQ== X-IronPort-AV: E=McAfee;i="6000,8403,9913"; a="174726044" X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="174726044" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2021 01:21:34 -0800 IronPort-SDR: OMdU/waoGmF0Bl2ZZvcXYXYjasBnHyzkHR0Nn05lA1DZCRN61H7BDeEo+l5IwcEYSx3C/LlNZN 6z9mzojXHjww== X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="446127855" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.100]) ([10.213.208.100]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2021 01:21:32 -0800 To: "Min Hu (Connor)" , Chas Williams , Liang Zhang Cc: dev@dpdk.org, Vadim Podovinnikov , stable@dpdk.org, Declan Doherty References: <20191126115508.11138-1-podovinnikov@protei.ru> <20210217162656.1983277-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 5 Mar 2021 09:21:28 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: fix LACP system address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/5/2021 1:43 AM, Min Hu (Connor) wrote: > 在 2021/2/18 0:26, Ferruh Yigit 写道: >> From: Vadim Podovinnikov >> >> In bond (LACP) we have several NICs (ports), when we have negotiation >> with peer about what port we prefer, we send information about what >> system we preferred in partner system name field. Peer also sends us >> what partner system name it prefer. >> >> When we receive a message from it we must compare its preferred system >> name with our system name, but not with our port mac address >> >> In my test I have several problems with that: >> 1. If master port (mac address same as system address) shuts down (I >>     have two ports) I loose connection >> 2. If secondary port (mac address not same as system address) receives >>     message before master port, my connection is not established. >> >> Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation") >> Cc: stable@dpdk.org >> >> Signed-off-by: Vadim Podovinnikov > > Acked-by: Min Hu (Connor) > Applied to dpdk-next-net/main, thanks.