From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0836A00C2; Wed, 2 Nov 2022 11:50:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6BC040693; Wed, 2 Nov 2022 11:50:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B8B8B40223 for ; Wed, 2 Nov 2022 11:50:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667386218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aJv/LQYkP7JMiJR/QW1vEBEjXwArx3SYboAIaw5PFfo=; b=MKp/lPW5vzKzkCKTRKiEaH5PuZ1CYXbmXXRSfNBFOHbVCulyfnWuqpbGPgJmicIan/RdPO Debx+yRB53lRj4uwYBpcD+oPkhBKZVPSOgehpj+5YL9Iw0vgS6Q/5bH/nkTZJWIfMqpv4d Va0ZeLtzNnOjEmMJaXIx/ydHrCvZCzo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-445-bum0DAu4OAaa98Djug9crQ-1; Wed, 02 Nov 2022 06:50:14 -0400 X-MC-Unique: bum0DAu4OAaa98Djug9crQ-1 Received: by mail-wr1-f71.google.com with SMTP id r4-20020adfbb04000000b00236639438e9so4734108wrg.11 for ; Wed, 02 Nov 2022 03:50:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aJv/LQYkP7JMiJR/QW1vEBEjXwArx3SYboAIaw5PFfo=; b=tYLMku8zbqllvudrxa1fu/zIBelKSVEaIm0VrCOhSvFS7Q5ZcJJc/ymAB1N86zH0u4 mYdNR2zE7iGAKN8G5RQchXoMmelekuaQ7guPV99PnhMlxw5bS03lXDct5sDoDmS4Fmlc FqdB20TNJrfq5LM0KuvuvlJfnFd2eCXNBYbXsjjJlVjON1XdFKZZhbLofg9tNYQu5R9o REkluuAQ3w9AvSa8djaXSsxkHsnHSo22VUKKl5YDWIWKVG8gBpZUTn01F3F4TqmYD5c4 6G4FmYTl1/Skp2uRS+JZ1pmS+ZW/95ZiyOXXsP+h9031dhoPQyitBkwCF6IFRGuwOqWJ RAmQ== X-Gm-Message-State: ACrzQf0DRRAW8u/lMOxe6R+hFZai6K08IsCJ29M+ijnMrRwphR1YupiN L2s9JOFF8Rvqd9EnxGjQaafyTVeTaWMfapjByaIx7DFpcdYuQZbilMjlarITbhS0ZsRNfZ6qyCZ 7Rzw= X-Received: by 2002:adf:dc82:0:b0:236:e2b2:6f01 with SMTP id r2-20020adfdc82000000b00236e2b26f01mr5715263wrj.358.1667386213326; Wed, 02 Nov 2022 03:50:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6GEN+wYyiHAIOeoqo/sT2s6EYSsNVFcIxVIopMHU9kCjJVEG7h9oQBhDSZGqwKMUKEhoAXmw== X-Received: by 2002:adf:dc82:0:b0:236:e2b2:6f01 with SMTP id r2-20020adfdc82000000b00236e2b26f01mr5715252wrj.358.1667386213070; Wed, 02 Nov 2022 03:50:13 -0700 (PDT) Received: from [192.168.0.36] ([78.17.179.245]) by smtp.gmail.com with ESMTPSA id t6-20020a5d6906000000b002322bff5b3bsm3504157wru.54.2022.11.02.03.50.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 03:50:12 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 10:50:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: Volodymyr Fialko , dev@dpdk.org, Akhil Goyal , Fan Zhang , Ravi Kumar , Ali Alnubani Cc: jerinj@marvell.com, anoobj@marvell.com References: <20220915082635.418873-1-vfialko@marvell.com> From: Kevin Traynor Subject: Re: [PATCH] cryptodev: add missing algorithm strings In-Reply-To: <20220915082635.418873-1-vfialko@marvell.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 15/09/2022 09:26, Volodymyr Fialko wrote: > SHA3 family algorithms were missing in the array of algorithm strings. > > Fixes: 1df800f89518 ("crypto/ccp: support SHA3 family") > > Signed-off-by: Volodymyr Fialko > --- > lib/cryptodev/rte_cryptodev.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c > index 42f3221052..35661f5347 100644 > --- a/lib/cryptodev/rte_cryptodev.c > +++ b/lib/cryptodev/rte_cryptodev.c > @@ -130,6 +130,15 @@ rte_crypto_auth_algorithm_strings[] = { > [RTE_CRYPTO_AUTH_SHA512] = "sha2-512", > [RTE_CRYPTO_AUTH_SHA512_HMAC] = "sha2-512-hmac", > > + [RTE_CRYPTO_AUTH_SHA3_224] = "sha3-224", > + [RTE_CRYPTO_AUTH_SHA3_224_HMAC] = "sha3-224-hmac", > + [RTE_CRYPTO_AUTH_SHA3_256] = "sha3-256", > + [RTE_CRYPTO_AUTH_SHA3_256_HMAC] = "sha3-256-hmac", > + [RTE_CRYPTO_AUTH_SHA3_384] = "sha3-384", > + [RTE_CRYPTO_AUTH_SHA3_384_HMAC] = "sha3-384-hmac", > + [RTE_CRYPTO_AUTH_SHA3_512] = "sha3-512", > + [RTE_CRYPTO_AUTH_SHA3_512_HMAC] = "sha3-512-hmac", > + > [RTE_CRYPTO_AUTH_KASUMI_F9] = "kasumi-f9", > [RTE_CRYPTO_AUTH_SNOW3G_UIA2] = "snow3g-uia2", > [RTE_CRYPTO_AUTH_ZUC_EIA3] = "zuc-eia3" This is being flagged as an ABI break for 21.11.3 [1]. I don't see it mentioned in the commit message or discussed, is it ok for main branch? Thanks to Ali for reporting. I will revert on 21.11 branch. [1] 1 Changed variable: [C] 'const char* rte_crypto_auth_algorithm_strings[]' was changed at rte_crypto_sym.h:372:1: size of symbol changed from 168 to 232 Error: ABI issue reported for 'abidiff --suppr dpdk/devtools/libabigail.abignore --no-added-syms --headers-dir1 /opt/dpdklab/abi_references/v21.11/armgigabyteref/include --headers-dir2 build_install/include /opt/dpdklab/abi_references/v21.11/armgigabyteref/dump/librte_cryptodev.dump build_install/dump/librte_cryptodev.dump'