From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43BAA4594E; Tue, 10 Sep 2024 04:26:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3D864021F; Tue, 10 Sep 2024 04:26:33 +0200 (CEST) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 729E240151 for ; Tue, 10 Sep 2024 04:26:32 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4X2ncn5z1nz1S9yJ; Tue, 10 Sep 2024 10:26:01 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 09CA31401F0; Tue, 10 Sep 2024 10:26:30 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 10 Sep 2024 10:26:29 +0800 Subject: Re: [PATCH v9 2/2] examples/l3fwd-power: add PM QoS configuration To: Huisong Li , CC: , , , , , , , , References: <20240320105529.5626-1-lihuisong@huawei.com> <20240809095012.16717-1-lihuisong@huawei.com> <20240809095012.16717-3-lihuisong@huawei.com> From: fengchengwen Message-ID: Date: Tue, 10 Sep 2024 10:26:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20240809095012.16717-3-lihuisong@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Huisong, On 2024/8/9 17:50, Huisong Li wrote: > Add PM QoS configuration to declease the delay after sleep in case of > entering deeper idle state. > > Signed-off-by: Huisong Li > Acked-by: Morten Brørup > --- > examples/l3fwd-power/main.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index 2bb6b092c3..9b386c3710 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -47,6 +47,7 @@ > #include > #include > #include > +#include > > #include "perf_core.h" > #include "main.h" > @@ -2260,6 +2261,22 @@ init_power_library(void) > return -1; > } > } > + > + RTE_LCORE_FOREACH(lcore_id) { > + /* > + * Set the worker lcore's to have strict latency limit to allow > + * the CPU to enter the shallowest idle state. > + */ > + ret = rte_power_qos_set_cpu_resume_latency(lcore_id, > + RTE_POWER_QOS_STRICT_LATENCY_VALUE); > + if (ret < 0) { > + RTE_LOG(ERR, L3FWD_POWER, > + "Failed to set strict resume latency on CPU%u.\n", suggest on core%u and use if (ret != 0) and how about use warning, if current system don't support it, we just give a warning message but let's it continue. > + lcore_id); > + return ret; > + } > + } > + > return ret; > } > > @@ -2299,6 +2316,13 @@ deinit_power_library(void) > } > } > } > + > + RTE_LCORE_FOREACH(lcore_id) { > + /* Restore the original value in kernel. */ > + rte_power_qos_set_cpu_resume_latency(lcore_id, > + RTE_POWER_QOS_RESUME_LATENCY_NO_CONSTRAINT); > + } > + > return ret; > } > >