From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E612045B07;
	Fri, 11 Oct 2024 13:50:36 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8D27F4028E;
	Fri, 11 Oct 2024 13:50:36 +0200 (CEST)
Received: from office2.cesnet.cz (office2.cesnet.cz [78.128.248.237])
 by mails.dpdk.org (Postfix) with ESMTP id 19F7F4025F
 for <dev@dpdk.org>; Fri, 11 Oct 2024 13:50:35 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz;
 s=office2-2020; t=1728647434;
 bh=TgnFgV0cdZISBfW0Nes0FX5wBdnw9clf265octPT444=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References;
 b=jwCRBMO7+ejwOIQ9kIp055unyxZizkVJ4R7lh6HWnSxzi6wLcxSd18CCCifwOlKK6
 9U5VRX5K5nKs+8A6f/oAW6/U7T8zOWuC8CGVjguSc6cgHssfM5XcoUfT8F9Ood2xyM
 XYXPNKNxRI2VohPLs9KQlb/wLFXIQeAM7uueK4i0lKQhgtkGG+ANFP5p9OxVxBpzgD
 Db6L/WzqBWHKIatZcYHK/zv6mFzzaMSd0vQ9ZpBOaADEq2iDOvrOuWi8YJOszdI3r7
 JoS7sCgoVod0JjBzNzIJC15PIkwyTTrgz1lHeLym2XpY1SqpJOmz1Wx1ZLZvmSRsX+
 tql3yoyugPdmA==
Received: from [IPv6:2001:718:812:27::107] (gtx107.cesnet.cz
 [IPv6:2001:718:812:27::107])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits)
 server-digest SHA256) (No client certificate requested)
 by office2.cesnet.cz (Postfix) with ESMTPSA id D1EE2118007E;
 Fri, 11 Oct 2024 13:50:33 +0200 (CEST)
Message-ID: <baf4eadc78a1cca2f45d969a45c193f32dcf3381.camel@cesnet.cz>
Subject: Re: [PATCH] net/nfb: fix use after free
From: Martin Spinler <spinler@cesnet.cz>
To: David Marchand <david.marchand@redhat.com>, Thomas Monjalon
 <thomas@monjalon.net>
Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>, Morten
 =?ISO-8859-1?Q?Br=F8rup?=	 <mb@smartsharesystems.com>, Stephen Hemminger
 <stephen@networkplumber.org>,  Chengwen Feng <fengchengwen@huawei.com>,
 Wathsala Vithanage <wathsala.vithanage@arm.com>
Date: Fri, 11 Oct 2024 13:50:33 +0200
In-Reply-To: <CAJFAV8z04AWci67nHWXv=qG6_oj53njHqkjNVy1qvdmfG8WWog@mail.gmail.com>
References: <20241010171547.2510123-1-thomas@monjalon.net>
 <CAJFAV8z04AWci67nHWXv=qG6_oj53njHqkjNVy1qvdmfG8WWog@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.54.0 
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, 2024-10-10 at 19:17 +0200, David Marchand wrote:
> On Thu, Oct 10, 2024 at 7:16=E2=80=AFPM Thomas Monjalon <thomas@monjalon.=
net> wrote:
> >=20
> > With the annotations added to the allocation functions,
> > more issues are detected at compilation time:
> >=20
> > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free'
> >=20
> > It is fixed by moving the assignment before freeing the parent pointer.
> >=20
> > Fixes: 80da7efbb4c4 ("eal: annotate allocation functions")
> >=20
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>=20
>=20
Acked-by: Martin Spinler <spinler@cesnet.cz>