From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 7E2481041 for ; Wed, 12 Sep 2018 11:12:55 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C3ED402333A; Wed, 12 Sep 2018 09:12:55 +0000 (UTC) Received: from [10.36.112.35] (ovpn-112-35.ams2.redhat.com [10.36.112.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37F5B202706C; Wed, 12 Sep 2018 09:12:51 +0000 (UTC) To: Jens Freimann , dev@dpdk.org Cc: tiwei.bie@intel.com References: <20180906181947.20646-1-jfreimann@redhat.com> <20180906181947.20646-5-jfreimann@redhat.com> From: Maxime Coquelin Message-ID: Date: Wed, 12 Sep 2018 11:12:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180906181947.20646-5-jfreimann@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 12 Sep 2018 09:12:55 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 12 Sep 2018 09:12:55 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v5 04/11] net/virtio: flush packed receive virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 09:12:55 -0000 On 09/06/2018 08:19 PM, Jens Freimann wrote: > Flush used descriptors in packed receive virtqueue. As descriptors > can be chained we need to look at the stored number of used descriptors > to find out the length of the chain. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtqueue.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c > index 56a77cc71..d0520dad1 100644 > --- a/drivers/net/virtio/virtqueue.c > +++ b/drivers/net/virtio/virtqueue.c > @@ -58,12 +58,29 @@ virtqueue_detach_unused(struct virtqueue *vq) > void > virtqueue_rxvq_flush(struct virtqueue *vq) > { > + struct vring_desc_packed *descs = vq->vq_ring.desc_packed; > struct virtnet_rx *rxq = &vq->rxq; > struct virtio_hw *hw = vq->hw; > struct vring_used_elem *uep; > struct vq_desc_extra *dxp; > uint16_t used_idx, desc_idx; > uint16_t nb_used, i; > + uint16_t size = vq->vq_nentries; > + > + if (vtpci_packed_queue(vq->hw)) { > + i = vq->vq_used_cons_idx; > + while (desc_is_used(&descs[i], &vq->vq_ring) && > + i < vq->vq_nentries) { It may be preferable to ensure 'i' is within the ring size before using it in desc_is_used(). And raise (at least) an error message if it isn't. > + dxp = &vq->vq_descx[i]; > + if (dxp->cookie != NULL) > + rte_pktmbuf_free(dxp->cookie); > + vq->vq_free_cnt += dxp->ndescs; > + i = i + dxp->ndescs; > + i = i >= size ? i - size : i; > + dxp->ndescs = 0; > + } > + return; > + } > > nb_used = VIRTQUEUE_NUSED(vq); > >