From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B3C7423A4; Tue, 10 Jan 2023 14:56:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73A7042D20; Tue, 10 Jan 2023 14:56:31 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2081.outbound.protection.outlook.com [40.107.102.81]) by mails.dpdk.org (Postfix) with ESMTP id 06E0D42D21 for ; Tue, 10 Jan 2023 14:56:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vbghq49+XmRPoxM9XWi0bfskkC9yLMSHC5BDKPWe4FcT0r1NjwqRSkHrc6UyyF+eU0Jb2WIo8DlxD07TAj0ccCYhQw9yw0/vnxGzBC+cGPzQOzTsXr5KBcd+BwugBKJmmzGgvs6d8MLvWDas19k9A+XJ3f9Q5mUkHtloWD28KYn5BSGqLsVYCuYTV2oUPjpT8AcQzpuFSBawt59vkchR6aA+WLtrggK4xwfc9P9HiehsLYhcTCoqG6Zr6bumJIYH+Tl1db+Hv7SDsmrEZT6CWZBSVKpt7Zwe8SlmnEw8XOXSempFaXK08+otdRef/p1hLMQjfaLB6jS+AXhoF7uuvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+/6AJ7nPNP4xoLMq2E55w9BZ4TcQxqzZWwDaNnM1ySI=; b=hbMaampmrFom8hqSRDaz1bzhgsq6YwmeduIcqxxzEKJxb6WNKp8TXjS88iW4RmKxTpwDRqqg2bWdUTqaiKENnT7xxyyQfK6TSaUVOX2o3HynnhhcSLnbqrwarxYeogvZsB3Ce3v/gEohfm5N3D/261TVnc6MDh2ushKs9JCiAiOOSwebl1RGoAhwnZvZi+STKUqhJDI3rTUU85zduTUX8jGzGhD+sTD8s6yDIOZar5uhbHwJz9ETLfxXoyCpqtgpDyK3TULLjNvApQO+NSbnd8UEVejC2Gx1x5OEMG/4ea6DXr5I5+86E7sGnpSyDe0oi56oGP/bXcuS5g2OCtrfHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+/6AJ7nPNP4xoLMq2E55w9BZ4TcQxqzZWwDaNnM1ySI=; b=wq/uoqXTFTJ5BpvULGq17f3uPBfEshLeKLp01UyxjkKr5nlV4J1S6Yu5LGHPAnYZNi/tVzTUS+oxB7UcorOT802XzdmEtj2Zn2Dt0Qyv6sAhFsIBAZxAbiw39iiNI2z28S5zq+j7HIvFXrwIMP8uN+BOhSbzIwli3+Sdatdo0gQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB6354.namprd12.prod.outlook.com (2603:10b6:208:3e2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 13:56:28 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%9]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 13:56:28 +0000 Message-ID: Date: Tue, 10 Jan 2023 13:56:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Tyler Retzlaff , dev@dpdk.org Cc: thomas@monjalon.net, mb@smartsharesystems.com, bruce.richardson@intel.com References: <1669246997-30592-1-git-send-email-roretzla@linux.microsoft.com> <1673285784-14394-1-git-send-email-roretzla@linux.microsoft.com> From: Ferruh Yigit Subject: Re: [PATCH v4 0/2] eal: provide leading and trailing zero bit count abstraction In-Reply-To: <1673285784-14394-1-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0109.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6354:EE_ X-MS-Office365-Filtering-Correlation-Id: cc442ac7-4c4e-409f-c494-08daf312783a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bAsqzlJZW/FyRXAldVObiZ9BiGGxU1knOs9+/3J240M/1bOidbwNqL2U2cpOzVCHJEvn8rVBxhaAdS/SmuxHDhxv+suRNyH47ZiXM1FPjN32ZVVAqyhej1J00WMPLlBTwBrN5SHQLShezLJNQo94Iu6pcEjFHgd74gpCnW0CB798FWFHTvCI/c25Tb77M7jJmkAdqO9WS8TjGbwXqRFSJl7FRxXiz8hcfJ28W5Q3ivKs7Qqbzlqwq0qzAzaPP9/le3GMRvZKmtbgRXjcsH91yfPMhqqxbBsuP482r/+rbOuOuSFZO3XaL2p9PBz+XEaQFW99id4t+cH6OtgVWOKmgMSTM3dZVuCToZBOHCqWYayWTiM9h4uZK2liIPWXbaJf/CpszsAOxAfrdMFjWC7bl73jCQo88lcLf/uq6wb7EX1k5eJT8DduFkltJXf5wMYxHzRzxTVI29DgDQZOGJIfASh5UGB4ntNo3c9yzgx/kDnYfR2Z4o9wlRJXiRsg6tf4hzbH2j+kDKjy20zUkp4WqtUBQlpgz5xT7bYvpgFBLsvOI4WXdSc1xIUI2sJAoFqq8BvG2sdL0RJWOqoQvqROHeqCyuVW/9T06NS+XXgo8AHKQQDmxnWhM57d0UD+5rGcMNGLBxY7JYp/zP9Fi148I8CKkN1S6EEjnLTRC3KabDstODmdk3Pv/Eknm7+qMIkLkhO1Ca5G0UctMBfoKGtPAwJOJ6ab7AIvkEeScFsP6+k= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(451199015)(44832011)(2906002)(83380400001)(2616005)(66476007)(66556008)(5660300002)(66946007)(6666004)(53546011)(8936002)(26005)(186003)(36756003)(6506007)(6512007)(31686004)(478600001)(38100700002)(6486002)(8676002)(41300700001)(86362001)(4326008)(45080400002)(316002)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXlObm5XL0hRTGthbkE3QU53N0xPbnU4NU9UTDJYT1R2a2Y1ZHNJZy81SW8r?= =?utf-8?B?MkdNWk9GYXVlZFNhNDk2RWNXVGcwUG81RDh2OHQ5M1YvUHJ2LzVmcTBmTk9s?= =?utf-8?B?bkdMeENzVWtyaFhYR3o5QmtvdkhjRUFxM2M3VVNGajBCaUh5RjROcktXZW9D?= =?utf-8?B?eDFqZmNiSDBVNlhRNWEyOFlERjRSMlFWUElYMzZjZm14d3VReFo3RndFZ2E5?= =?utf-8?B?V04va0NvQmIyWEJiam92bkkrd285Mi80MlZwQUs4U1gyQk5sMG93c3FDT0tW?= =?utf-8?B?YWxJUE9xOVloVUxNK1VleTFQZWdjS3ZsR1J1aW9UVWtqcGRkcGdLMEg5SmVk?= =?utf-8?B?aW8yQkxzUHVKUXArbzllZWg5RFFNWFB1TWsyZXMxbHg0dnZJYnZaUDVNbWRm?= =?utf-8?B?eHdOZmMxM00vVEZEK3hzTHJQMnAvcnY0ZkVUOERFL3IxaFVDQ1EvNXBvbHF1?= =?utf-8?B?bzRDWVg2cGdTZmo2bkJMcXhGbk1BNndlNEQ2T1k5RWtqeHYwcVdPVCtFdHY0?= =?utf-8?B?b21VOGV5Y1I2ZDZNejk0U2tScVhKcGpLd0ZTQmdNRnRkcFZDcjdxaFpJVzNP?= =?utf-8?B?YjRvUGg1S2R0eHNMOG9iUjJGamxSU0VZcnQ1YXBqZDhxVmI1c3BTaWNEK0F2?= =?utf-8?B?TXZ2R0w4NnQ3ZzhpMVBaWWtScjluSmxzSExwb3pLeC9ONnJtVHI0V2d2NjZZ?= =?utf-8?B?ZkVsbWJZVFJEQXB5Rm1JdXdnMzdVdlhXZzVQWGJlRVp6SytWc3ozQUI0L0xC?= =?utf-8?B?ZUgzOGthaER1aGpTMWtwVWY1MmNBVmxTNUZXRGN2MitTVnhIYjJFSlBxSHlW?= =?utf-8?B?aXVqVHVteGd5cUFuWXBZMHo4MENtbHIwZWY0QzJUbFllcWQyTVEyK0lMdVlx?= =?utf-8?B?QkVVNEdVbllWRmx3OGNmWkcydUJxb2JJWlBIMEFPNlhTaTZ6NnYzY3JwVDlS?= =?utf-8?B?eUJnaFU0NlJ3aE53Zzdjb1JZWjdRMW41cGN1QVdJSmM0QnBLUWp6YVIxS0Ux?= =?utf-8?B?YjVTMGdtNGFNWFZiVURKVXFDc0pjNUU3cGxST0NQUE9IUzNrNG9GNGRvRTA4?= =?utf-8?B?Q1ppRFpVVVgybm1XSFMyaUFBejVvVkpHZG14c0pFU2dhQ01mRGUxbTRjUXZ5?= =?utf-8?B?WjAxM1IwZ1dJZE8rNmY1T0k5SWMyWjNYUkU1TVhoVVJTVmdZMWF4WjRKclFz?= =?utf-8?B?RVhNN0U5d21LMHZqL0J5QnlHcm1sQ3Z6Z3h4enZtRDdGT0F2aEEwWGlYWjM2?= =?utf-8?B?cnZMbXBGdUEycURFWU9iM3dCbU04U0Z6Vm5pZjRMRkJZNmZYd0dLTnpyaklL?= =?utf-8?B?UmlBelRFbkNib0JydGlsU3A4N1J3cGIzdGJRRXZGMnBSczZmV1ZCYlU5UGw3?= =?utf-8?B?QUV3eUZVemR6U25ZdmZhSGJpNDI5eUVzL3E5cHNudW9IaWF6N0J5Z1lCQjBS?= =?utf-8?B?bENiNjZZcmVESUZWd04yS3NxbnJoTENpWHlLQTNGcUtBbHFPZE1EZVAxbGF6?= =?utf-8?B?UlhaWGxWSmZNQVJHb2lxdnZZbHI2THpINnZWWnZnLzhTKzl3R2Z1NDZycVpX?= =?utf-8?B?YkJPTTY3Zy9HRlAwZE5UVjZyek5rUXkzMmZGZGN6V0cxN0JTUThralVTY2dl?= =?utf-8?B?VTlDUUVlLzVnZ252YU9TZUFVTWErcGo3QlBOMEpKc1hJVlBsR3Z5UHQycURM?= =?utf-8?B?TUZNbVpWNE94OVd4YWxrSjI4R0cwK3lLVHVPN1pnMHhyY1ZNNTJ5VkFxeVEv?= =?utf-8?B?VEo3TWw1UzJwTlhxVTdzRGFYQjdhTTB4aG5oRHJFZVR6YkM0TGxyWHQwN2ts?= =?utf-8?B?d3UwVzhORnhsRVA0VldqOG9oOWt5K3dZbmd3VWhHQmh5SFlpaWZHWUpVR0NS?= =?utf-8?B?d1BNQnZQVE1XV0l3VC8xYytUQndXUGRpSFdvTWVmTks5K1ZSc09QWDhuajVC?= =?utf-8?B?M1lMdENIbXg3Yk5WOTJpL292UzFyUXlCZmRxMjhKODBsdUx3YXR6QXYvTjMz?= =?utf-8?B?aFc1SnRmY1ExSzdTcnA3Tk1aVWZXVHJYUUlBSWVqZVRnMEloMW5TVllCN25p?= =?utf-8?B?eHJTb2V6RTdmMGZwVTQ1UmMyTGo3THFpclRDbkQ2aG56TXBpQTdWZEhDU0xq?= =?utf-8?Q?u9ETi6nWh5J6xJMvQ0L+F0UN2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc442ac7-4c4e-409f-c494-08daf312783a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 13:56:28.0143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZK9/9tXj0ir+67KdhUT7vxEZ1qo/gmJzdP3NKdnjRPFxPVe4p6UoVsre7TTeM1nb X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6354 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/9/2023 5:36 PM, Tyler Retzlaff wrote: > Move existing bit manipulation, log and npow functions from > rte_common.h to rte_bitops.h > > Provide leading and trailing zero bit count functions to abstract away > compiler specific implementations. > > Include basic unit test for new leading/trailing zero bit count functions. > > v4: > * combine unit test commit into function addition commit > > v3: > * rename to use 32/64 instead of l/ll suffixes > * add new functions to rte_bitops.h instead of new header > * move other bit functions from rte_common.h to rte_bitops.h > > v2: > * use unsigned int instead of unsigned (checkpatches) > * match multiple include guard naming convention to rte_common.h > * add explicit extern "C" linkage to rte_bitcount.h > note: not really needed but checkpatches required > * add missing space around '-' > > Tyler Retzlaff (2): > eal: move bit operation functions from common to bitops header > eal: provide leading and trailing zero bit count abstraction > There are checkpatch / checkgitlog errors, can you please check them: - checkpatches: ### [PATCH] eal: provide leading and trailing zero bit count abstraction WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Tyler Retzlaff ' != 'Signed-off-by: Tyler Retzlaff ' total: 0 errors, 1 warnings, 264 lines checked 1/2 valid patch - check-git-log: Headline too long: eal: move bit operation functions from common to bitops header