From: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH v3 00/11] rework thread management
Date: Sun, 17 Sep 2023 13:26:05 +0100 [thread overview]
Message-ID: <bb1be508-1374-dd93-e4af-a14eec0ebd44@yandex.ru> (raw)
In-Reply-To: <20230913114351.1940459-1-thomas@monjalon.net>
13/09/2023 12:28, Thomas Monjalon пишет:
> The main effect of this patch series is to
> remove calls to pthread functions except for pthread_cancel and locks.
>
> The function rte_thread_create_control() does not take thread attributes
> settings anymore as it looks a useless complication of the API.
> Then the rte_thread API is made stable,
> so we can remove the old deprecated functions
> rte_thread_setname() and rte_ctrl_thread_create().
>
> Some new internal functions are added in rte_thread to make sure
> all internal thread names are prefixed with "dpdk-".
>
> Few other cleanups are done.
>
> Future work about pthread portability are about:
> - cancel
> - mutex
>
> ---
>
> v2 changes:
> - replace (|_) with _? in checkpatch
> - simplify thread name size doc
> - build time check of internal thread name size
> - clean control thread params struct
> v3 change:
> - fix build (wrong placement of RTE_BUILD_BUG_ON)
> note for later: never send a patch during a summit!
>
>
> Thomas Monjalon (11):
> devtools: warn when adding some pthread calls
> eal: rename thread name length definition
> eal: remove attributes from control thread creation
> eal: promote thread API as stable
> eal: force prefix for internal threads
> lib: convert to internal control threads
> drivers: convert to internal control threads
> examples: convert to normal control threads
> test: convert threads creation
> eal: remove deprecated thread functions
> lib: remove pthread.h from includes
>
> app/test/process.h | 10 +-
> app/test/test_lcores.c | 9 +-
> app/test/test_link_bonding.c | 2 +
> app/test/test_pdump.c | 6 +-
> app/test/test_pdump.h | 2 +-
> app/test/test_threads.c | 2 +-
> devtools/checkpatches.sh | 16 +++
> .../prog_guide/env_abstraction_layer.rst | 2 +-
> doc/guides/rel_notes/deprecation.rst | 5 -
> doc/guides/rel_notes/release_23_11.rst | 6 +
> drivers/common/cnxk/roc_dev.c | 16 +--
> drivers/common/cnxk/roc_dev_priv.h | 2 +-
> drivers/common/cnxk/roc_nix_inl_dev.c | 9 +-
> drivers/common/cnxk/roc_nix_inl_priv.h | 2 +-
> drivers/common/cnxk/roc_platform.h | 3 +-
> drivers/common/mlx5/mlx5_common.c | 1 +
> drivers/common/mlx5/windows/mlx5_win_ext.h | 2 +
> drivers/dma/skeleton/skeleton_dmadev.c | 8 +-
> drivers/event/dlb2/pf/base/dlb2_osdep.h | 14 +-
> drivers/event/dlb2/pf/base/dlb2_resource.c | 39 +++---
> drivers/event/dlb2/pf/dlb2_main.h | 1 -
> drivers/net/ark/ark_ethdev.c | 11 +-
> drivers/net/ark/ark_pktgen.c | 8 +-
> drivers/net/ark/ark_pktgen.h | 2 +-
> drivers/net/bnxt/bnxt.h | 1 +
> drivers/net/iavf/iavf_vchnl.c | 4 +-
> drivers/net/ice/ice_dcf_parent.c | 7 +-
> drivers/net/ipn3ke/ipn3ke_representor.c | 17 ++-
> drivers/net/ixgbe/ixgbe_ethdev.c | 8 +-
> drivers/net/mlx5/mlx5.h | 2 +-
> drivers/net/mlx5/mlx5_hws_cnt.c | 42 +++---
> drivers/net/qede/base/bcm_osal.h | 1 +
> drivers/net/sfc/sfc_mae.h | 2 +-
> drivers/net/sfc/sfc_mae_counter.c | 11 +-
> drivers/net/txgbe/txgbe_ethdev.c | 6 +-
> drivers/raw/ifpga/base/opae_osdep.h | 1 +
> drivers/raw/ifpga/ifpga_rawdev.c | 19 ++-
> drivers/vdpa/ifc/ifcvf_vdpa.c | 86 ++++++------
> drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +-
> drivers/vdpa/mlx5/mlx5_vdpa.h | 10 +-
> drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 70 +++-------
> drivers/vdpa/mlx5/mlx5_vdpa_event.c | 64 +++------
> drivers/vdpa/sfc/sfc_vdpa.c | 1 +
> drivers/vdpa/sfc/sfc_vdpa_ops.c | 15 +-
> drivers/vdpa/sfc/sfc_vdpa_ops.h | 3 +-
> examples/vhost/main.c | 9 +-
> examples/vhost_blk/vhost_blk.c | 21 +--
> lib/eal/common/eal_common_options.c | 1 +
> lib/eal/common/eal_common_proc.c | 15 +-
> lib/eal/common/eal_common_thread.c | 131 +++++++-----------
> lib/eal/common/eal_common_trace.c | 1 +
> lib/eal/common/malloc_mp.c | 1 +
> lib/eal/freebsd/eal.c | 2 +-
> lib/eal/freebsd/eal_alarm.c | 1 +
> lib/eal/freebsd/eal_interrupts.c | 10 +-
> lib/eal/freebsd/eal_thread.c | 9 +-
> lib/eal/include/rte_eal.h | 3 -
> lib/eal/include/rte_lcore.h | 42 ------
> lib/eal/include/rte_per_lcore.h | 2 -
> lib/eal/include/rte_thread.h | 131 +++++++++---------
> lib/eal/linux/eal.c | 2 +-
> lib/eal/linux/eal_alarm.c | 1 +
> lib/eal/linux/eal_interrupts.c | 10 +-
> lib/eal/linux/eal_thread.c | 18 +--
> lib/eal/linux/eal_timer.c | 11 +-
> lib/eal/unix/rte_thread.c | 2 +-
> lib/eal/version.map | 44 +++---
> lib/eal/windows/eal.c | 2 +-
> lib/eal/windows/eal_interrupts.c | 2 +-
> lib/eal/windows/eal_thread.c | 8 --
> lib/eal/windows/rte_thread.c | 2 +-
> lib/ethdev/ethdev_driver.c | 1 +
> lib/ethdev/ethdev_driver.h | 2 +
> lib/ethdev/rte_ethdev_core.h | 2 -
> lib/ethdev/rte_flow.c | 1 +
> lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++--
> lib/vhost/fd_man.c | 6 +-
> lib/vhost/fd_man.h | 2 +-
> lib/vhost/socket.c | 23 ++-
> lib/vhost/vduse.c | 5 +-
> lib/vhost/vhost.c | 1 +
> 81 files changed, 466 insertions(+), 632 deletions(-)
>
Series-acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
next prev parent reply other threads:[~2023-09-17 12:26 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 16:12 [PATCH " Thomas Monjalon
2023-09-06 16:12 ` [PATCH 01/11] devtools: warn when adding some pthread calls Thomas Monjalon
2023-09-07 8:20 ` David Marchand
2023-09-06 16:12 ` [PATCH 02/11] eal: rename thread name length definition Thomas Monjalon
2023-09-08 4:00 ` Tyler Retzlaff
2023-09-06 16:12 ` [PATCH 03/11] eal: remove attributes from control thread creation Thomas Monjalon
2023-09-08 4:02 ` Tyler Retzlaff
2023-09-06 16:12 ` [PATCH 04/11] eal: promote thread API as stable Thomas Monjalon
2023-09-08 4:04 ` Tyler Retzlaff
2023-09-06 16:12 ` [PATCH 05/11] eal: force prefix for internal threads Thomas Monjalon
2023-09-07 8:28 ` David Marchand
2023-09-07 8:50 ` Morten Brørup
2023-09-07 8:53 ` David Marchand
2023-09-07 8:55 ` David Marchand
2023-09-07 11:10 ` Morten Brørup
2023-09-11 16:26 ` Thomas Monjalon
2023-09-11 21:32 ` Morten Brørup
2023-09-06 16:12 ` [PATCH 06/11] lib: convert to internal control threads Thomas Monjalon
2023-09-06 16:12 ` [PATCH 07/11] drivers: " Thomas Monjalon
2023-09-11 13:35 ` Andrew Rybchenko
2023-09-06 16:12 ` [PATCH 08/11] examples: convert to normal " Thomas Monjalon
2023-09-08 4:10 ` Tyler Retzlaff
2023-09-06 16:12 ` [PATCH 09/11] test: convert threads creation Thomas Monjalon
2023-09-08 4:12 ` Tyler Retzlaff
2023-09-06 16:12 ` [PATCH 10/11] eal: remove deprecated thread functions Thomas Monjalon
2023-09-08 4:22 ` Tyler Retzlaff
2023-09-11 16:13 ` Thomas Monjalon
2023-09-12 0:49 ` Tyler Retzlaff
2023-09-06 16:12 ` [PATCH 11/11] lib: remove pthread.h from includes Thomas Monjalon
2023-09-08 4:25 ` Tyler Retzlaff
2023-09-08 4:49 ` Ajit Khaparde
2023-09-10 2:55 ` Xu, Rosen
2023-09-07 8:30 ` [PATCH 00/11] rework thread management Morten Brørup
2023-09-08 4:26 ` Tyler Retzlaff
2023-09-13 10:34 ` [PATCH v2 " Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 01/11] devtools: warn when adding some pthread calls Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 02/11] eal: rename thread name length definition Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 03/11] eal: remove attributes from control thread creation Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 04/11] eal: promote thread API as stable Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 05/11] eal: force prefix for internal threads Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 06/11] lib: convert to internal control threads Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 07/11] drivers: " Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 08/11] examples: convert to normal " Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 09/11] test: convert threads creation Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 10/11] eal: remove deprecated thread functions Thomas Monjalon
2023-09-13 10:34 ` [PATCH v2 11/11] lib: remove pthread.h from includes Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 00/11] rework thread management Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 01/11] devtools: warn when adding some pthread calls Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 02/11] eal: rename thread name length definition Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 03/11] eal: remove attributes from control thread creation Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 04/11] eal: promote thread API as stable Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 05/11] eal: force prefix for internal threads Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 06/11] lib: convert to internal control threads Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 07/11] drivers: " Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 08/11] examples: convert to normal " Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 09/11] test: convert threads creation Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 10/11] eal: remove deprecated thread functions Thomas Monjalon
2023-09-13 11:28 ` [PATCH v3 11/11] lib: remove pthread.h from includes Thomas Monjalon
2023-09-17 12:26 ` Konstantin Ananyev [this message]
2023-09-22 13:46 ` [PATCH v3 00/11] rework thread management David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb1be508-1374-dd93-e4af-a14eec0ebd44@yandex.ru \
--to=konstantin.v.ananyev@yandex.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).