From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E556425C2; Sun, 17 Sep 2023 14:26:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22E1B40260; Sun, 17 Sep 2023 14:26:13 +0200 (CEST) Received: from forward501b.mail.yandex.net (forward501b.mail.yandex.net [178.154.239.145]) by mails.dpdk.org (Postfix) with ESMTP id 3594940223 for ; Sun, 17 Sep 2023 14:26:12 +0200 (CEST) Received: from mail-nwsmtp-smtp-production-main-33.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-33.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1f21:0:640:9366:0]) by forward501b.mail.yandex.net (Yandex) with ESMTP id 165DD5E4B2; Sun, 17 Sep 2023 15:26:09 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-33.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 6QiFphpWrSw0-IWNBacvh; Sun, 17 Sep 2023 15:26:08 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1694953568; bh=mGYMJqQykGBK/uLrP9I7M71PhzG4VfXBlUEsI66WtY0=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=g9y8xVUxd/9RwJx3r1FoKBWq9HPasgateMCL7PHvR67fr5kVqd4yEVE6HyXwdCokz w1lLdXkJOioWtt1vf85FRk8ou9bCnS2Nm/yUBypF06DGSeRD2VJW5EA3Xt5SuY8ma/ 22P0H0aQxOoMgoUtVpojkd7Bw1m4wRhfJPdQA4t4= Authentication-Results: mail-nwsmtp-smtp-production-main-33.iva.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: Date: Sun, 17 Sep 2023 13:26:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v3 00/11] rework thread management Content-Language: en-US To: Thomas Monjalon , dev@dpdk.org Cc: Tyler Retzlaff , David Marchand , Ferruh Yigit References: <20230906162226.1618088-1-thomas@monjalon.net> <20230913114351.1940459-1-thomas@monjalon.net> From: Konstantin Ananyev In-Reply-To: <20230913114351.1940459-1-thomas@monjalon.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 13/09/2023 12:28, Thomas Monjalon пишет: > The main effect of this patch series is to > remove calls to pthread functions except for pthread_cancel and locks. > > The function rte_thread_create_control() does not take thread attributes > settings anymore as it looks a useless complication of the API. > Then the rte_thread API is made stable, > so we can remove the old deprecated functions > rte_thread_setname() and rte_ctrl_thread_create(). > > Some new internal functions are added in rte_thread to make sure > all internal thread names are prefixed with "dpdk-". > > Few other cleanups are done. > > Future work about pthread portability are about: > - cancel > - mutex > > --- > > v2 changes: > - replace (|_) with _? in checkpatch > - simplify thread name size doc > - build time check of internal thread name size > - clean control thread params struct > v3 change: > - fix build (wrong placement of RTE_BUILD_BUG_ON) > note for later: never send a patch during a summit! > > > Thomas Monjalon (11): > devtools: warn when adding some pthread calls > eal: rename thread name length definition > eal: remove attributes from control thread creation > eal: promote thread API as stable > eal: force prefix for internal threads > lib: convert to internal control threads > drivers: convert to internal control threads > examples: convert to normal control threads > test: convert threads creation > eal: remove deprecated thread functions > lib: remove pthread.h from includes > > app/test/process.h | 10 +- > app/test/test_lcores.c | 9 +- > app/test/test_link_bonding.c | 2 + > app/test/test_pdump.c | 6 +- > app/test/test_pdump.h | 2 +- > app/test/test_threads.c | 2 +- > devtools/checkpatches.sh | 16 +++ > .../prog_guide/env_abstraction_layer.rst | 2 +- > doc/guides/rel_notes/deprecation.rst | 5 - > doc/guides/rel_notes/release_23_11.rst | 6 + > drivers/common/cnxk/roc_dev.c | 16 +-- > drivers/common/cnxk/roc_dev_priv.h | 2 +- > drivers/common/cnxk/roc_nix_inl_dev.c | 9 +- > drivers/common/cnxk/roc_nix_inl_priv.h | 2 +- > drivers/common/cnxk/roc_platform.h | 3 +- > drivers/common/mlx5/mlx5_common.c | 1 + > drivers/common/mlx5/windows/mlx5_win_ext.h | 2 + > drivers/dma/skeleton/skeleton_dmadev.c | 8 +- > drivers/event/dlb2/pf/base/dlb2_osdep.h | 14 +- > drivers/event/dlb2/pf/base/dlb2_resource.c | 39 +++--- > drivers/event/dlb2/pf/dlb2_main.h | 1 - > drivers/net/ark/ark_ethdev.c | 11 +- > drivers/net/ark/ark_pktgen.c | 8 +- > drivers/net/ark/ark_pktgen.h | 2 +- > drivers/net/bnxt/bnxt.h | 1 + > drivers/net/iavf/iavf_vchnl.c | 4 +- > drivers/net/ice/ice_dcf_parent.c | 7 +- > drivers/net/ipn3ke/ipn3ke_representor.c | 17 ++- > drivers/net/ixgbe/ixgbe_ethdev.c | 8 +- > drivers/net/mlx5/mlx5.h | 2 +- > drivers/net/mlx5/mlx5_hws_cnt.c | 42 +++--- > drivers/net/qede/base/bcm_osal.h | 1 + > drivers/net/sfc/sfc_mae.h | 2 +- > drivers/net/sfc/sfc_mae_counter.c | 11 +- > drivers/net/txgbe/txgbe_ethdev.c | 6 +- > drivers/raw/ifpga/base/opae_osdep.h | 1 + > drivers/raw/ifpga/ifpga_rawdev.c | 19 ++- > drivers/vdpa/ifc/ifcvf_vdpa.c | 86 ++++++------ > drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +- > drivers/vdpa/mlx5/mlx5_vdpa.h | 10 +- > drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 70 +++------- > drivers/vdpa/mlx5/mlx5_vdpa_event.c | 64 +++------ > drivers/vdpa/sfc/sfc_vdpa.c | 1 + > drivers/vdpa/sfc/sfc_vdpa_ops.c | 15 +- > drivers/vdpa/sfc/sfc_vdpa_ops.h | 3 +- > examples/vhost/main.c | 9 +- > examples/vhost_blk/vhost_blk.c | 21 +-- > lib/eal/common/eal_common_options.c | 1 + > lib/eal/common/eal_common_proc.c | 15 +- > lib/eal/common/eal_common_thread.c | 131 +++++++----------- > lib/eal/common/eal_common_trace.c | 1 + > lib/eal/common/malloc_mp.c | 1 + > lib/eal/freebsd/eal.c | 2 +- > lib/eal/freebsd/eal_alarm.c | 1 + > lib/eal/freebsd/eal_interrupts.c | 10 +- > lib/eal/freebsd/eal_thread.c | 9 +- > lib/eal/include/rte_eal.h | 3 - > lib/eal/include/rte_lcore.h | 42 ------ > lib/eal/include/rte_per_lcore.h | 2 - > lib/eal/include/rte_thread.h | 131 +++++++++--------- > lib/eal/linux/eal.c | 2 +- > lib/eal/linux/eal_alarm.c | 1 + > lib/eal/linux/eal_interrupts.c | 10 +- > lib/eal/linux/eal_thread.c | 18 +-- > lib/eal/linux/eal_timer.c | 11 +- > lib/eal/unix/rte_thread.c | 2 +- > lib/eal/version.map | 44 +++--- > lib/eal/windows/eal.c | 2 +- > lib/eal/windows/eal_interrupts.c | 2 +- > lib/eal/windows/eal_thread.c | 8 -- > lib/eal/windows/rte_thread.c | 2 +- > lib/ethdev/ethdev_driver.c | 1 + > lib/ethdev/ethdev_driver.h | 2 + > lib/ethdev/rte_ethdev_core.h | 2 - > lib/ethdev/rte_flow.c | 1 + > lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++-- > lib/vhost/fd_man.c | 6 +- > lib/vhost/fd_man.h | 2 +- > lib/vhost/socket.c | 23 ++- > lib/vhost/vduse.c | 5 +- > lib/vhost/vhost.c | 1 + > 81 files changed, 466 insertions(+), 632 deletions(-) > Series-acked-by: Konstantin Ananyev