From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (unknown [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id B7D6B1BA1A
 for <dev@dpdk.org>; Thu, 26 Oct 2017 00:13:08 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 25 Oct 2017 15:13:07 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,433,1503385200"; d="scan'208";a="167634897"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.45])
 ([10.241.225.45])
 by fmsmga006.fm.intel.com with ESMTP; 25 Oct 2017 15:13:06 -0700
To: John McNamara <john.mcnamara@intel.com>,
 Allain Legacy <allain.legacy@windriver.com>,
 Matt Peters <matt.peters@windriver.com>,
 Stephen Hurd <stephen.hurd@broadcom.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 John Daley <johndale@cisco.com>, Nelson Escobar <neescoba@cisco.com>,
 Jing Chen <jing.d.chen@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Beilei Xing <beilei.xing@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Yongseok Koh <yskoh@mellanox.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Rasesh Mody <rasesh.mody@cavium.com>, Harish Patil
 <harish.patil@cavium.com>, Shahed Shaikh <shahed.shaikh@cavium.com>,
 Yuanhan Liu <yliu@fridaylinux.org>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Shrikrishna Khare <skhare@vmware.com>, Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, David Harton <dharton@cisco.com>
References: <20170901023628.21308-1-dharton@cisco.com>
 <20171025030101.43269-1-ferruh.yigit@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <bb2e003b-f1cb-7fce-4e24-f175d455d245@intel.com>
Date: Wed, 25 Oct 2017 15:13:05 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171025030101.43269-1-ferruh.yigit@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5] ethdev: allow returning error on VLAN
	offload ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Oct 2017 22:13:09 -0000

On 10/24/2017 8:01 PM, Ferruh Yigit wrote:
> From: David Harton <dharton@cisco.com>
> 
> Some devices may not support or fail setting VLAN offload
> configuration based on dynamic circumstances so the
> vlan_offload_set_t vector is modified to return an int so
> the caller can determine success or not.
> 
> rte_eth_dev_set_vlan_offload is updated to return the
> value provided by the vector when called along with restoring
> the original offload configs on failure.
> 
> Existing vlan_offload_set_t vectors are modified to return
> an int.  Majority of cases return 0 but a few that actually
> can fail now return their failure codes.
> 
> Finally, a vlan_offload_set_t vector is added to virtio
> to facilitate dynamically turning VLAN strip on or off.
> 
> Signed-off-by: David Harton <dharton@cisco.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.