From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C7059324B; Mon, 27 Nov 2017 20:58:45 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2017 11:58:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,465,1505804400"; d="scan'208";a="6888352" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.168]) ([10.241.225.168]) by orsmga003.jf.intel.com with ESMTP; 27 Nov 2017 11:58:44 -0800 To: Andrew Rybchenko , dev@dpdk.org Cc: Andy Moreton , stable@dpdk.org References: <1510819481-6809-1-git-send-email-arybchenko@solarflare.com> <1510819481-6809-16-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Mon, 27 Nov 2017 11:58:44 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510819481-6809-16-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 15/53] net/sfc/base: fix PreFAST issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2017 19:58:46 -0000 On 11/16/2017 12:04 AM, Andrew Rybchenko wrote: > From: Andy Moreton > PREfast seems a static analysis tool. Can you please give more detail about fixed issue itself. "fix PREfast issue" is not informative about what has been fixed. If you can send the details I can amend the commit. Thanks, ferruh > Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base") > Cc: stable@dpdk.org > > Signed-off-by: Andy Moreton > Signed-off-by: Andrew Rybchenko > --- > drivers/net/sfc/base/efx.h | 12 ++++++------ > drivers/net/sfc/base/efx_phy.c | 2 +- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h > index 834eea0..ca0f945 100644 > --- a/drivers/net/sfc/base/efx.h > +++ b/drivers/net/sfc/base/efx.h > @@ -913,13 +913,13 @@ efx_phy_media_type_get( > __in efx_nic_t *enp, > __out efx_phy_media_type_t *typep); > > -extern efx_rc_t > +extern __checkReturn efx_rc_t > efx_phy_module_get_info( > - __in efx_nic_t *enp, > - __in uint8_t dev_addr, > - __in uint8_t offset, > - __in uint8_t len, > - __out_bcount(len) uint8_t *data); > + __in efx_nic_t *enp, > + __in uint8_t dev_addr, > + __in uint8_t offset, > + __in uint8_t len, > + __out_bcount(len) uint8_t *data); > > #if EFSYS_OPT_PHY_STATS > > diff --git a/drivers/net/sfc/base/efx_phy.c b/drivers/net/sfc/base/efx_phy.c > index 752cd52..c81a91c 100644 > --- a/drivers/net/sfc/base/efx_phy.c > +++ b/drivers/net/sfc/base/efx_phy.c > @@ -296,7 +296,7 @@ efx_phy_media_type_get( > *typep = epp->ep_fixed_port_type; > } > > - __checkReturn efx_rc_t > + __checkReturn efx_rc_t > efx_phy_module_get_info( > __in efx_nic_t *enp, > __in uint8_t dev_addr, >