DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/txgbe: fix a bit with boolean operator
@ 2022-03-01  6:08 Weiguo Li
  2022-03-02  8:02 ` Jiawen Wu
  0 siblings, 1 reply; 7+ messages in thread
From: Weiguo Li @ 2022-03-01  6:08 UTC (permalink / raw)
  To: jiawenwu; +Cc: dev

Since boolean value is in 0 and 1, it's strange to combines a boolean
value with a bit operator.

Thus it's highly possible a typo error with "if (A & !B)", and more
probably to use "if (A & ~B)" instead.

Fixes: c1d4e9d37abdc6 ("net/txgbe: add queue stats mapping")

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 drivers/net/txgbe/txgbe_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 19d4444748..f0994f028d 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -376,7 +376,7 @@ txgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,
 	if (hw->mac.type != txgbe_mac_raptor)
 		return -ENOSYS;
 
-	if (stat_idx & !QMAP_FIELD_RESERVED_BITS_MASK)
+	if (stat_idx & ~QMAP_FIELD_RESERVED_BITS_MASK)
 		return -EIO;
 
 	PMD_INIT_LOG(DEBUG, "Setting port %d, %s queue_id %d to stat index %d",
-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-03-03 16:17 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01  6:08 [PATCH] net/txgbe: fix a bit with boolean operator Weiguo Li
2022-03-02  8:02 ` Jiawen Wu
2022-03-02 17:23   ` Ferruh Yigit
2022-03-03 13:31     ` Weiguo Li
2022-03-03 15:18       ` Ferruh Yigit
2022-03-03 16:16       ` Stephen Hemminger
2022-03-02 17:34   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).