From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AE6BA45C0B;
	Tue, 29 Oct 2024 14:00:53 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8327142E10;
	Tue, 29 Oct 2024 14:00:53 +0100 (CET)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id BC5FE40144
 for <dev@dpdk.org>; Tue, 29 Oct 2024 14:00:51 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EADB1113E;
 Tue, 29 Oct 2024 06:01:20 -0700 (PDT)
Received: from [10.57.58.134] (unknown [10.57.58.134])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 97DEF3F528;
 Tue, 29 Oct 2024 06:00:50 -0700 (PDT)
Message-ID: <bb98d996-87e3-4470-864b-be17b520faee@arm.com>
Date: Tue, 29 Oct 2024 13:00:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/5] dts: use Pydantic in the configuration
Content-Language: en-GB
To: =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>, dev@dpdk.org
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
 Paul Szczepanek <paul.szczepanek@arm.com>
References: <20240822163941.1390326-1-luca.vizzarro@arm.com>
 <20240822163941.1390326-4-luca.vizzarro@arm.com>
 <955abe98-9b96-44c5-8ec2-969a8da20365@pantheon.tech>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <955abe98-9b96-44c5-8ec2-969a8da20365@pantheon.tech>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Likewise, thank you Juraj for the comments.

Most if not all suggestions have been applied in the new versions.

On 17/09/2024 12:13, Juraj Linkeš wrote:
>> - the config schema is no longer used for validation but kept as an
>>    alternative format for the developer
> 
> If it's not used, we should remove it right away (in this patch). I see 
> that it's updated in v5, but we can just add it back.

You are right, and this is now removed in the new versions.

>> diff --git a/dts/framework/runner.py b/dts/framework/runner.py
>> @@ -231,10 +234,10 @@ def _get_test_suites_with_cases(
>>           test_suites_with_cases = []
>>           for test_suite_config in test_suite_configs:
>> -            test_suite_class = 
>> self._get_test_suite_class(test_suite_config.test_suite)
>> +            test_suite_class = 
>> self._get_test_suite_class(test_suite_config.test_suite_name)
> 
> We've already done all the validation and importing at this point and we 
> should be able to use test_suite_config.test_suite_spec, right? The same 
> is true for TestSuiteWithCases, which holds the same information.

This is correct.

> Looks like you removed _get_test_suite_class in a subsequent patch, but 
> we should think about getting rid of TestSuiteWithCases, as it was 
> conceived to do what TestSuiteSpec is doing.

I believe the two have different ideas, one just describes the 
specification, and one extracts a subset for runtime. It is a good idea 
to unify stuff anyways, so it may something we could do in the near future.