From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54CFA43B06; Thu, 15 Feb 2024 06:41:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF59742EB5; Thu, 15 Feb 2024 06:41:25 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2086.outbound.protection.outlook.com [40.107.243.86]) by mails.dpdk.org (Postfix) with ESMTP id 57A1840276 for ; Thu, 15 Feb 2024 06:41:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QLm4qEUONbYCt8hKDZmzUoztH+dU1vC9KuWpYmIbcHGxgh5GrX3M5MT9m9CzpUjMtyf4i0TVh73VS0EWQwPXNrlTs55v7I6OF1/A8PmOD9AIEKx9Ug+4GOL8tdWOcQKi7m5js2SE4mvSHPKxrxK6Z5Xb/GLwtuXWKxU92kKaoGiJhH4v4r2uif9cpuwTBKf+KHpe0Cx3wElm8kF7ZVey2HKVGAG/evL9OA7EgqXJmYvt2pOoHOgj/VZ0Zh5+ynyQPn7GUY9yIae1Q3PknyWaCeH/2+TonIcJJmK2FrjVcUKPN6OIbob3kJJCR8aiPDEyl8YyfYyUO7nGmbah9dSvIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wcJH4Sq+lXBc63wFjcAbQP9EQb+OYZXPfN8227f7sZ4=; b=fb/FaxIQ+Z8T/KE0SVlxxDFPbPkAmSlWmmxZ3auLsC+07iHujQ9ay1xPLHVSYMAePWAD4v7ZHi99yEhs1UUxSVe7bvX9OnBfncZC6OUu59ntsDdcpHJYRcB4QHkC4tc8rpcYYdSfbxGd+8P4gQE8oYD5YmZrJ5tEStIOAWEY7tQIKc4LdmhsUij84XvV6lJ2scZe5Ri1+K0rCV1y3N4/enVKW3STNA2kYlIix3srCZswWdlu8Cxs6zeNk/rBxbIn9SZEH8EZyU7ddtzQORq9sm+uUMOdNBNX+77VGex3+MshjrsPkzPa0cMPbK0HVte/wkKqsaZuuoO0MlFZmVVXqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wcJH4Sq+lXBc63wFjcAbQP9EQb+OYZXPfN8227f7sZ4=; b=On1rX75zSIf1l4AWDo0GNAVS7RGULn1GQsAgKHc6pLpqPNCJspTEBNWUZHFVu5WSaQLQexcPpqGyg7nOpcEd3Qyo8htEmIZhpruE8/QnfNfBGQ2a+wijrc3wi3vqWHVrDU9Pba/Hcyyo+O5HQcKm68I76bjblPJqJMfMs4Lf0q5I2yQaoATsD9SV3JUkdE5nYoKEpbFXLWSRBq8+7rY6buBYQHIEPsyRW01RTcTw6go2Iga0+YROtuTfTQJUXFcO/deaTvDjpH8VsXjbzpSEB9LWLQ3PrmqKyTYwxheIz2PR35QXqKXto51tkuRq0QuZsklNLuhjGMFSH9nBNFyPgA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) by CH3PR12MB9122.namprd12.prod.outlook.com (2603:10b6:610:196::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.27; Thu, 15 Feb 2024 05:41:22 +0000 Received: from IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::22fc:4326:d657:92ad]) by IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::22fc:4326:d657:92ad%7]) with mapi id 15.20.7292.013; Thu, 15 Feb 2024 05:41:22 +0000 Date: Thu, 15 Feb 2024 07:41:16 +0200 (IST) From: "Etelson, Gregory" To: Ferruh Yigit cc: dev@dpdk.org, mkashani@nvidia.com, Ori Kam , Aman Singh , Yuying Zhang , Thomas Monjalon , Andrew Rybchenko Subject: Re: [PATCH v7] ethdev: add template table resize API In-Reply-To: Message-ID: References: <20231217093205.321082-1-getelson@nvidia.com> <20240214143218.62630-1-getelson@nvidia.com> <8dda8697-8719-46cb-be65-eababae1ccf4@amd.com> <91415555-d916-b2a4-9fbf-0c98bb271543@nvidia.com> Content-Type: text/plain; charset=US-ASCII; format=flowed X-ClientProxiedBy: TL2P290CA0029.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:3::19) To IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6332:EE_|CH3PR12MB9122:EE_ X-MS-Office365-Filtering-Correlation-Id: 46893237-d60d-41c9-2196-08dc2de8bdc4 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rC66iD1DKSQC5Ggt4mnql98O2BL169VhwLnql0QNOt77PMMEjThFPaux9SF+TpF3UyQXKWpfDOn7Urs3ITErQOn+1P+8xrXjU7JqDvXQVdbUltCxqPRSNo9ZTfbyadLphJ16PzvaiIeLab7VIvOqNcMETQ9koJ/kPOenl4d9aoqxChqCIMkv07Sx8mYLntMCzSIK+YxmGFDb7ydktNgc4Y7tVpGe/ef7d4EVJzPw2fJLhYRMfb5wTFdpeDfq5v0TFLK1NXc6odZKAzUo/BmNVfO8YXOeAlHqSnXLMzqb61QUnE63nnSkP0aNrBdcpuyG5XBLa2VL/fbWbzyTpthU7xGQayMprP+AJTzm6qJ5x5I+RlC1SWFnj8JrxkgsjjNbabel7R9A0bMT2RPshHVKjHq+6EsZiuBuTYrc3yOzLelA/YyIfcn1q4LK04WXQXYfM+nHi//PN7+/IER2T3Qf/BasLsp68YKfTRqeOEhpcmeVwTpBcUvIUhoxSGs5QWtKS/wLp8WFm2zj0Bli02aLmPVM2GgqDtaWqe/x4uIawoJQnzGgtArS+ECQ21qkloVZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB6332.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(346002)(39860400002)(376002)(366004)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(478600001)(6486002)(41300700001)(6916009)(66556008)(4326008)(5660300002)(2906002)(8936002)(8676002)(66946007)(54906003)(66476007)(6666004)(6506007)(6512007)(316002)(2616005)(83380400001)(86362001)(26005)(38100700002)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xcAx/poRBzuyy5Qm8F/jSiwxE4o8pwAxi83NHYsLPUwNzsn+X2vDEC5l5Qgx?= =?us-ascii?Q?YqqxhXwnbkMvsAH+WWaeRQR3qSjHUkjHOF8uBgZpm/ukHyM+4Cr1NxAZCoBz?= =?us-ascii?Q?lrsR9VNh+i4zVKwJm9CkJsOT2fBdc8+5ph1sX66luCY72ByAe9iFQqCWpuN2?= =?us-ascii?Q?15UQ3sk18ebFN6B1Eru1cmY/EtOdTny8a5gHC3y1ZGbHwjZjPKLFdBUeve0e?= =?us-ascii?Q?YOmvzLTEKg+JvHOectkaFDv03EK8Dk3iNu8/6RpgKxLdXxccEHf0cHeUq8YX?= =?us-ascii?Q?jRsX5wEFHTC+hsGYDqrjbK/iafi56aqAOkJfq/4tC7IIGbq7AnP3scPpRY9Z?= =?us-ascii?Q?Hv9oNDwn8FhcAZXPIvZqycSWUtYNdxCfBijOycGsRgKp8z3n5BlVmgBetIV+?= =?us-ascii?Q?8imeTyIVZD4uOeaoG2jz1UYhDEBTn6CSBydInktuqcxQv7+Mc/WAycLDAAkS?= =?us-ascii?Q?uHxogKk+OYjRxf6VyM+Zj58cwdvgZnhjBiU2YcN5tbBbPZ+tt0E3Tbm7i5bV?= =?us-ascii?Q?+9dsiCpxPyGC97GfgqA8CLNxIL4q0NNBHyppV/96SLA3P4tEgkgTozsABXp2?= =?us-ascii?Q?4D1hx5y4b/LoDj3m3QACXMkkPdfXtRCEIRA6SV/jAG4nYsSnAlcS/lhzW/rh?= =?us-ascii?Q?VgbQeGFTNEKmX96eJafT+LJa5tw9MesJkQRxY97vJBB6cON+DLcLngsgh0Po?= =?us-ascii?Q?zSJ8ya6Okctm2Vl8pibpuV5H4TzC/5dha5yIJ4IQVJZrmTBehY8NnCeMrwfq?= =?us-ascii?Q?1jUAjEET6ZTSHuUjz3HK8VEkWHCFCCdYFkMnkQnMUVPHwC5rPIPY+Ma2uL47?= =?us-ascii?Q?zOXIKoyQWhnfkLzthUDDw/ER+HstLlF+ECegBPTvsl39ptvOBFlOsX1Fv0zi?= =?us-ascii?Q?jYxllzUjZcIf+2Y6p/j5XbVwLGu7hI/iYCV//CRKsgcQDcw/xMEw8x3v17qC?= =?us-ascii?Q?iSDV0v7c/I6IKx1u3maEkwpJHwKVOKGkbMHwGEXI9YSpSrLuubjB/lknLwTE?= =?us-ascii?Q?2eNslLSHJ3ZTFnaw+HQyCpfkS3GesRAD+e0E6CCDvpyza4yHh3qZtwzwacfu?= =?us-ascii?Q?n0uFyJj22kdm4qJPanm9JLN4FWtpedBlUJtfsJaTBPJJqWQqzIF4ayOKeN1O?= =?us-ascii?Q?deHiiluH2U1CCP1P9xZvxGjyMa6YfqWIv6JQoIXTqXigiyZYl2NS8BMkJYM3?= =?us-ascii?Q?wU6LKzWrMcJkwf44C/lkgzSI2ShPRM943XNsQAui00LebW8T4ZdCW8V3L8UT?= =?us-ascii?Q?0f7MxqfvD6irWYYpsegY5JLZEUBmli9rGyfO63803t2lXjFxyk/7o235OobZ?= =?us-ascii?Q?pcq67OZOliKgIgEbBXiTm/zf2tXbanXOBCl7Fci6oE38KqlVnm9K9epBTLvB?= =?us-ascii?Q?U41W6mapjdDEeuJ+m2B5dYxjysHynB0YSpmkwlESzn0TKQa3ZbcmH1MeJ+85?= =?us-ascii?Q?+06EsSX/P4INTJ0pa+FdTZE5bVGE7/eVO1JzfMVbYN+R7wPN87Tq+b5reGap?= =?us-ascii?Q?HFlai3sbooWnYCIjWmBovTucoKuaq3OpOC25WbFu+8P0Hp/YwVTN5HuBrrie?= =?us-ascii?Q?R3nlQTA4p9F6n3fA/WArxprgtZcPZH+1V6mhh/3+?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46893237-d60d-41c9-2196-08dc2de8bdc4 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6332.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 05:41:22.1207 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ce0vpRwUdjo0DPBXbqQcckftWdU5DV1uLejT+SmibJR59Ff++JgSsTb4tAbDXnTC9hb61F1+ww1VTYlVDvpugA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9122 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Ferruh, <...> >>> >>> Syntax above is odd, why not move parenthesis to first line. >> >> Agree that's odd style. >> DPDK prefers that way. >> Please check rte_flow_driver.h::rte_flow.ops. >> > > True that is also odd but at least it is function pointers in a struct, > but this is regular function deceleration, why not: > ``` > bool > rte_flow_template_table_resizable(__rte_unused uint16_t port_id, > const struct rte_flow_template_table_attr *tbl_attr); > ``` > will change in the next patch update. <...> > Either it or application needs to manage it. Agree that application can > call update() on all flows is easier for app, that is why I asked for > this clarification. > > But still it is different than API definition making it mandatory to > call for new flows. > > What about something like, although it is a little longer: > ``` > Update flow for the new template table configuration after table resize. > > Should be called for rules created before table resize. If called for > rules crated after table resize, API should return success, so > application is free to call this API for all flows. > ``` > > That's very good. I'll use it in the next patch update. <...> >> >> A different error is good. >> What about EBUSY ? >> > > I don't know, can be EBUSY or EAGAIN. > Or we can overload EEXIST as there are existing not updated flows. > According to errno(3): EAGAIN Resource temporarily unavailable EBUSY Device or resource busy EEXIST File exists UBUSY fits the context.