From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id CE5432C37 for ; Thu, 2 Feb 2017 17:18:25 +0100 (CET) Received: from 6wind.com (unknown [10.16.0.184]) by proxy.6wind.com (Postfix) with SMTP id 84B4C24FBE; Thu, 2 Feb 2017 17:18:20 +0100 (CET) Received: by 6wind.com (sSMTP sendmail emulation); Thu, 02 Feb 2017 17:18:19 +0100 From: Pascal Mazon To: keith.wiles@intel.com Cc: dev@dpdk.org, Pascal Mazon Date: Thu, 2 Feb 2017 17:18:03 +0100 Message-Id: X-Mailer: git-send-email 2.8.0.rc0 In-Reply-To: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> References: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> In-Reply-To: <050aa06c03aa4b56f703d74a8d8a792de5e075f4.1486026370.git.pascal.mazon@6wind.com> References: <050aa06c03aa4b56f703d74a8d8a792de5e075f4.1486026370.git.pascal.mazon@6wind.com> Subject: [dpdk-dev] [PATCH v2 6/7] net/tap: implement link up and down callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2017 16:18:26 -0000 Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 67 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 62 insertions(+), 5 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 734e3a579219..275af9df2252 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -275,13 +275,69 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) return num_tx; } +static int tap_link_set_flags(struct pmd_internals *pmd, short flags, int add) +{ + struct ifreq ifr; + int err, s; + + /* + * An AF_INET/DGRAM socket is needed for + * SIOCGIFFLAGS/SIOCSIFFLAGS, using fd won't work. + */ + s = socket(AF_INET, SOCK_DGRAM, 0); + if (s < 0) { + RTE_LOG(ERR, PMD, + "Unable to get a socket to set flags: %s\n", + strerror(errno)); + return -1; + } + memset(&ifr, 0, sizeof(ifr)); + strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ); + err = ioctl(s, SIOCGIFFLAGS, &ifr); + if (err < 0) { + RTE_LOG(ERR, PMD, "Unable to get tap netdevice flags: %s\n", + strerror(errno)); + close(s); + return -1; + } + if (add) + ifr.ifr_flags |= flags; + else + ifr.ifr_flags &= ~flags; + err = ioctl(s, SIOCSIFFLAGS, &ifr); + if (err < 0) { + RTE_LOG(ERR, PMD, "Unable to %s flags 0x%x: %s\n", + add ? "set" : "unset", flags, strerror(errno)); + close(s); + return -1; + } + close(s); + + return 0; +} + static int -tap_dev_start(struct rte_eth_dev *dev) +tap_link_set_down(struct rte_eth_dev *dev) { - /* Force the Link up */ + struct pmd_internals *pmd = dev->data->dev_private; + + dev->data->dev_link.link_status = ETH_LINK_DOWN; + return tap_link_set_flags(pmd, IFF_UP | IFF_NOARP, 0); +} + +static int +tap_link_set_up(struct rte_eth_dev *dev) +{ + struct pmd_internals *pmd = dev->data->dev_private; + dev->data->dev_link.link_status = ETH_LINK_UP; + return tap_link_set_flags(pmd, IFF_UP | IFF_NOARP, 1); +} - return 0; +static int +tap_dev_start(struct rte_eth_dev *dev) +{ + return tap_link_set_up(dev); } /* This function gets called when the current port gets stopped. @@ -295,8 +351,7 @@ tap_dev_stop(struct rte_eth_dev *dev) for (i = 0; i < internals->nb_queues; i++) if (internals->fds[i] != -1) close(internals->fds[i]); - - dev->data->dev_link.link_status = ETH_LINK_DOWN; + tap_link_set_down(dev); } static int @@ -532,6 +587,8 @@ static const struct eth_dev_ops ops = { .rx_queue_release = tap_rx_queue_release, .tx_queue_release = tap_tx_queue_release, .link_update = tap_link_update, + .dev_set_link_up = tap_link_set_up, + .dev_set_link_down = tap_link_set_down, .stats_get = tap_stats_get, .stats_reset = tap_stats_reset, }; -- 2.8.0.rc0