From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0048.outbound.protection.outlook.com [104.47.32.48]) by dpdk.org (Postfix) with ESMTP id DA1D62C01 for ; Wed, 26 Apr 2017 11:53:37 +0200 (CEST) Received: from BN6PR03CA0074.namprd03.prod.outlook.com (10.164.122.140) by DM2PR0301MB0607.namprd03.prod.outlook.com (10.160.95.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Wed, 26 Apr 2017 09:53:36 +0000 Received: from BY2FFO11FD039.protection.gbl (2a01:111:f400:7c0c::189) by BN6PR03CA0074.outlook.office365.com (2603:10b6:405:6f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12 via Frontend Transport; Wed, 26 Apr 2017 09:53:36 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD039.mail.protection.outlook.com (10.1.14.224) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1047.9 via Frontend Transport; Wed, 26 Apr 2017 09:53:35 +0000 Received: from [127.0.0.1] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v3Q9rTEN021860; Wed, 26 Apr 2017 02:53:33 -0700 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" References: <20170403105302.9685-1-akhil.goyal@nxp.com> CC: "Doherty, Declan" , "hemant.agrawal@nxp.com" From: Akhil Goyal Message-ID: Date: Wed, 26 Apr 2017 15:23:28 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131376740159649322; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39450400003)(39410400002)(39400400002)(39850400002)(39840400002)(39380400002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(24454002)(13464003)(377454003)(199003)(189002)(52314003)(9170700003)(8936002)(229853002)(47776003)(8676002)(31686004)(120886001)(36756003)(81166006)(104016004)(53936002)(5660300001)(8656002)(83506001)(305945005)(85426001)(54906002)(105606002)(4001350100001)(65826007)(65956001)(65806001)(23746002)(7126002)(7246003)(50466002)(6246003)(64126003)(106466001)(4326008)(50986999)(76176999)(31696002)(2501003)(33646002)(86362001)(230700001)(53546009)(77096006)(93886004)(54356999)(6666003)(38730400002)(189998001)(2950100002)(356003)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0301MB0607; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD039; 1:/DJeifMjUEYPCNTGrXkOEaeKVYIYvPK7x0PZbapODV97xKBybban5cCy90ZOIMFgNYMbhkyXU8uJbRbGr8fdrm3U9uYf2NQzwyNDEM1kH6bWH9vbEPiNlH1NONXheuAzONZ9RnMz4R7dHDFpbAPkjM7PBAfUCF2L4o6kh9VOtnGEAnTMxSoddAu0PKZoq33E8mNNnB4THXyb2Y3v/PhUVciA9+L9zs3E+KxgN6+wVAAfo6i2dBVxF/fIBaglaD1ZeUs7W7Pe6pHIkNAVx/gLRVbs/4O8otgmWbx9GA01r2Nsd4TYz1FQkiB9WwqW5FwvBzZx+d8JJ2hScVK6mgAv7ipKWI85++TJQVqHTK+Q28rGegwNvyys2yhe8Hz26GW2XwgK+ew3qDypZ6LsmybyGrn3yvOHPvgzzdImm7Qjt5hQ1LKkkYxZkeq+Rvgvq25Btg/eNhDyXPazCj31/frbJw/DMTLklIkx464AieqVQX+hGIwXM8J1VBSC6Ake5PRHcz0tQmfoLr5sxxA0HgLW3VYZ/LSaQPSHcBHzwWCru6Rpda0NQ7jlUUy0Ewm2Rmhdw4FjzFSxHC8W+uotHSbwf07UcTT8iIChNuN7PYaERnXS1DZPY3Hsmijj987wcjwzhNrKM0H673xqlwPTTswphw== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5dbf395e-b184-42e8-f62a-08d48c8a1b6d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:DM2PR0301MB0607; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0607; 3:UEidwaXpB0JP35/3KxlYhYBGBaMqQdjOkjoS4MImVkk/RH6XsfOK26D5rH+ZpRbCh2QvmGn6oPTpzUYMSSa5tDTdcyO87nTl0UfqId4XK//x5SPE5q5BBXvAXYs6mvZbuZhI/uob7i4QBMOMQaii060j9HJMIGuyD82UJq45Tk5gtURZ7S9+AiEOJ0T84Nq/zks/z9blellrxHJzVvYKMPOYIEn/6RoJkWDbWGAg7TVck4zxMgAHtzHMzHFXcA3IMRt9Kc7h0x+kKfjAXZ6xysKKCOSemE+nXGfbg/yvZXNnx7E9NLswYhkOToWWJweAN+ZpD2UC0qANtdG8PnkycYCg1xsRgl+5fSnqcq8zAwTfQV73RIiNVRFqei96h+k56FPS4ILig0mZ3DYm8l13/HWT8jmMQllYI1ze6qMmmfXqLt51WsXyDIiDtWdA0K3t; 25:MJXtH/xxDhB47Zrj4mFB8ul52Dm9i5R5X0LXk1HCY9zUmEu9du4IcBRUKdBnk2enKVc5Xpa9xABjSx2dmtoyB7z4BMN6HMRkZZb+VKLywpYcHDg76Zylnlkk8f9m0IIjbBQFpOPkNLI9mHiVFUIDG7BlkKITzJfr9CR/r/pnA0DkGm8q252z1udSaVX7qhPCUp2+wGDL3IL8w9DR4eF+4qQxnb8i1Ud8UjoGsys8WpCqbMJdT6f1zQWNuhmgQunr4KpyTuGnPxIs9J5ouJIBVXYRffuOkbhup9/JUf5ezaPIeQhrB05AUiBPmYUea2jwHbCOSs1TIzCeV4LHwTAzLEqKaOCOqTnQcWpaSmV0SJypu5GrMkuC8MXXDMAxAzqMPqcDTPAbfcy4dBRL61L6NPT3ilxLZT5LCXdY8+RCaqkZ6YjKUhkyYa/UFs22jQLPTeGuzRuE22wNaLoXmFnMAQ== X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0607; 31:PHSGEM7NXpsNFJar5iB1btQmy/lxYTCuT+ZoLzIwIBVxMlEw78xm6XOOjdFCkqmXONFvkpdgdu4Q8UVKXXRQHDl7uDv9Wi5jXhkcHrB24n5Z5y25NluusOvLpMSXNGUqbnzThSv+zJVbfMbXN2Jvu68p+9z/d1tAzyS8ZbhcU8udDcCIOxxkwPUZNd4ukl7ZD+k24jcp5WeKfFuvkpj//mqJ8n7i0KRHX0GxJsesSsY8TWeNfR9BNlsq0HAvbIZoTOsIT339+FTCuOBk9TW4vw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13015025)(8121501046)(5005006)(13017025)(13024025)(13023025)(13018025)(3002001)(10201501046)(93006095)(93001095)(6055026)(6096035)(20161123561025)(20161123556025)(20161123563025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123565025); SRVR:DM2PR0301MB0607; BCL:0; PCL:0; RULEID:(400006); SRVR:DM2PR0301MB0607; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0607; 4:0GsAnhrHGzIOMxOx6csVY8VH3vkKqqfzFGY0grqinCfXx7ouDcD+jWx+YKopFH0CHx9rkvnMtg1j2rGutO0/qxifLHGV6iPlwikXfDN/MQl3IKY4vZXFtok2zqliZR7gF7KmSICxk9uG1rIGEvzPbPwLkiAgRuNP68+YPSif65LOSWice5fxBcA5QzvUelfBiK+JHoAfqHsJWZzrGMhbAr32BwVIw4OqP8kptd4hBeYh1tAUnnMwa0yIO/yNqkK+oHJBxheOdC0Z4yepMDTSFYZkr56cBO1dRzNS0lW89MXn0YUfFxkA6+8ssaysR30DqD3s4L7/ssanj5rzfjc6YK3Q+GroGfaA6IDYmaU8XdkfXcU9eSlSk+3u05GD6W4FvsUMPg9zqUGOZN1I7bOFP35SxtKlaOGdcvEaTDZpPsGW0reuUzMWGXC8Q8tV7w28fuDF5bztRyOLY4dXhfgRQTqA705hoYr608lnbjeCjjBmK3ExTpTSF+F7uWdUDXlBtdmGUa0rAMfOmeTE+GJnNiyRX8E3uffDpn7oAfb4tp7Yh2qLjMcg+eMWKdoKhtPQYvxpHDzKVLkuWO8g2wB3I9ceApDKrZJ6hpI/txmL0noUNlt00v43Zh/6V4WU8fxUfeiuur4EoYq8/bGCyQLRQSSY2cW0YIdN7IqaChTMU0czNKV+7i+M+R5NUoW0wRtMgy5E1seBGh75LbFnYr68xKfuJGt3W23EGuo634Z6gnx18TefCbmAgp+eOq6mSACMchHC3y/FqhcRcyuXazoTRm4CeAwo3ltnkJi9DgalQAnNoisD0phSEWxv8bAZaIyQVom78O2uHkqe/J9dR7LvnC0jeplxkOxHNIOrIgQj5UNKqz1O8mZyDGlwAWvRXtEi6BK+SYmgDCF1Vr9F6c/JgYBtud7WvByy+Qzc2OyPbvk= X-Forefront-PRVS: 0289B6431E X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM2PR0301MB0607; 23:WgRthcNE+pd8+w39LfFOPynqPxe3FEBhmwy?= =?Windows-1252?Q?7qtc5HWEP5ToTFcXKkiUxcpfUVMHstwOmaVk/DIIDfrHi989B2P+FUpi?= =?Windows-1252?Q?IHx8R34bCdAF61TPc//fb8NY2Wkn1XD2dcudaGu5I5w7cgOCLOvP9Iof?= =?Windows-1252?Q?CXdmfeJYnccgnSI5y6yCpR4zNF+4ZuM88h4KxJTiIQvsKmBPKnsC1uN6?= =?Windows-1252?Q?/XVhdedP3j3OFSPBEgzsT0IObhzXW/JBmNbgoeC1yEkzDd5ssvhTPp2G?= =?Windows-1252?Q?ZLSPHDhnCZYfp4IPoFJ9+ycbZI390RzUMucp1kbOJIIa1PJ6T4ri6NBT?= =?Windows-1252?Q?GtW2l6hynWGh1faAmiNUEows/Bv7tsWTnNj6DYaws/mkrG68LCIF/tEB?= =?Windows-1252?Q?4YLFpoEKX/41jsbFNs3/KDDHAGW2L6kql1F1TDFo6CRVWrYt5no64Xon?= =?Windows-1252?Q?l0BxWi2kJNWw4NWiHSyNfcNor681iimH7W1jZ1Zr3FpIW63HUJ+5CB12?= =?Windows-1252?Q?eBayl1wuB9hC6hTZMZktv+QkcfgmHuZ1MYmBulZMaqUxvQW1ksFo04je?= =?Windows-1252?Q?TNe5wbDLGegx+s96pRf85JJaId4E4YqN1ymTHhou1p7h3pAuK4Je9Gyn?= =?Windows-1252?Q?G2oazb5afOs4SonxREP2yMriqVO2TSSgkVehK3eBJ2xFSWTbZYcxB8Jy?= =?Windows-1252?Q?JEeY4QM+y6nPZ4N1gOFZ7LPRd2NMc1NaRe5P32WmD6w59NvdFG6pqqza?= =?Windows-1252?Q?8ueBTcLaMG6iPzP43hr2pkdZWMsDtCCGGMOjQG/PdNcFAH0u9XJYn8q1?= =?Windows-1252?Q?bmsi8PZ9PqOladuOA7sQzD5wBDR1KBcu1hQVlFwcp++zww02ndZ5XC6r?= =?Windows-1252?Q?Jo1v5DoZdjRjq1QtY+CL7O524KzfudeIINA5/xgLJmmJoCyAN5iC8il1?= =?Windows-1252?Q?JyKDlCFtnOyXAPU0vFE9Wo7UdJOyUoQl9VDyw8oaOb8L0jvwhC2H72KC?= =?Windows-1252?Q?Aurj02b3PXrQBpG2fcpqXGczz+Js+OKS4/IhwMck+Vc2TlrOtOiciKcr?= =?Windows-1252?Q?eyYeFBxhvQJrwfEpI45LQ8aHOS3O3+OvUofL5S77F8tKG1HhVnIap8MQ?= =?Windows-1252?Q?AtcYspA/VJaVgQnaq9OPnE4e7mKMUC4csLNh5laU1wUL0zBCxSzeFg17?= =?Windows-1252?Q?6eo5YMtXAHrKeoGR109IUo0dKY+Hv9VhlGcDK8YE7S46WWNkUIujUlvx?= =?Windows-1252?Q?0et3WV3L5NNHo8ycxcQ9Sj0Jet6uakwgzMRR+4eQIFhcFf8+JqWSE9+O?= =?Windows-1252?Q?GuWER0v20tmR4FrEtoKnhJ+a0w+m2vk7MMCkiC7NDFToYtOXSS+8FX1W?= =?Windows-1252?Q?vpLAQ8Pne+QjlFLpujBVdxcBKuBy1EecyR3qz/8XFFLQ4ZggK8GzxSyw?= =?Windows-1252?Q?FbQDrLy8oHud3lQVBGgTbTAH18DKoYRId6B2kxvKiqvVEQwFtxNWykSn?= =?Windows-1252?Q?oUV+liIoK31Sas0KkQAZOspa9cd7thfqpVm0uWdi0GNI9Yfqx9PYBhdT?= =?Windows-1252?Q?pgadRrEZketCyJbT9AWpEK4Sel6Mg1HDmSs4oW3mm8GrmP+jlXEZM/EF?= =?Windows-1252?Q?uaYSm7D+frn2tba0iFffKSiyCfgN7JQtKHC/1twY1cE39iFXcbCVKZnm?= =?Windows-1252?Q?TDShUGQiZqVRPQY1hxHIKz1ljpe71EvbRbzNn7RRsCpxOBwvF6Oau?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0607; 6:ZeliWWsAUUbq9nKN2jdrchH9YhUg5RtdbqGsvHKmtDVbIsbOCH+Sjbzn1HCxSPIHNoZ0WIaoUBlRHfl0eax5JByPtXJ03WDDQVa7YC0LW5rzcmq3swOGM6l/M46I3keswSRhKVhsS/NtUqQdYDsIwCevoXVRJzW5kxIQPULePbMjx1d5o4hH79LWswaocB+wio5YZTXwlfFu0OJVjtAn3YJ6tU4Ic9fawLM2lI2WHeQCBsPfGx4IYi/rmBg+JkVeOf4LYixXdtFOxRiXlA1DTUSSyr3lPjtmDZb2TOC4RtPqFvLiFhlSVmG1V7x0JNraYpOcxhPcwi6I5BfBknqTW/prmmERZdoAsnkCoKJWlC15ORGvq7aD3sognqrd5M/+FX2fn0Dzp7uz0vKesOxEd9rp9QtZAZ2E4j1lfX2ukPocPMiexgmB3JLRPN6IEzR9vz9gcrL4nUo3poTf7ailRXLzvhNuN0lFDcuUf1Gz3MA6peWIwZFYF0qQHphyiY5ByVjqn0i94Bs+BHRyKZaN5Q==; 5:5H1cFs6ksPn+6nFsabRuW5EtFdwtdztJJC3osjzaXUuAgJddKGxBHt/YP2RPz8RVKSNQzMeaEEytWKuEFK0UwDrz0ayBDhP0II6bbJ1d1n4TCLh0/SRg4FnrhIh60P/UDL6rixZhgCOyQ6AGq8sgv6mFYMMdHD9lktciF8RpsaLUL9XIG0BBDuplTHTLwoXP; 24:6FyaXbH4ISieMsCFtjJug/XwSLsxGg3HPO9VKvdQSveYBrATmV9k/WlUFCQ0D6L5YLesmwcg93Bw77qAZh9UrU1aOthrl2OD/AUsM3qLghc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0607; 7:cgatXB8felgdi11uq0DPcoV55KrVqgx6Dv1lY/jQjrduw64Dy9w/1//RIRxlyImRX6sjKNI0VAenSER+iA12M+p/cZdI/GNrLzIAN4/H+AUJfjSzYVGifVRPpekXDqenFVUfAkwxxgZovCQwy2AzbZXAEPaoqVl8QP4rVAz9vKHRg+vTMZUMHV/w/otJ/rRfJNZGx0BTL5xoSwrFvdA7LU+h8kMa8mSeTsu8THuf7Xufx9R8RBJ7+o9ZZGCXKHb2gLyQpwCorbMl8vf4VL46YvN6vmZmhpG8dTkSZa3/2pUKHcvjR5b5Ms5EX7Vd055qeqfT4o143i+j1i4GtmnMqw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2017 09:53:35.7309 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0607 Subject: Re: [dpdk-dev] [PATCH] test/test: improve dequeue logic for crypto operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 09:53:39 -0000 On 4/26/2017 3:08 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal >> Sent: Thursday, April 20, 2017 11:48 AM >> To: De Lara Guarch, Pablo; dev@dpdk.org >> Cc: Doherty, Declan; hemant.agrawal@nxp.com >> Subject: Re: [dpdk-dev] [PATCH] test/test: improve dequeue logic for crypto >> operation >> >> Hi Pablo, >> >> On 4/4/2017 8:41 PM, De Lara Guarch, Pablo wrote: >>> Hi Akhil, >>> >>>> -----Original Message----- >>>> From: akhil.goyal@nxp.com [mailto:akhil.goyal@nxp.com] >>>> Sent: Monday, April 03, 2017 11:53 AM >>>> To: dev@dpdk.org >>>> Cc: Doherty, Declan; De Lara Guarch, Pablo; Akhil Goyal >>>> Subject: [PATCH] test/test: improve dequeue logic for crypto operation >>>> >>>> From: Akhil Goyal >>>> >>>> While enqueue/dequeue operations in test_perf_aes_sha, >>>> the underlying implementation may not be able to dequeue >>>> the same number of buffers as enqueued. So, it may be >>>> necessary to perform more dequeue operations if the gap >>>> is more than pparams->burst_size * NUM_MBUF_SETS. >>>> >>>> Other algos may also need to update the logic if required. >>>> >>> >>> In which way this patch improves the dequeue logic? >>> Is it improving the performance somehow? From what I see, it is unlikely >> that you are going to >>> experience the problem, as the internal ring is PERF_NUM_OPS_INFLIGHT, >> which is 128, >>> higher than pparams->burst_size * NUM_MBUF_SETS, which is 256. >>> And even if you do meet that problem, then you would be reusing mbufs, >>> but that is OK as we are not verifying the output. >>> >>> >>> Thanks, >>> Pablo >>> >> Sorry for the late response. Somehow the reply went to junk in my mail >> client and it got missed. >> >> The problem would arise if the underlying implementation cannot dequeue >> the same number of ops as were enqueued in a single dequeue command. >> >> Here we have a synchronous calls to enqueue and dequeue in the same >> thread, so it may happen that for every enqueue of 32 ops, there are >> lesser number of dequeue ops (say 16). There is no thread to dequeue the >> left over 16 ops. So the difference would increase slowly and gradually >> and the application will run out of buffers. >> So we need a mechanism to drain the left over dequeue ops. > > Hi Akhil, > > I understand, I guess that this won't happen on a software device, but might happen on hardware. > As said, I think it is OK to reuse an mbuf by two different crypto operations, because we don't check the output. > > Anyway, it might be safer to proceed your way. Two things about it, though: > 1 - This should be extended to the other tests (such as test_perf_openssl) for consistency. > 2 - Since we have the test-crypto-perf app now, which cover all these tests, I was thinking of removing test_cryptodev_perf.c, > to avoid duplications. Any concerns on this? > Hi Pablo, yes, this shall be done for other tests also, but I do not have setup to test all of them. And if we are planning to remove this file altogether, then we may not need it anyway. cperf_throughput_test_runner can alone be modified with my changes, but I can test on NXP DPAA2 platform only. I can send the patch for this after testing it on DPAA2 platform. Thanks, Akhil