From: fengchengwen <fengchengwen@huawei.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, <thomas@monjalon.net>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] app/testpmd: support dump ethdev private cmd
Date: Wed, 15 Mar 2023 10:02:28 +0800 [thread overview]
Message-ID: <bbdfc4bb-0c41-a4d1-d473-42c352137333@huawei.com> (raw)
In-Reply-To: <f59e455e-3365-2d82-d2d1-d89c071a3e38@amd.com>
On 2023/3/14 21:45, Ferruh Yigit wrote:
> On 3/14/2023 11:50 AM, Chengwen Feng wrote:
>> This patch adds 'dump_eth_priv [port_id]' which could used to dump
>> the specific ethdev port private info.
>>
>
> We have already "show port ..." commands to display various port related
> information, what do you think to follow same syntax for port private info.
>
> Something like "show port private_info <port_id>"
>
>
> Or it is possible to append this to the output of the existing port info
> ("show port info <port_id>"),
> as a new section of output if port has private info?
>
> This can be an addition parameter to existing command but not sure if we
> need it, like:
> "show port info <port_id> private on"
>
> I think displaying private info as port of port info without additional
> parameter is OK, it is simpler.
+1 for this, will send a new patch.
Thanks.
>
>
...
next prev parent reply other threads:[~2023-03-15 2:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:50 Chengwen Feng
2023-03-14 13:45 ` Ferruh Yigit
2023-03-15 2:02 ` fengchengwen [this message]
2023-03-15 2:33 ` [PATCH] app/testpmd: dump private info in 'show port info' Chengwen Feng
2023-03-15 8:28 ` Singh, Aman Deep
2023-03-15 10:12 ` Ferruh Yigit
2023-03-16 1:10 ` fengchengwen
2023-03-16 7:55 ` Thomas Monjalon
2023-03-16 9:39 ` fengchengwen
2023-03-16 9:19 ` Dmitry Kozlyuk
2023-03-16 9:43 ` fengchengwen
2023-03-16 10:46 ` Ferruh Yigit
2023-03-16 15:16 ` Thomas Monjalon
2023-03-16 9:32 ` [PATCH v2] " Chengwen Feng
2023-03-16 11:42 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbdfc4bb-0c41-a4d1-d473-42c352137333@huawei.com \
--to=fengchengwen@huawei.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).